Merge "mw.Upload.BookletLayout: Use notice instead of popup for help text"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 16 Feb 2016 02:40:00 +0000 (02:40 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 16 Feb 2016 02:40:00 +0000 (02:40 +0000)
1  2 
resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.js

                );
                $ownWorkMessage.add( $notOwnWorkMessage ).find( 'a' ).attr( 'target', '_blank' );
  
 -              this.selectFileWidget = new OO.ui.SelectFileWidget();
 +              this.selectFileWidget = new OO.ui.SelectFileWidget( {
 +                      showDropTarget: true
 +              } );
                this.messageLabel = new OO.ui.LabelWidget( {
                        label: $notOwnWorkMessage
                } );
                fieldset = new OO.ui.FieldsetLayout();
                fieldset.addItems( [
                        new OO.ui.FieldLayout( this.selectFileWidget, {
 -                              align: 'top',
 -                              label: mw.msg( 'upload-form-label-select-file' )
 +                              align: 'top'
                        } ),
                        new OO.ui.FieldLayout( this.ownWorkCheckbox, {
                                align: 'inline',
                        layout.getDateFromExif( file ).done( function ( date ) {
                                layout.dateWidget.setValue( date );
                        } );
 +
 +                      layout.updateFilePreview();
                } );
  
                return this.uploadForm;
        mw.ForeignStructuredUpload.BookletLayout.prototype.renderInfoForm = function () {
                var fieldset;
  
 +              this.filePreview = new OO.ui.Widget( {
 +                      classes: [ 'mw-upload-bookletLayout-filePreview' ]
 +              } );
                this.filenameWidget = new OO.ui.TextInputWidget( {
                        required: true,
                        validate: /.+/
                        new OO.ui.FieldLayout( this.filenameWidget, {
                                label: mw.msg( 'upload-form-label-infoform-name' ),
                                align: 'top',
-                               help: mw.msg( 'upload-form-label-infoform-name-tooltip' )
+                               classes: [ 'mw-foreignStructuredUploa-bookletLayout-small-notice' ],
+                               notices: [ mw.msg( 'upload-form-label-infoform-name-tooltip' ) ]
                        } ),
                        new OO.ui.FieldLayout( this.descriptionWidget, {
                                label: mw.msg( 'upload-form-label-infoform-description' ),
                                align: 'top',
-                               help: mw.msg( 'upload-form-label-infoform-description-tooltip' )
+                               classes: [ 'mw-foreignStructuredUploa-bookletLayout-small-notice' ],
+                               notices: [ mw.msg( 'upload-form-label-infoform-description-tooltip' ) ]
                        } ),
                        new OO.ui.FieldLayout( this.categoriesWidget, {
                                label: mw.msg( 'foreign-structured-upload-form-label-infoform-categories' ),
                                align: 'top'
                        } )
                ] );
 -              this.infoForm = new OO.ui.FormLayout( { items: [ fieldset ] } );
 +              this.infoForm = new OO.ui.FormLayout( {
 +                      classes: [ 'mw-upload-bookletLayout-infoForm' ],
 +                      items: [ this.filePreview, fieldset ]
 +              } );
  
                // Validation
                this.filenameWidget.on( 'change', this.onInfoFormChange.bind( this ) );