Merge "Only pass strings to mysqli::real_escape_string"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 10 Feb 2014 19:17:47 +0000 (19:17 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 10 Feb 2014 19:17:47 +0000 (19:17 +0000)
includes/db/DatabaseMysqli.php

index e202f8a..7c25d5a 100644 (file)
@@ -275,6 +275,10 @@ class DatabaseMysqli extends DatabaseMysqlBase {
         * @return string
         */
        protected function mysqlRealEscapeString( $s ) {
+               if ( is_integer( $s ) ) {
+                       // HHVM fatals passing numbers to real_escape_string
+                       $s = (string) $s;
+               }
                return $this->mConn->real_escape_string( $s );
        }