RC_MOVE and RC_MOVE_OVER_REDIRECT are obsolete, since at least 2006.
So it is considered safe to remove.
Bug: 63755
Change-Id: I0f17c4d164585a48fb9f0d40b90a7d3b975c7ab8
* (bug 63891) Add 'X-Robots-Tag: noindex' header in action=render pages.
* SpecialPage no longer supports the syntax for invoking wfSpecial*() functions.
All special pages should subclass SpecialPage and implement the execute() method.
+* (bug 63755) The deprecated constants RC_MOVE and RC_MOVE_OVER_REDIRECT were
+ removed.
==== Renamed classes ====
* CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression
*/
define( 'RC_EDIT', 0 );
define( 'RC_NEW', 1 );
-define( 'RC_MOVE', 2 ); // obsolete
define( 'RC_LOG', 3 );
-define( 'RC_MOVE_OVER_REDIRECT', 4 ); // obsolete
define( 'RC_EXTERNAL', 5 );
/**@}*/
* @return string
*/
public function insertComment( $rc ) {
- if ( $rc->mAttribs['rc_type'] != RC_MOVE && $rc->mAttribs['rc_type'] != RC_MOVE_OVER_REDIRECT ) {
- if ( $this->isDeleted( $rc, Revision::DELETED_COMMENT ) ) {
- return ' <span class="history-deleted">' .
- $this->msg( 'rev-deleted-comment' )->escaped() . '</span>';
- } else {
- return Linker::commentBlock( $rc->mAttribs['rc_comment'], $rc->getTitle() );
- }
+ if ( $this->isDeleted( $rc, Revision::DELETED_COMMENT ) ) {
+ return ' <span class="history-deleted">' .
+ $this->msg( 'rev-deleted-comment' )->escaped() . '</span>';
+ } else {
+ return Linker::commentBlock( $rc->mAttribs['rc_comment'], $rc->getTitle() );
}
return '';
$type = $cacheEntry->mAttribs['rc_type'];
- // @todo remove handling for RC_MOVE and RC_MOVE_OVER_REDIRECT (bug 63755)
- if ( $type == RC_MOVE || $type == RC_MOVE_OVER_REDIRECT ) {
- // Use an # character to prevent collision with page names
- $cacheGroupingKey = '##' . ( $this->rcMoveIndex++ );
- } elseif ( $type == RC_LOG ) {
+ if ( $type == RC_LOG ) {
// Group by log type
$cacheGroupingKey = SpecialPage::getTitleFor(
'Log',
$r .= '<td class="mw-enhanced-rc"><span class="mw-enhancedchanges-arrow-space"></span>';
# Flag and Timestamp
- if ( $type == RC_MOVE || $type == RC_MOVE_OVER_REDIRECT ) {
- $r .= $this->recentChangesFlags( array() ); // no flags, but need the placeholders
- } else {
- $r .= $this->recentChangesFlags( array(
- 'newpage' => $type == RC_NEW,
- 'minor' => $rcObj->mAttribs['rc_minor'],
- 'unpatrolled' => $rcObj->unpatrolled,
- 'bot' => $rcObj->mAttribs['rc_bot'],
- ) );
- }
+ $r .= $this->recentChangesFlags( array(
+ 'newpage' => $type == RC_NEW,
+ 'minor' => $rcObj->mAttribs['rc_minor'],
+ 'unpatrolled' => $rcObj->unpatrolled,
+ 'bot' => $rcObj->mAttribs['rc_bot'],
+ ) );
$r .= ' ' . $rcObj->timestamp . ' </td><td>';
# Article or log link
if ( $logType ) {
$classes[] = $watched && $rc->mAttribs['rc_timestamp'] >= $watched
? 'mw-changeslist-line-watched' : 'mw-changeslist-line-not-watched';
- // Moved pages (very very old, not supported anymore)
- if ( $rc->mAttribs['rc_type'] == RC_MOVE || $rc->mAttribs['rc_type'] == RC_MOVE_OVER_REDIRECT ) {
- // Log entries
- } elseif ( $rc->mAttribs['rc_log_type'] ) {
+ if ( $rc->mAttribs['rc_log_type'] ) {
$logtitle = SpecialPage::getTitleFor( 'Log', $rc->mAttribs['rc_log_type'] );
$this->insertLog( $s, $logtitle, $rc->mAttribs['rc_log_type'] );
// Log entries (old format) or log targets, and special pages
private function buildCLink( RecentChange $cacheEntry ) {
$type = $cacheEntry->mAttribs['rc_type'];
- // Page moves, very old style, not supported anymore
- if ( $type == RC_MOVE || $type == RC_MOVE_OVER_REDIRECT ) {
- $clink = '';
// New unpatrolled pages
- } elseif ( $cacheEntry->unpatrolled && $type == RC_NEW ) {
+ if ( $cacheEntry->unpatrolled && $type == RC_NEW ) {
$clink = Linker::linkKnown( $cacheEntry->getTitle() );
// Log entries
} elseif ( $type == RC_LOG ) {
private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
$queryParams = $this->buildCurQueryParams( $cacheEntry );
$curMessage = $this->getMessage( 'cur' );
- $logTypes = array( RC_LOG, RC_MOVE, RC_MOVE_OVER_REDIRECT );
+ $logTypes = array( RC_LOG );
if ( !$showDiffLinks || in_array( $cacheEntry->mAttribs['rc_type'], $logTypes ) ) {
$curLink = $curMessage;
private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
$queryParams = $this->buildDiffQueryParams( $cacheEntry );
$diffMessage = $this->getMessage( 'diff' );
- $logTypes = array( RC_NEW, RC_LOG, RC_MOVE, RC_MOVE_OVER_REDIRECT );
+ $logTypes = array( RC_NEW, RC_LOG );
if ( !$showDiffLinks ) {
$diffLink = $diffMessage;
$lastOldid = $cacheEntry->mAttribs['rc_last_oldid'];
$lastMessage = $this->getMessage( 'last' );
$type = $cacheEntry->mAttribs['rc_type'];
- $logTypes = array( RC_LOG, RC_MOVE, RC_MOVE_OVER_REDIRECT );
+ $logTypes = array( RC_LOG );
// Make "last" link
if ( !$showDiffLinks || !$lastOldid || in_array( $type, $logTypes ) ) {
case RC_NEW:
$type = 'new';
break;
- case RC_MOVE: // obsolete
- $type = 'move';
- break;
case RC_LOG:
$type = 'log';
break;
case RC_EXTERNAL:
$type = 'external';
break;
- case RC_MOVE_OVER_REDIRECT: // obsolete
- $type = 'move over redirect';
- break;
default:
$type = "$rcType";
}