From e13c6427ca5219b5edc537d47ee060f8fa4a30f9 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Fri, 24 Feb 2017 13:31:19 -0800 Subject: [PATCH] RCFilters UI: Limit filter popup height Make sure the popup clips itself after it changes height after filtering results on search. Bug: T158118 Change-Id: I2f9e8b775b154635aa8b12f44876279173548b99 --- .../styles/mw.rcfilters.ui.FilterWrapperWidget.less | 4 ++++ .../ui/mw.rcfilters.ui.FilterWrapperWidget.js | 1 + 2 files changed, 5 insertions(+) diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less index bdc94b34ce..da6fa466b5 100644 --- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less +++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less @@ -8,6 +8,10 @@ // on the inline style of the popup margin-top: 2.4em !important; max-width: 650px; + + .oo-ui-popupWidget-body { + max-height: 70vh; + } } &-search { diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js index d46bd4b3cd..9fa58f3e28 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js @@ -73,6 +73,7 @@ mw.rcfilters.ui.FilterWrapperWidget.prototype.onTextInputChange = function ( newValue ) { // Filter the results this.filterPopup.filter( this.model.findMatches( newValue ) ); + this.capsule.popup.clip(); }; /** -- 2.20.1