From b11b51847bfbeddb3e000b715763584b0fc30989 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 14 Apr 2016 23:16:22 +0200 Subject: [PATCH] mediawiki.special.upload: Don't fail when trying to thumbnail invalid file The thumbnail spinner would spin forever if we never got a 'load' event on the image. Bug: T132242 Change-Id: I1c68ed185b58950c3648f56e07144bb29a8bed56 --- resources/src/mediawiki.special/mediawiki.special.upload.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/resources/src/mediawiki.special/mediawiki.special.upload.js b/resources/src/mediawiki.special/mediawiki.special.upload.js index 6bbe32d38c..377b1f7ebd 100644 --- a/resources/src/mediawiki.special/mediawiki.special.upload.js +++ b/resources/src/mediawiki.special/mediawiki.special.upload.js @@ -407,6 +407,10 @@ $( '#mw-upload-thumbnail .fileinfo' ).text( info ); }; + img.onerror = function () { + // Can happen for example for invalid SVG files + clearPreview(); + }; img.src = dataURL; }, mw.config.get( 'wgFileCanRotate' ) ? function ( data ) { try { -- 2.20.1