From 0effbbca5c778934023b4593ad30d8451fb8f481 Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Tue, 7 Feb 2012 19:24:31 +0000 Subject: [PATCH] Select fields returned by Revision::selectPageFields() and call Title::newFromRow() instead of Title::makeTitle() in Revision::getTitle() so that it doesn't need a separate query to load the page id or the latest revision id. --- includes/Revision.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/Revision.php b/includes/Revision.php index 094c271b70..445211c9b9 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -533,12 +533,12 @@ class Revision { $dbr = wfGetDB( DB_SLAVE ); $row = $dbr->selectRow( array( 'page', 'revision' ), - array( 'page_namespace', 'page_title' ), + self::selectPageFields(), array( 'page_id=rev_page', 'rev_id' => $this->mId ), __METHOD__ ); - if( $row ) { - $this->mTitle = Title::makeTitle( $row->page_namespace, $row->page_title ); + if ( $row ) { + $this->mTitle = Title::newFromRow( $row ); } return $this->mTitle; } -- 2.20.1