From 095e76cee1f58f8b51d1d292fb6e5b5a6d298924 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Mon, 12 Nov 2012 23:15:22 +0530 Subject: [PATCH] (bug 2865) Add lang attribute to firstHeading Adds a lang attribute to

. Interface language is applied to and content language is applied to
. This leaves firstHeading with the interface language, which is wrong in general. It also causes incorrect display of the title for languages that have custom line-height. This patch is based on code written by Munirathnam M at the Bangalore DevCamp (he couldn't submit it because of network issues). It looks OK to me, but it's my first time doing anything with $this->data in a skin, so please correct me if I'm wrong. Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b --- RELEASE-NOTES-1.21 | 2 ++ skins/Modern.php | 5 ++++- skins/MonoBook.php | 5 ++++- skins/Vector.php | 5 ++++- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES-1.21 b/RELEASE-NOTES-1.21 index 23e25b7321..16c978dba7 100644 --- a/RELEASE-NOTES-1.21 +++ b/RELEASE-NOTES-1.21 @@ -69,6 +69,8 @@ production. * (bug 41706) EditPage: Preloaded page should be converted if possible and needed. * (bug 41886) Rowspans are no longer exploded by tablesorter until the table is actually sorted. +* (bug 2865) User interface HTML elements don't use lang attribute + (completed the fix by adding the lang attribute to firstHeading) === API changes in 1.21 === * prop=revisions can now report the contentmodel and contentformat, see docs/contenthandler.txt diff --git a/skins/Modern.php b/skins/Modern.php index 1987c1cf0d..ce850a0be3 100644 --- a/skins/Modern.php +++ b/skins/Modern.php @@ -65,7 +65,10 @@ class ModernTemplate extends MonoBookTemplate { ?> -

html('title') ?>

+

html('title') ?>

diff --git a/skins/MonoBook.php b/skins/MonoBook.php index 6f74273ba9..955f05beda 100644 --- a/skins/MonoBook.php +++ b/skins/MonoBook.php @@ -84,7 +84,10 @@ class MonoBookTemplate extends BaseTemplate { data['sitenotice']) { ?>
html('sitenotice') ?>
-

html('title') ?>

+

html('title') ?>

msg('tagline') ?>
html('userlangattributes') ?>>html('subtitle') ?>
diff --git a/skins/Vector.php b/skins/Vector.php index 104cdde034..097bddea66 100644 --- a/skins/Vector.php +++ b/skins/Vector.php @@ -165,7 +165,10 @@ class VectorTemplate extends BaseTemplate { -

html( 'title' ) ?>

+

html( 'title' ) ?>

-- 2.20.1