From: Max Semenik <maxsem.wiki@gmail.com>
Date: Mon, 9 Apr 2018 21:35:29 +0000 (-0700)
Subject: Log DefaultPreferencesFactory usage
X-Git-Tag: 1.31.0-rc.0~147^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22upgrade%22%2C%22reinstall=non%22%29%20.%20%22?a=commitdiff_plain;h=ba35762773626d980c68e080d624cf426c142e07;p=lhc%2Fweb%2Fwiklou.git

Log DefaultPreferencesFactory usage

Bug: T190425
Change-Id: I17e4792501811787ce90195c07915876d6c233e8
---

diff --git a/includes/ServiceWiring.php b/includes/ServiceWiring.php
index dd837a848c..da3f3209d8 100644
--- a/includes/ServiceWiring.php
+++ b/includes/ServiceWiring.php
@@ -583,7 +583,10 @@ return [
 		$authManager = AuthManager::singleton();
 		$linkRenderer = $services->getLinkRendererFactory()->create();
 		$config = $services->getMainConfig();
-		return new DefaultPreferencesFactory( $config, $wgContLang, $authManager, $linkRenderer );
+		$factory = new DefaultPreferencesFactory( $config, $wgContLang, $authManager, $linkRenderer );
+		$factory->setLogger( LoggerFactory::getInstance( 'preferences' ) );
+
+		return $factory;
 	},
 
 	'HttpRequestFactory' => function ( MediaWikiServices $services ) {
diff --git a/includes/preferences/DefaultPreferencesFactory.php b/includes/preferences/DefaultPreferencesFactory.php
index b2b68d21f9..6eceb84bcf 100644
--- a/includes/preferences/DefaultPreferencesFactory.php
+++ b/includes/preferences/DefaultPreferencesFactory.php
@@ -45,6 +45,8 @@ use MWTimestamp;
 use Parser;
 use ParserOptions;
 use PreferencesForm;
+use Psr\Log\LoggerAwareTrait;
+use Psr\Log\NullLogger;
 use Skin;
 use SpecialPage;
 use Status;
@@ -57,6 +59,7 @@ use Xml;
  * This is the default implementation of PreferencesFactory.
  */
 class DefaultPreferencesFactory implements PreferencesFactory {
+	use LoggerAwareTrait;
 
 	/** @var Config */
 	protected $config;
@@ -86,6 +89,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
 		$this->contLang = $contLang;
 		$this->authManager = $authManager;
 		$this->linkRenderer = $linkRenderer;
+		$this->logger = new NullLogger();
 	}
 
 	/**
@@ -137,6 +141,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
 		Hooks::run( 'GetPreferences', [ $user, &$preferences ] );
 
 		$this->loadPreferenceValues( $user, $context, $preferences );
+		$this->logger->debug( "Created form descriptor for user '{$user->getName()}'" );
 		return $preferences;
 	}