Upgrade mismatched commit() warnings to exceptions

I saw no WMF logs for these in the last 7 days.

Change-Id: I725535925ba3fc68cee485767f18937fb8f239bf

diff --git a/includes/db/Database.php b/includes/db/Database.php
index bd1e375..ef4a7b7 100644 (file)
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -2654,7 +2654,10 @@ abstract class DatabaseBase implements IDatabase {
                        if ( !$this->mTrxLevel ) {
                                return; // nothing to do
                        } elseif ( !$this->mTrxAutomatic ) {
-                               wfWarn( "$fname: Flushing an explicit transaction, getting out of sync!" );
+                               throw new DBUnexpectedError(
+                                       $this,
+                                       "$fname: Flushing an explicit transaction, getting out of sync!"
+                               );
                        }
                } else {
                        if ( !$this->mTrxLevel ) {