Merge "don't overwrite $item['single-id'] in makeListItem in SkinTemplate"
authorIAlex <ialex.wiki@gmail.com>
Sun, 21 Oct 2012 12:54:28 +0000 (12:54 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 21 Oct 2012 12:54:28 +0000 (12:54 +0000)
includes/SkinTemplate.php

index b8b1654..5a32d47 100644 (file)
@@ -1750,7 +1750,7 @@ abstract class BaseTemplate extends QuickTemplate {
                        foreach ( array( 'id', 'class', 'active', 'tag' ) as $k ) {
                                unset( $link[$k] );
                        }
-                       if ( isset( $item['id'] ) ) {
+                       if ( isset( $item['id'] ) && !isset( $item['single-id'] ) ) {
                                // The id goes on the <li> not on the <a> for single links
                                // but makeSidebarLink still needs to know what id to use when
                                // generating tooltips and accesskeys.