From e827f9969738a7676082cd8ffa03f2462afe30dd Mon Sep 17 00:00:00 2001 From: Bryan Davis Date: Thu, 14 Apr 2016 14:08:38 -0600 Subject: [PATCH] SpecialRunJobs: delegate error handling to MWExceptionHandler Make the custom error handler that is installed to suppress Cookie header errors delegate unhandled errors to the default MediaWiki error handler. This will preserve fatal error logging for errors raised by jobs. Bug: T89169 Change-Id: I52ef544fa18351bf310b04b17ab4e0239020fe20 --- includes/specials/SpecialRunJobs.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/includes/specials/SpecialRunJobs.php b/includes/specials/SpecialRunJobs.php index 2312f76399..ce5533fbf0 100644 --- a/includes/specials/SpecialRunJobs.php +++ b/includes/specials/SpecialRunJobs.php @@ -94,8 +94,11 @@ class SpecialRunJobs extends UnlistedSpecialPage { if ( strpos( $errstr, 'Cannot modify header information' ) !== false ) { return true; // bug T115413 } - // Delegate unhandled errors to the default handlers - return false; + // Delegate unhandled errors to the default MediaWiki handler + // so that fatal errors get proper logging (T89169) + return call_user_func_array( + 'MWExceptionHandler::handleError', func_get_args() + ); } ); } -- 2.20.1