From d4aaeb0a99150bf556bec0cf6619e70e594652db Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 2 Feb 2018 12:37:46 -0800 Subject: [PATCH] skins: Deprecate QuickTemplate::setTranslator and MediaWikiI18N::set These methods have no callers anywhere in Wikimedia Git. Deprecate it now, remove in MediaWiki 1.32. This is part of removing the legacy MediaWikiI18N class. Bug: T186090 Change-Id: Ie2ca6a4b4f4481dc5cd81e7ed5543a05ee611f42 --- RELEASE-NOTES-1.31 | 2 ++ includes/skins/MediaWikiI18N.php | 5 +++++ includes/skins/QuickTemplate.php | 3 +++ 3 files changed, 10 insertions(+) diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31 index 20bea0bd2a..5e1e8cd3e6 100644 --- a/RELEASE-NOTES-1.31 +++ b/RELEASE-NOTES-1.31 @@ -194,6 +194,8 @@ changes to languages because of Phabricator reports. Setting template variables by reference allowed violating the principle of data being immutable once added to the skin template. In practice, this method was not being used for that. Rather, setRef() existed as memory optimisation for PHP 4. +* QuickTemplate::setTranslator() was deprecated in favour of Skin::msg() parameters. +* MediaWikiI18N::set() was deprecated in favour of Skin::msg() parameters. * Passing false to ParserOptions::setWrapOutputClass() is deprecated. Use the 'unwrap' transform to ParserOutput::getText() instead. * ParserOutput objects generated using a non-default value for diff --git a/includes/skins/MediaWikiI18N.php b/includes/skins/MediaWikiI18N.php index 7fcdb3c96b..eeedaada20 100644 --- a/includes/skins/MediaWikiI18N.php +++ b/includes/skins/MediaWikiI18N.php @@ -28,7 +28,12 @@ class MediaWikiI18N { private $context = []; + /** + * @deprecate since 1.31 Use BaseTemplate::msg() or Skin::msg() instead for setting + * message parameters. + */ function set( $varName, $value ) { + wfDeprecated( __METHOD__, '1.31' ); $this->context[$varName] = $value; } diff --git a/includes/skins/QuickTemplate.php b/includes/skins/QuickTemplate.php index 19b41ba969..7782e70770 100644 --- a/includes/skins/QuickTemplate.php +++ b/includes/skins/QuickTemplate.php @@ -104,8 +104,11 @@ abstract class QuickTemplate { /** * @param MediaWikiI18N &$t + * @deprecate since 1.31 Use BaseTemplate::msg() or Skin::msg() instead for setting + * message parameters. */ public function setTranslator( &$t ) { + wfDeprecated( __METHOD__, '1.31' ); $this->translator = &$t; } -- 2.20.1