From a32e0ca878720e5383cd2d2866bbd9ab00c7df1f Mon Sep 17 00:00:00 2001
From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Thu, 4 Feb 2010 21:07:48 +0000
Subject: [PATCH] Per Tim, fix r59949: use CSS padding (margin doesn't seem to
 work on Firefox and Safari) instead of fake empty columns, also added
 text-align:center

---
 includes/specials/SpecialRevisiondelete.php | 16 ++++++++--------
 skins/common/shared.css                     |  5 +++++
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/includes/specials/SpecialRevisiondelete.php b/includes/specials/SpecialRevisiondelete.php
index f49e7458d0..b2db869c55 100644
--- a/includes/specials/SpecialRevisiondelete.php
+++ b/includes/specials/SpecialRevisiondelete.php
@@ -441,7 +441,7 @@ class SpecialRevisionDelete extends UnlistedSpecialPage {
 	*/
 	protected function buildCheckBoxes() {
 		global $wgRequest;
-		
+
 		$html = '<table>';
 		// If there is just one item, use checkboxes
 		$list = $this->getList();
@@ -462,10 +462,10 @@ class SpecialRevisionDelete extends UnlistedSpecialPage {
 		// Otherwise, use tri-state radios
 		} else {
 			$html .= '<tr>';
-			$html .= '<th>'.wfMsgHtml('revdelete-radio-same').'</th><th>&nbsp;</th>';
-			$html .= '<th>'.wfMsgHtml('revdelete-radio-unset').'</th><th>&nbsp;</th>';
-			$html .= '<th>'.wfMsgHtml('revdelete-radio-set').'</th><th>&nbsp;</th>';
-			$html .= '<th></th></tr>';
+			$html .= '<th class="mw-revdel-checkbox">'.wfMsgHtml('revdelete-radio-same').'</th>';
+			$html .= '<th class="mw-revdel-checkbox">'.wfMsgHtml('revdelete-radio-unset').'</th>';
+			$html .= '<th class="mw-revdel-checkbox">'.wfMsgHtml('revdelete-radio-set').'</th>';
+			$html .= "<th></th></tr>\n";
 			foreach( $this->checks as $item ) {
 				list( $message, $name, $field ) = $item;
 				// If there are several items, use third state by default...
@@ -474,9 +474,9 @@ class SpecialRevisionDelete extends UnlistedSpecialPage {
 				} else {
 					$selected = -1; // use existing field
 				}
-				$line = '<td>' . Xml::radio( $name, -1, $selected == -1 ) . '</td><td>&nbsp;</td>';
-				$line .= '<td>' . Xml::radio( $name, 0, $selected == 0 ) . '</td><td>&nbsp;</td>';
-				$line .= '<td>' . Xml::radio( $name, 1, $selected == 1 ) . '</td><td>&nbsp;</td>';
+				$line = '<td class="mw-revdel-checkbox">' . Xml::radio( $name, -1, $selected == -1 ) . '</td>';
+				$line .= '<td class="mw-revdel-checkbox">' . Xml::radio( $name, 0, $selected == 0 ) . '</td>';
+				$line .= '<td class="mw-revdel-checkbox">' . Xml::radio( $name, 1, $selected == 1 ) . '</td>';
 				$label = wfMsgHtml($message);
 				if( $field == Revision::DELETED_RESTRICTED ) {
 					$label = "<b>$label</b>";
diff --git a/skins/common/shared.css b/skins/common/shared.css
index 777f80da2a..646ee5fe95 100644
--- a/skins/common/shared.css
+++ b/skins/common/shared.css
@@ -547,6 +547,11 @@ input.mw-revdelundel-hidden {
 	visibility: hidden;
 }
 
+td.mw-revdel-checkbox, th.mw-revdel-checkbox {
+	padding-right: 10px;
+	text-align: center;
+}
+
 /* feed links */
 a.feedlink {
 	background: url("images/feed-icon.png") center left no-repeat;
-- 
2.20.1