From 8eccca254d05772345ed9857a21ebe2817eaf454 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 17 Mar 2016 23:22:00 +0100 Subject: [PATCH] SpecialUploadStash: Disable output gzipping when outputting remove scaled thumb This is the only code path that wasn't calling wfResetOutputBuffers() already. All other ones end up in outputLocalFile(), which calls it via StreamFile::prepareForStream(). I can't really tell why this causes Varnish stuff to go bust, but it's definitely the right thing to do anyway. Bug: T130204 Change-Id: Ib6bc9c64c6c893fd7f5a5d906da32d9bee509a98 --- includes/specials/SpecialUploadStash.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/specials/SpecialUploadStash.php b/includes/specials/SpecialUploadStash.php index f2da81f1f2..2e622e1238 100644 --- a/includes/specials/SpecialUploadStash.php +++ b/includes/specials/SpecialUploadStash.php @@ -306,6 +306,8 @@ class SpecialUploadStash extends UnlistedSpecialPage { if ( $size > self::MAX_SERVE_BYTES ) { throw new SpecialUploadStashTooLargeException(); } + // Cancel output buffering and gzipping if set + wfResetOutputBuffers(); self::outputFileHeaders( $contentType, $size ); print $content; -- 2.20.1