From 633c4542c6ad7ace1d8a5683f0f404405bc9520c Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Tue, 3 Apr 2012 15:05:50 +0200 Subject: [PATCH] disable broken ApiBlockTest::testMakeNormalBlock() That test has probably always been broken and use an invalid token. The bug tracking brokenness is http://bugzilla.wikimedia.org/35646 Since the broken test is merged in master, that block the integration of Jenkins and Gerrit by having any submitted patchset to be reported as failling :-( Root cause is https://gerrit.wikimedia.org/r/3434 which made the Block/Unblock API to actually verify the token previously always considered valid (bug 34212). Change-Id: Iecf6b083163c214c734360b2f6d9b4bed8af07dc --- tests/phpunit/includes/api/ApiBlockTest.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/phpunit/includes/api/ApiBlockTest.php b/tests/phpunit/includes/api/ApiBlockTest.php index d9ea7b5a87..84c0fc2414 100644 --- a/tests/phpunit/includes/api/ApiBlockTest.php +++ b/tests/phpunit/includes/api/ApiBlockTest.php @@ -26,6 +26,16 @@ class ApiBlockTest extends ApiTestCase { } } + /** + * This test has probably always been broken and use an invalid token + * Bug tracking brokenness is https://bugzilla.wikimedia.org/35646 + * + * Root cause is https://gerrit.wikimedia.org/r/3434 + * Which made the Block/Unblock API to actually verify the token + * previously always considered valid (bug 34212). + * + * @group Broken + */ function testMakeNormalBlock() { $data = $this->getTokens(); -- 2.20.1