jenkins-bot [Thu, 29 Aug 2019 05:25:40 +0000 (05:25 +0000)]
Merge "profiler: Centralise output responsibility from ProfilerOutputText to Profiler"
jenkins-bot [Thu, 29 Aug 2019 03:19:42 +0000 (03:19 +0000)]
Merge "mediawiki.Uri: Add another test for arrayParams"
Bartosz Dziewoński [Wed, 28 Aug 2019 12:17:13 +0000 (14:17 +0200)]
mediawiki.Uri: Add another test for arrayParams
Verify that the added handling is correctly conditional.
Bug: T231382
Change-Id: I71b834c1c0a7bdaf28d990eafd4ce5d70a55e141
jenkins-bot [Wed, 28 Aug 2019 20:57:14 +0000 (20:57 +0000)]
Merge "Special:NewFiles: Use a proper user widget instead"
jenkins-bot [Wed, 28 Aug 2019 20:57:07 +0000 (20:57 +0000)]
Merge "resourceloader: Purge localStorage blob if last written 30+ days ago"
jenkins-bot [Wed, 28 Aug 2019 20:43:44 +0000 (20:43 +0000)]
Merge "Pagers: Drop 'newbie' feature"
jenkins-bot [Wed, 28 Aug 2019 20:09:58 +0000 (20:09 +0000)]
Merge "Fix call to non-existing TempFSFileFactory::getTempFSFile()"
Jforrester [Wed, 28 Aug 2019 19:23:51 +0000 (19:23 +0000)]
Merge "Special:DeletedContributions: Drop 'newbies' feature"
daniel [Wed, 28 Aug 2019 19:08:58 +0000 (21:08 +0200)]
Fix call to non-existing TempFSFileFactory::getTempFSFile()
Should be TempFSFileFactory::newTempFSFile()
Bug: T231488
Change-Id: I9fbf7d993773f55965268ac10b347110148671c9
jenkins-bot [Wed, 28 Aug 2019 18:51:41 +0000 (18:51 +0000)]
Merge "Fix typo in comment"
jenkins-bot [Wed, 28 Aug 2019 18:46:51 +0000 (18:46 +0000)]
Merge "Make WantedQueryPage::makeWlhLink protected"
jenkins-bot [Wed, 28 Aug 2019 18:21:37 +0000 (18:21 +0000)]
Merge "PermissionManager should not cache anonymous rights under ID 0"
James D. Forrester [Fri, 2 Aug 2019 19:34:44 +0000 (12:34 -0700)]
Special:NewFiles: Use a proper user widget instead
Change-Id: I276f55e9d4dd2d539dae232c7a4c1e71745a6168
James D. Forrester [Fri, 2 Aug 2019 19:33:56 +0000 (12:33 -0700)]
Pagers: Drop 'newbie' feature
Change-Id: I14c4da7b107aa9c712bd81522021ae7ecaf2b790
James D. Forrester [Tue, 27 Aug 2019 20:41:00 +0000 (13:41 -0700)]
Special:DeletedContributions: Drop 'newbies' feature
Change-Id: I32c67fb19f50f3949ffe981488c009c82a244999
jenkins-bot [Wed, 28 Aug 2019 17:41:39 +0000 (17:41 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Wed, 28 Aug 2019 17:34:58 +0000 (17:34 +0000)]
Merge "Remove unused localisation message 'wlshowlast'"
jenkins-bot [Wed, 28 Aug 2019 17:33:48 +0000 (17:33 +0000)]
Merge "Remove unused localisation messages 'ascending_abbrev', 'descending_abbrev'"
jenkins-bot [Wed, 28 Aug 2019 17:23:53 +0000 (17:23 +0000)]
Merge "Upstream "pulsating dot" widget from VE"
Ostrzyciel [Wed, 28 Aug 2019 17:12:36 +0000 (19:12 +0200)]
Make WantedQueryPage::makeWlhLink protected
Bug: T231481
Change-Id: I6ace1bb99879ec8256b29f86220e8fc2e785f593
jenkins-bot [Wed, 28 Aug 2019 17:09:44 +0000 (17:09 +0000)]
Merge "Integration tests for FileBackendGroup"
jenkins-bot [Wed, 28 Aug 2019 17:04:44 +0000 (17:04 +0000)]
Merge "Grunt: Expand js{,on} for readability"
Petr Pchelko [Tue, 20 Aug 2019 20:59:49 +0000 (13:59 -0700)]
PermissionManager should not cache anonymous rights under ID 0
Bug: T228253
Change-Id: I8a54830842f220ff1ac4402a3380c2229a99b619
Timo Tijhof [Wed, 28 Aug 2019 00:41:42 +0000 (01:41 +0100)]
profiler: Centralise output responsibility from ProfilerOutputText to Profiler
Make it Profiler.php's responsibility to enforce this, based on the
existing signal from ProfilerOutput::logsToOutput().
The ProfilerOutputText class should not have to double-check this
a second time.
Long-term, I'd like even this check in Profiler::logDataPageOutputOnly
to be removed, because really the external caller of that should
know whether it is safe to output stuff or not rather than stashing
its own state inside Profiler::$allowOutput and then implicitly
reading it back out again later on. But, that's for another time.
Also:
* Remove use of deprecated Profiler::setTemplated while at it.
* Make 'visible' parameter explicit, as for other parameters.
Change-Id: Iaa3fc4ea25a059b90235d769db60c04b8f152f05
Arlo Breault [Wed, 28 Aug 2019 16:05:09 +0000 (12:05 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
06a41a99d7811a361446b894da7c5c8224398ad1
Change-Id: I9d324b3e6e9167683c15b7fee2a53b598d79a67c
Ed Sanders [Wed, 28 Aug 2019 15:41:47 +0000 (16:41 +0100)]
Docs: Standardise "messages used" comments
Change-Id: Ie99f8a62da734956863b1e1c41c8768f0e083fed
Ed Sanders [Wed, 28 Aug 2019 15:40:08 +0000 (16:40 +0100)]
Grunt: Expand js{,on} for readability
Change-Id: Ib3bfb1a9d6547e1062ea3ad08de7ea721c111586
jenkins-bot [Wed, 28 Aug 2019 15:25:51 +0000 (15:25 +0000)]
Merge "ApiFeedContributions: Drop 'newbies' feature"
James D. Forrester [Tue, 27 Aug 2019 20:40:40 +0000 (13:40 -0700)]
ApiFeedContributions: Drop 'newbies' feature
It has been broken since 2011 (r100315), so no need for
deprecation.
Change-Id: I099f52211c8ce401d827405cb313e1d3932b92f8
jenkins-bot [Wed, 28 Aug 2019 12:56:25 +0000 (12:56 +0000)]
Merge "skins: Skin::getSkinNameMessages() method is now deprecated"
jenkins-bot [Wed, 28 Aug 2019 12:56:19 +0000 (12:56 +0000)]
Merge "skins: Remove use of deprecated MessageCache::singleton()"
Bartosz Dziewoński [Wed, 28 Aug 2019 10:51:44 +0000 (12:51 +0200)]
Remove unused localisation message 'wlshowlast'
Not used since
34a3efd5f75ca25f1b8b3b3a2efd13bfb1f7c631.
Note that a similar message 'rclinks' is still used.
Bug: T224429
Change-Id: I471a6a88b838bd7f1fab34c531c556e8ccd2779a
Bartosz Dziewoński [Wed, 28 Aug 2019 10:47:24 +0000 (12:47 +0200)]
Remove unused localisation messages 'ascending_abbrev', 'descending_abbrev'
Not used since
987a860df428e3c70fd81c404f1f7a300345dc48.
The messages 'sort-descending', 'sort-ascending' serve the same purpose.
Bug: T224429
Change-Id: Iabcf83c80aa3fc387ea908868838b73254765a82
Bartosz Dziewoński [Wed, 28 Aug 2019 11:47:03 +0000 (13:47 +0200)]
Re-add missing messages in languages/i18n/exif/qqq.json
Added in
7c68604e4c5e3f61884d529a37a2878c3155d343, incorrectly removed
by translation updater in
7881d44f690cc1e7415bb6cbaedc02d586a64498?
Checks are failing because of this.
Change-Id: I264f0f1cf3dcd69bbf8d43ad057a81e3f39ed623
D3r1ck01 [Wed, 28 Aug 2019 09:46:06 +0000 (09:46 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 28 Aug 2019 09:19:14 +0000 (09:19 +0000)]
Merge "Move Title::isNamespaceProtected() to PermissionManager."
jenkins-bot [Wed, 28 Aug 2019 09:02:59 +0000 (09:02 +0000)]
Merge "Fix entites typos"
jenkins-bot [Wed, 28 Aug 2019 08:44:18 +0000 (08:44 +0000)]
Merge "LockManagerGroup tweaks"
jenkins-bot [Wed, 28 Aug 2019 08:44:12 +0000 (08:44 +0000)]
Merge "profiler: Rename Profile::setTemplated to Profile::setAllowOutput"
jenkins-bot [Wed, 28 Aug 2019 08:32:06 +0000 (08:32 +0000)]
Merge "Document that img_description_id is a comment id"
Aryeh Gregor [Wed, 21 Aug 2019 13:16:27 +0000 (16:16 +0300)]
Integration tests for FileBackendGroup
100% coverage except for one bit of the code that I didn't understand.
Unit tests to come, together with rewrite as a service.
Change-Id: Ib01758d994a9e5587a4fcb5edc3d80010ef05615
Aryeh Gregor [Thu, 15 Aug 2019 18:07:36 +0000 (21:07 +0300)]
LockManagerGroup tweaks
One small change that was supposed to be in
5a6c18a0863 but didn't make
it into the patch version that got merged, and removal of some long-dead
code.
phan objected to the use of new $class without being explicitly
reassured that $class is, in fact, a string. I don't know why.
Change-Id: Ifa00c59ab4464109414f21db37e3a6db21decdf3
Translation updater bot [Wed, 28 Aug 2019 07:31:09 +0000 (09:31 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8380b27a31ae89200aa7e7ccf38424acb244e288
Niklas Laxström [Wed, 28 Aug 2019 07:13:26 +0000 (09:13 +0200)]
Fix typo in comment
Change-Id: Iebb57a49156f4efc6f45079d239eef2464c0f554
jenkins-bot [Wed, 28 Aug 2019 06:57:34 +0000 (06:57 +0000)]
Merge "Let Html::element do the HTML encoding"
jenkins-bot [Wed, 28 Aug 2019 06:57:28 +0000 (06:57 +0000)]
Merge "parserTests: Add parser test with filename containing single quotes"
Zoranzoki21 [Wed, 28 Aug 2019 04:36:04 +0000 (06:36 +0200)]
Fix entites typos
Bug: T201491
Change-Id: I241fda87b0e53e804f6bdd48eb975a79e9f176d2
jenkins-bot [Wed, 28 Aug 2019 04:29:38 +0000 (04:29 +0000)]
Merge "Revert actor changes to populateLogSearch.php"
jenkins-bot [Wed, 28 Aug 2019 04:29:31 +0000 (04:29 +0000)]
Merge "MessageCache: Add STRAIGHT_JOIN to avoid planner oddness"
jenkins-bot [Wed, 28 Aug 2019 01:11:43 +0000 (01:11 +0000)]
Merge "resources: Also add jQuery Migrate to foreign-resources.yaml"
Timo Tijhof [Wed, 28 Aug 2019 00:20:47 +0000 (01:20 +0100)]
profiler: Rename Profile::setTemplated to Profile::setAllowOutput
This is set from three places:
1) SkinTemplate.php, 2) Maintenance.php, and 3) load.php.
These last two are very much *not* HTML-templated output.
Rename these this method pair to getAllowOutput/setAllowOutput instead,
which is less confusing going forward. No known callers outside of
core (updated in the next commit), but I'll keep compat for one
release cycle just in case.
Change-Id: I828f95332dca3c6766b2b485ffb71762542b42d7
jenkins-bot [Tue, 27 Aug 2019 23:28:10 +0000 (23:28 +0000)]
Merge "Follow-up
225b462: Remove 'apisandbox-api-disabled' i18n too"
Timo Tijhof [Tue, 27 Aug 2019 15:51:54 +0000 (16:51 +0100)]
MessageCache: Increase APC 'messages-big' expiry from 1min to 1h
Bug: T218207
Change-Id: Ic5d2a556912e2a16ee899eec3a0670f00dec9a8c
jenkins-bot [Tue, 27 Aug 2019 22:48:04 +0000 (22:48 +0000)]
Merge "mw.Uri: Add support for array parameters with explicit indexes"
James D. Forrester [Tue, 27 Aug 2019 22:47:18 +0000 (15:47 -0700)]
Follow-up
225b462: Remove 'apisandbox-api-disabled' i18n too
Initially removed, lost in rebase.
Bug: T224429
Change-Id: Ibb9c0ab1dcd2b3119cda570552d54ff866677d95
Derick Alangi [Tue, 27 Aug 2019 22:04:22 +0000 (23:04 +0100)]
skins: Skin::getSkinNameMessages() method is now deprecated
No longer used per CS below;
https://codesearch.wmflabs.org/search/?q=getSkinNameMessages&i=nope&files=&repos=
Change-Id: I2be9f417444024c3612db3e771a385ce5ed12ec4
Derick Alangi [Tue, 27 Aug 2019 22:01:04 +0000 (23:01 +0100)]
skins: Remove use of deprecated MessageCache::singleton()
Change-Id: I1c6d3874dd78023d743a418039c23adb55578f98
jenkins-bot [Tue, 27 Aug 2019 22:21:57 +0000 (22:21 +0000)]
Merge "Recognize exif values for Apple iOS photo modes"
Bartosz Dziewoński [Tue, 27 Aug 2019 20:14:01 +0000 (22:14 +0200)]
mw.Uri: Add support for array parameters with explicit indexes
When the new 'arrayParams' option is set, query strings like
`&foo[0]=a&foo[1]=b` will be parsed as a single parameter `foo`
containing an array, rather than two separate parameters.
The new option also affects the behavior of array parameters like
`&foo[]=a&foo[]=b`, which will be parsed as a parameter named `foo`
rather than `foo[]`, and disables array handling for parameters that
don't contain an array index at the end.
Unlike in PHP, this does not handle associative or multi-dimensional
arrays, but that may be improved in the future.
Bug: T231382
Change-Id: I48d4bb3fdf0ea7f5eb133c59bf63651ba356fc42
Reedy [Tue, 27 Aug 2019 07:40:29 +0000 (08:40 +0100)]
Revert "Output more MW version info in update.php"
Left changes to SpecialVersion.php
This reverts commit
e73328601d51674e8fef89c3db12b30ceafd702f.
Bug: T227489
Change-Id: I673b6a6abb73e93d2253fc554f94ef9c833dae0c
Derk-Jan Hartman [Tue, 27 Aug 2019 20:31:43 +0000 (22:31 +0200)]
Recognize exif values for Apple iOS photo modes
CustomRendered value 2-8 are used by Apple to indicate the processing
modes used like HDR, Portrait and Panorama.
Bug: T231385
Change-Id: I767a81a8bebdf25c230b104d35236a4b38cbe4ed
Timo Tijhof [Tue, 6 Aug 2019 00:12:39 +0000 (01:12 +0100)]
resourceloader: Purge localStorage blob if last written 30+ days ago
Our version hashes are 6-7 chars of base36 from a fnv132 digest.
Using the formula of <https://en.wikipedia.org/wiki/Birthday_attack>
that provides enough range to publish 2087 different versions of
a given module before there is a 0.1% probability to clash with
another version, 660 versions for a 0.01% probability, and
209 versions of a 0.001% probability.
I think 200 versions of a single module is a good enough space
for most use cases we have of the version hash (such as the E-Tag
header for browser caches and HTTP proxies, whic have have a 30-day
TTL).
However, for mw.loader.store it's a bit tricky. It's generally
more than enough given that (unlike HTTP caches) we only store
1 version of any given module so we don't need it to be different
from N different versions, just the last one.
But, also unlike HTTP caches, localStorage has no expiry. This means
that while for a single user it only has to be different from their
last-seen version, but from the server perspective, it needs to be
different from all possible versions a given user may have last seen.
This is problematic and effectively unbounded.
Plug this hole by discarding the localStorage value and starting
fresh, if the user last visited the site more than 30 days ago.
This is also in preparation for T229245, which will reduce the
hash from 6-7 chars to 5 chars. With that size, we can support only
348 different versions at a 0.1% probability (instead of 2087).
Which is fine for the bounded use cases with a TTL, but would make
the unbounded nature of localStorage even more problematic.
Bug: T229245
Change-Id: Iba8cdbebf1bb5c7c628832708fd656fcef61c095
jenkins-bot [Tue, 27 Aug 2019 19:49:54 +0000 (19:49 +0000)]
Merge "Special:NewFiles: Drop 'newbies' feature"
jenkins-bot [Tue, 27 Aug 2019 19:45:27 +0000 (19:45 +0000)]
Merge "Special:Contributions: Drop 'newbies' feature"
James D. Forrester [Fri, 2 Aug 2019 19:32:23 +0000 (12:32 -0700)]
Special:NewFiles: Drop 'newbies' feature
Change-Id: I946d7027db0fec90d8af68f9370fdd7fe5fd61e0
James D. Forrester [Fri, 2 Aug 2019 19:06:31 +0000 (12:06 -0700)]
Special:Contributions: Drop 'newbies' feature
This old, low-value feature has been replaced by the much more featureful
functionality on RecentChanges, which has the added advantage of using an
efficient query.
Bug: T220447
Change-Id: I2e6e12b2ad627ecc346883878811ec0164cd03da
jenkins-bot [Tue, 27 Aug 2019 18:35:09 +0000 (18:35 +0000)]
Merge "WebStart: Avoid DB or uselang for nonwrite-api-promise-error message"
jenkins-bot [Tue, 27 Aug 2019 18:33:05 +0000 (18:33 +0000)]
Merge "MessageCache: Remove $wgMsgCacheExpiry configuration var"
jenkins-bot [Tue, 27 Aug 2019 18:31:18 +0000 (18:31 +0000)]
Merge "MessageCache: Minor wgMsgCacheExpiry doc fix, and clear constant access"
jenkins-bot [Tue, 27 Aug 2019 18:25:54 +0000 (18:25 +0000)]
Merge "BadFileLookup::isBadFile() expects null, not false"
Aryeh Gregor [Tue, 27 Aug 2019 17:21:28 +0000 (20:21 +0300)]
BadFileLookup::isBadFile() expects null, not false
This deviation in behavior from wfIsBadImage() is accounted for in that
function, but I didn't account for it when changing callers to use the
service.
Bug: T231340
Bug: T231353
Change-Id: Iddf177770fb1763ed295d694ed6bab441ea9ab73
Timo Tijhof [Tue, 27 Aug 2019 15:35:49 +0000 (16:35 +0100)]
MessageCache: Remove $wgMsgCacheExpiry configuration var
This variable has never been set to anything other than the default value of
24 hours as introduced in 2003 (r2203, r2204; or
036ff960ce,
edf6b38626).
The variable has never changed in core, it's not overridden at WMF,
and MessageCache is not constructed anywhere other than ServiceWiring.php
anywhere in repos on Wikimedia Gerrit, indexed by MediaWiki Codesearch,
or any GitHub-hosted repository (incl Wikia repos and WikiHow mirrors).
I've also checked all GitHub-hosted repos for boilerplates and/or public
settings files from devs or prod, and couldn't find any example of
this being overridden (after filtering out copies of the core files
themselves). Rather than having to support potentially hard-to-predict
interactions betweeen caching layers by checking its state, make it
a constant so we can code reason about it more easily.
Change-Id: Ie2e139001aae3ac54b509d94a3d917bb408eaca0
jenkins-bot [Tue, 27 Aug 2019 17:23:05 +0000 (17:23 +0000)]
Merge "Remove hard deprecation of PasswordPolicyChecks::checkPopularPasswordBlacklist"
jenkins-bot [Tue, 27 Aug 2019 17:04:14 +0000 (17:04 +0000)]
Merge "Restore some previous constructor calls"
Reedy [Tue, 27 Aug 2019 16:53:27 +0000 (17:53 +0100)]
Remove hard deprecation of PasswordPolicyChecks::checkPopularPasswordBlacklist
It's causing quite a bit of WMF log spam because it's still used in wmf-config
Partial revert of I4c90e361b7538efeb0c5efa7ca61aed2e468591c
Change-Id: I7d1282e4260e7a42bee35b81d77470eb40dea818
jenkins-bot [Tue, 27 Aug 2019 16:29:10 +0000 (16:29 +0000)]
Merge "Avoid PHP warning due to bogus second tideways_xhprof_enable() argument"
Timo Tijhof [Tue, 27 Aug 2019 15:26:20 +0000 (16:26 +0100)]
MessageCache: Minor wgMsgCacheExpiry doc fix, and clear constant access
The class used is typed against BagOStuff so access the constant
from there instead.
Bug: T218207
Change-Id: Ie22d6aa5877fb5e8e2ae0b3be87f4b28f45ad763
jenkins-bot [Tue, 27 Aug 2019 16:21:21 +0000 (16:21 +0000)]
Merge "rdbms: remove unused $fulltextEnabled field from DatabaseSqlite"
jenkins-bot [Tue, 27 Aug 2019 15:53:34 +0000 (15:53 +0000)]
Merge "Hard deprecate new SearchResult() and introduce RevisionSearchResult"
jenkins-bot [Tue, 27 Aug 2019 15:41:15 +0000 (15:41 +0000)]
Merge "LockManagerGroupFactory to replace singletons"
jenkins-bot [Tue, 27 Aug 2019 15:34:43 +0000 (15:34 +0000)]
Merge "Use correct metadata when adding exact query match"
David Causse [Thu, 1 Aug 2019 20:38:46 +0000 (22:38 +0200)]
Hard deprecate new SearchResult() and introduce RevisionSearchResult
Transitional step for the transformation of SearchResult into an
abstract base class:
- RevisionSearchResult is introduced to behave like SearchResult
- methods are currently shared between RevisionSearchResult and
SearchResult in the RevisionSearchResultTrait
Bug: T228626
Change-Id: I13d132de50f6c66086b7f9055d036f2e76667b27
jenkins-bot [Tue, 27 Aug 2019 15:26:47 +0000 (15:26 +0000)]
Merge "mail: Avoid use of global state and use MediaWiki services DI"
jenkins-bot [Tue, 27 Aug 2019 15:22:40 +0000 (15:22 +0000)]
Merge "Use UserIdentity::isRegistered instead of User::isAnon in BlockManager"
jenkins-bot [Tue, 27 Aug 2019 14:30:12 +0000 (14:30 +0000)]
Merge "Use ->getTitle() instead of ->mTitle to get the title from Parser"
Derick Alangi [Mon, 26 Aug 2019 13:03:35 +0000 (14:03 +0100)]
mail: Avoid use of global state and use MediaWiki services DI
Change-Id: If335cb6a220ebc5eb7487e51ee097f9d2afa0d2d
jenkins-bot [Tue, 27 Aug 2019 13:13:43 +0000 (13:13 +0000)]
Merge "wdio: Switch to dots reporter for brevity"
Ed Sanders [Tue, 27 Aug 2019 11:15:54 +0000 (12:15 +0100)]
Use correct metadata when adding exact query match
Bug: T230819
Change-Id: If85fa1cbad1f3ef9ab2cb0da966a98aafffad05e
Aryeh Gregor [Tue, 27 Aug 2019 10:32:47 +0000 (13:32 +0300)]
Document that img_description_id is a comment id
It took me a bit of time to figure this out, and it seems non-obvious,
so I thought a comment would be appropriate.
Change-Id: Ibe7220ed8f9355e3025c257057754eb4d72384b9
Fomafix [Tue, 27 Aug 2019 10:29:39 +0000 (12:29 +0200)]
Use ->getTitle() instead of ->mTitle to get the title from Parser
This allows to make mTitle a private property.
Change-Id: If953546cf4bb0324e4ae41d2195254c37c0ad3b4
Aryeh Gregor [Thu, 15 Aug 2019 18:07:36 +0000 (21:07 +0300)]
LockManagerGroupFactory to replace singletons
100% test coverage of code that appears to be working and used, in both
LockManagerGroupFactory and also LockManagerGroup. Where possible I
wrote it as unit tests. One preexisting code path seems to be broken and
I marked the test as skipped. Two methods look unused and perhaps not
especially helpful, so I didn't write tests for them yet in case we want
to just get rid of them instead.
Change-Id: Iaa7354f31c451b87773468609c674a3bf1d4382f
Translation updater bot [Tue, 27 Aug 2019 08:14:39 +0000 (10:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I52497a0a7f1d15ca6643556e3967d9302572a40f
Matěj Suchánek [Tue, 27 Aug 2019 07:56:38 +0000 (09:56 +0200)]
Restore some previous constructor calls
Follow-up to If07f10075a51fbbe9de24464cb6844faaad94780
and I082152b64141f1a9a4085bba23fe81a99ec8d886.
It will make getRequest use the provided context again.
Change-Id: I60b2598edcb0daed076876482e1e9d6cbf815eb2
Thalia [Mon, 26 Aug 2019 23:21:04 +0000 (00:21 +0100)]
Use UserIdentity::isRegistered instead of User::isAnon in BlockManager
BlockManager::getBlockFromCookieValue accepts a UserIdentity, so should
only call methods defined in that interface.
Change-Id: If30df15b800cceee0ad052a2e0524df8b28d9901
jenkins-bot [Tue, 27 Aug 2019 05:09:07 +0000 (05:09 +0000)]
Merge "TablePager: put parent construct call back at end"
Elliott Eggleston [Tue, 27 Aug 2019 03:42:07 +0000 (22:42 -0500)]
TablePager: put parent construct call back at end
Restores position of parent constructor call, changed in commit
I082152b64141f1a.
The parent constructor calls getIndexField(), which depends on the
mSort value already being set.
Bug: T231261
Change-Id: If07f10075a51fbbe9de24464cb6844faaad94780
jenkins-bot [Tue, 27 Aug 2019 03:03:42 +0000 (03:03 +0000)]
Merge "Add more information to exception thrown"
Max Semenik [Tue, 27 Aug 2019 02:03:09 +0000 (19:03 -0700)]
Add more information to exception thrown
It's not just about the preference name, because current user's properties
are used for validation too.
Bug: T231029
Change-Id: I268b959017bb0dce2b4295d5302a544bfa3513eb
jenkins-bot [Tue, 27 Aug 2019 01:19:16 +0000 (01:19 +0000)]
Merge "Add help link to Special:NewSection"
jenkins-bot [Tue, 27 Aug 2019 00:32:25 +0000 (00:32 +0000)]
Merge "Add SearchResultTrait"