From: petarpetkovic <ppetkovic@wikimedia.org>
Date: Tue, 7 Nov 2017 11:28:05 +0000 (+0100)
Subject: RCFilters:Make bookmark icon gray when unavailable
X-Git-Tag: 1.31.0-rc.0~1589
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22suivi_revisions%22%2C%22id_auteur=%24connecte%22%29%20.%20%22?a=commitdiff_plain;h=d6e0a1d300252c872b835dc68d0511352da53dec;p=lhc%2Fweb%2Fwiklou.git

RCFilters:Make bookmark icon gray when unavailable

- Make bookmark icon gray out when unavailable instead of disappearing.
- Include a tooltip in the grayed out state only to say:
"These filters are already saved."

Bug: T179743
Change-Id: I3e4d711f9b8f2b0a2c1195c9d7632de417e6d0d5
---

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index b93a5d3cb3..6c9929b399 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1382,6 +1382,7 @@
 	"rcfilters-savedqueries-apply-and-setdefault-label": "Create default filter",
 	"rcfilters-savedqueries-cancel-label": "Cancel",
 	"rcfilters-savedqueries-add-new-title": "Save current filter settings",
+	"rcfilters-savedqueries-already-saved": "These filters are already saved",
 	"rcfilters-restore-default-filters": "Restore default filters",
 	"rcfilters-clear-all-filters": "Clear all filters",
 	"rcfilters-show-new-changes": "View newest changes",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index d71509197e..08038edc7a 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1576,6 +1576,7 @@
 	"rcfilters-savedqueries-apply-and-setdefault-label": "Label for the button to apply saving a new filter setting and set it as default in [[Special:RecentChanges]]. This is for a small popup, please try to use a short string.",
 	"rcfilters-savedqueries-cancel-label": "Label for the button to cancel the saving of a new quick link in [[Special:RecentChanges]]\n{{Identical|Cancel}}",
 	"rcfilters-savedqueries-add-new-title": "Title for the popup to add new quick link in [[Special:RecentChanges]]. This is for a small popup, please try to use a short string.",
+	"rcfilters-savedqueries-already-saved": "Title for the popup in [[Special:RecentChanges]] that indicates that current set of filters is already saved. This is for a small popup, please try to use a short string.",
 	"rcfilters-restore-default-filters": "Label for the button that resets filters to defaults",
 	"rcfilters-clear-all-filters": "Title for the button that clears all filters",
 	"rcfilters-show-new-changes": "Label for the button to show new changes.",
diff --git a/resources/Resources.php b/resources/Resources.php
index 2594a3de8f..a16ab0e3a1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1854,6 +1854,7 @@ return [
 			'rcfilters-savedqueries-new-name-label',
 			'rcfilters-savedqueries-new-name-placeholder',
 			'rcfilters-savedqueries-add-new-title',
+			'rcfilters-savedqueries-already-saved',
 			'rcfilters-savedqueries-apply-label',
 			'rcfilters-savedqueries-apply-and-setdefault-label',
 			'rcfilters-savedqueries-cancel-label',
diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index 0d39cd0167..4e33be0252 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@ -417,7 +417,10 @@
 			this.matchingQuery ? this.matchingQuery.getLabel() : ''
 		);
 		this.savedQueryTitle.toggle( !!this.matchingQuery );
-		this.saveQueryButton.toggle( !this.matchingQuery );
+		this.saveQueryButton.setDisabled( !!this.matchingQuery );
+		this.saveQueryButton.setTitle( !this.matchingQuery ?
+			mw.msg( 'rcfilters-savedqueries-add-new-title' ) :
+			mw.msg( 'rcfilters-savedqueries-already-saved' ) );
 
 		if ( this.matchingQuery ) {
 			this.emphasize();