From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sat, 24 Feb 2018 00:25:01 +0000 (-0800)
Subject: Remove redundant item loading code in User::createNew
X-Git-Tag: 1.31.0-rc.0~513
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22suivi_revisions%22%2C%22id_auteur=%24connecte%22%29%20.%20%22?a=commitdiff_plain;h=0bf48b72331598fa464886f2bc9ca8259c610175;p=lhc%2Fweb%2Fwiklou.git

Remove redundant item loading code in User::createNew

These lines were removed in 27c61fb1 but left in when I rebased
61b0c193 due to the conflict. The load() call handles all these
fields, so there is no need to set mName and the load state flag.

Change-Id: Id751241abf8d5592309744e96493122c6bc65f2b
---

diff --git a/includes/user/User.php b/includes/user/User.php
index b5106ed631..babb571c94 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -4361,8 +4361,6 @@ class User implements IDBAccessObject, UserIdentity {
 				$newUser = self::newFromId( $dbw->insertId() );
 				// Load the user from master to avoid replica lag
 				$newUser->load( self::READ_LATEST );
-				$newUser->mName = $fields['user_name'];
-				$newUser->setItemLoaded( 'name' );
 				$newUser->updateActorId( $dbw );
 			} else {
 				$newUser = null;