search: refactor DatabaseSearch to take a load balancer instance
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 11 Apr 2019 04:45:53 +0000 (21:45 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 26 Jun 2019 03:03:37 +0000 (03:03 +0000)
commitd16fb6515ba95bdc14221c3ba55bdfa1763a79a0
tree0543631db7b697909e8fbee3fc999f9a8222593b
parentdd69e92a2c133574d72147cfcd0210f6add6025a
search: refactor DatabaseSearch to take a load balancer instance

Also make the update() methods of the subclasses use DB_MASTER as they
should. This avoids read-only errors.

In addition, avoid passing a dummy argument of null in some cases
within SearchEngineFactory::create(). Fix some dynamic calls to
static methods too.

Change-Id: Id94f34994b0f9c18e23ef30cb2fe895e6dedd09c
includes/search/SearchDatabase.php
includes/search/SearchEngineFactory.php
includes/search/SearchMssql.php
includes/search/SearchMySQL.php
includes/search/SearchOracle.php
includes/search/SearchPostgres.php
includes/search/SearchSqlite.php
tests/phpunit/includes/deferred/SearchUpdateTest.php
tests/phpunit/includes/search/SearchEngineTest.php