From 810933912f17d7f0c2355465c28e75aabd3c56b6 Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Fri, 31 Mar 2017 16:57:05 -0700
Subject: [PATCH] changes: Remove assertTag from RCCacheEntryFactoryTest

Use PHPUnit's Xml::load() to validate that all tags and attributes
are balanced.

Use simple assertEquals or assertRegexp for the specific parts.

Change-Id: I25796954a3bb9903e88256b8345ef751c767d7d5
---
 .../changes/RCCacheEntryFactoryTest.php       | 90 ++++++-------------
 1 file changed, 28 insertions(+), 62 deletions(-)

diff --git a/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php b/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
index 4ff1eb8e76..97b4c0887c 100644
--- a/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
+++ b/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
@@ -141,103 +141,69 @@ class RCCacheEntryFactoryTest extends MediaWikiLangTestCase {
 		$this->assertEquals( 'prev', $cacheEntry->lastlink, 'pref link for delete log or rev' );
 	}
 
+	private function assertValidHTML( $actual ) {
+		// Throws if invalid
+		$doc = PHPUnit_Util_XML::load( $actual, /* isHtml */ true );
+	}
+
 	private function assertUserLinks( $user, $cacheEntry ) {
-		$this->assertTag(
-			[
-				'tag' => 'a',
-				'attributes' => [
-					'class' => 'new mw-userlink'
-				],
-				'content' => $user
-			],
+		$this->assertValidHTML( $cacheEntry->userlink );
+		$this->assertRegExp(
+			'#^<a .*class="new mw-userlink".*><bdi>' . $user . '</bdi></a>#',
 			$cacheEntry->userlink,
 			'verify user link'
 		);
 
-		$this->assertTag(
-			[
-				'tag' => 'span',
-				'attributes' => [
-					'class' => 'mw-usertoollinks'
-				],
-				'child' => [
-					'tag' => 'a',
-					'content' => 'talk',
-				]
-			],
+		$this->assertValidHTML( $cacheEntry->usertalklink );
+		$this->assertRegExp(
+			'#^ <span class="mw-usertoollinks">\(.*<a .+>talk</a>.*\)</span>#',
 			$cacheEntry->usertalklink,
 			'verify user talk link'
 		);
 
-		$this->assertTag(
-			[
-				'tag' => 'span',
-				'attributes' => [
-					'class' => 'mw-usertoollinks'
-				],
-				'child' => [
-					'tag' => 'a',
-					'content' => 'contribs',
-				]
-			],
+		$this->assertValidHTML( $cacheEntry->usertalklink );
+		$this->assertRegExp(
+			'#^ <span class="mw-usertoollinks">\(.*<a .+>contribs</a>.*\)</span>$#',
 			$cacheEntry->usertalklink,
 			'verify user tool links'
 		);
 	}
 
 	private function assertDeleteLogLink( $cacheEntry ) {
-		$this->assertTag(
-			[
-				'tag' => 'a',
-				'attributes' => [
-					'href' => '/wiki/Special:Log/delete',
-					'title' => 'Special:Log/delete'
-				],
-				'content' => 'Deletion log'
-			],
+		$this->assertEquals(
+			'(<a href="/wiki/Special:Log/delete" title="Special:Log/delete">Deletion log</a>)',
 			$cacheEntry->link,
 			'verify deletion log link'
 		);
+
+		$this->assertValidHTML( $cacheEntry->link );
 	}
 
 	private function assertRevDel( $cacheEntry ) {
-		$this->assertTag(
-			[
-				'tag' => 'span',
-				'attributes' => [
-					'class' => 'history-deleted'
-				],
-				'content' => '(username removed)'
-			],
+		$this->assertEquals(
+			' <span class="history-deleted">(username removed)</span>',
 			$cacheEntry->userlink,
 			'verify user link for change with deleted revision and user'
 		);
+		$this->assertValidHTML( $cacheEntry->userlink );
 	}
 
 	private function assertTitleLink( $title, $cacheEntry ) {
-		$this->assertTag(
-			[
-				'tag' => 'a',
-				'attributes' => [
-					'href' => '/wiki/' . $title,
-					'title' => $title
-				],
-				'content' => $title
-			],
+		$this->assertEquals(
+			'<a href="/wiki/' . $title . '" title="' . $title . '">' . $title . '</a>',
 			$cacheEntry->link,
 			'verify title link'
 		);
+		$this->assertValidHTML( $cacheEntry->link );
 	}
 
 	private function assertQueryLink( $content, $params, $link ) {
-		$this->assertTag(
-			[
-				'tag' => 'a',
-				'content' => $content
-			],
+		$this->assertRegExp(
+			"#^<a .+>$content</a>$#",
 			$link,
-			'assert query link element'
+			'verify query link element'
 		);
+		$this->assertValidHTML( $link );
 
 		foreach ( $params as $key => $value ) {
 			$this->assertRegExp( '/' . $key . '=' . $value . '/', $link, "verify $key link params" );
-- 
2.20.1