From 7eef775b2723bc4c63323b1ac223f23d33af41dd Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Sun, 25 Aug 2019 18:55:34 +0100
Subject: [PATCH] language: Move ConverterRule to includes/ and add test case

Add a very basic test that creates an instance, invokes it
with an empty string, and asserts the types and values returned
by the public methods used in LanguageConverter::applyManualConv.

Bug: T225756
Change-Id: I3600260e712f019243ba5f00890011e694444e43
---
 autoload.php                                  |  2 +-
 .../language}/ConverterRule.php               |  0
 .../includes/language/ConverterRuleTest.php   | 23 +++++++++++++++++++
 3 files changed, 24 insertions(+), 1 deletion(-)
 rename {languages => includes/language}/ConverterRule.php (100%)
 create mode 100644 tests/phpunit/includes/language/ConverterRuleTest.php

diff --git a/autoload.php b/autoload.php
index 9b122cbbff..be85cf96bc 100644
--- a/autoload.php
+++ b/autoload.php
@@ -316,7 +316,7 @@ $wgAutoloadLocalClasses = [
 	'ConvertExtensionToRegistration' => __DIR__ . '/maintenance/convertExtensionToRegistration.php',
 	'ConvertLinks' => __DIR__ . '/maintenance/convertLinks.php',
 	'ConvertUserOptions' => __DIR__ . '/maintenance/convertUserOptions.php',
-	'ConverterRule' => __DIR__ . '/languages/ConverterRule.php',
+	'ConverterRule' => __DIR__ . '/includes/language/ConverterRule.php',
 	'Cookie' => __DIR__ . '/includes/libs/Cookie.php',
 	'CookieJar' => __DIR__ . '/includes/libs/CookieJar.php',
 	'CopyFileBackend' => __DIR__ . '/maintenance/copyFileBackend.php',
diff --git a/languages/ConverterRule.php b/includes/language/ConverterRule.php
similarity index 100%
rename from languages/ConverterRule.php
rename to includes/language/ConverterRule.php
diff --git a/tests/phpunit/includes/language/ConverterRuleTest.php b/tests/phpunit/includes/language/ConverterRuleTest.php
new file mode 100644
index 0000000000..1e06142887
--- /dev/null
+++ b/tests/phpunit/includes/language/ConverterRuleTest.php
@@ -0,0 +1,23 @@
+<?php
+
+/**
+ * @covers ConverterRule
+ */
+class ConverterRuleTest extends MediaWikiTestCase {
+
+	public function setUp() {
+		parent::setUp();
+		$this->setMwGlobals( 'wgUser', new User );
+	}
+
+	public function testParseEmpty() {
+		$converter = new LanguageConverter( new Language(), 'en' );
+		$rule = new ConverterRule( '', $converter );
+		$rule->parse();
+
+		$this->assertSame( false, $rule->getTitle(), 'title' );
+		$this->assertSame( [], $rule->getConvTable(), 'conversion table' );
+		$this->assertSame( 'none', $rule->getRulesAction(), 'rules action' );
+	}
+
+}
-- 
2.20.1