From 53b92dbca18dbb570cde8cea31c42e418e57140f Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Tue, 31 May 2016 15:18:14 +0530 Subject: [PATCH] Avoid passing integers to mw.RegExp.escape Passing the index value of the loop to mw.RegExp.escape causes javascript error at str.replace. mw.RegExp.escape expects string parameters. It is not required to escape the loop index here. Follow-up to c81ab8ae5f89056d23a4b0d36066120b9701d07e. Bug: T135743 Change-Id: I818bc2c671193e79848ae183f509473200c6abf5 --- resources/src/moment-locale-overrides.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/src/moment-locale-overrides.js b/resources/src/moment-locale-overrides.js index 9af0598ec1..dd33b007f6 100644 --- a/resources/src/moment-locale-overrides.js +++ b/resources/src/moment-locale-overrides.js @@ -27,7 +27,7 @@ moment.locale( moment.locale(), { if ( mw.config.get( 'wgTranslateNumerals' ) ) { for ( i = 0; i < 10; i++ ) { if ( table[ i ] !== undefined ) { - s = s.replace( new RegExp( mw.RegExp.escape( i ), 'g' ), table[ i ] ); + s = s.replace( new RegExp( i, 'g' ), table[ i ] ); } } } -- 2.20.1