From 4461aa6e4fb13d4ad6c9e68e932319c47462fab1 Mon Sep 17 00:00:00 2001 From: daniel Date: Mon, 10 Sep 2018 21:02:26 +0200 Subject: [PATCH] Don't show unsaved revision in DifferenceEngine::renderNewRevision. There was a conditional that was documented to make the method bail out if the current revision was unsaved, but it was missing the actual return statement. Note that preview code in EditPage does not use DifferenceEngine::renderNewRevision. Change-Id: I86a25e9464435ac17c72f78f7ce1f354adf3d055 --- includes/diff/DifferenceEngine.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 387e9e3c18..9602bd20d5 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -848,6 +848,7 @@ class DifferenceEngine extends ContextSource { // New revision is unsaved; bail out. // TODO in theory rendering the new revision is a meaningful thing to do // even if it's unsaved, but a lot of untangling is required to do it safely. + return; } $out->setRevisionId( $this->mNewid ); -- 2.20.1