From 1a9246e1b82f945f9b3a4c7b21f47b1128be399f Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Tue, 10 Jul 2012 13:14:07 +0200 Subject: [PATCH] ChannelFeed now marked as an abstract class The ChannelFeed class has always been considered as an abstract class. Looks like we forgot to update its definition since PHP switched to support class abstractions. Also marked abstract the three inner methods that must be extended: ChannelFeed::outHeader() ChannelFeed::outItem() ChannelFeed::outFooter() Change-Id: Ie0111786af37531d53ee3fc845e0125136ca298f --- includes/Feed.php | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/includes/Feed.php b/includes/Feed.php index 8e8f5dedde..f9dbf5ba71 100644 --- a/includes/Feed.php +++ b/includes/Feed.php @@ -183,29 +183,35 @@ class FeedItem { * @todo document (needs one-sentence top-level class description). * @ingroup Feed */ -class ChannelFeed extends FeedItem { +abstract class ChannelFeed extends FeedItem { /** * Generate Header of the feed + * @par Example: + * @code + * print ""; + * @endcode + * @param $item */ - function outHeader() { - # print ""; - } + abstract public function outHeader(); /** * Generate an item + * @par Example: + * @code + * print "..."; + * @endcode * @param $item */ - function outItem( $item ) { - # print "..."; - } + abstract public function outItem( $item ); /** * Generate Footer of the feed + * @par Example: + * @code + * print ""; + * @endcode */ - function outFooter() { - # print ""; - } - /**#@-*/ + abstract public function outFooter(); /** * Setup and send HTTP headers. Don't send any content; -- 2.20.1