Mark A. Hershberger [Sat, 12 Feb 2011 04:06:22 +0000 (04:06 +0000)]
w/s fixups
Mark A. Hershberger [Sat, 12 Feb 2011 04:01:06 +0000 (04:01 +0000)]
Fix up bug #26016 by applying the more descriptive comment suggested
there. Code Reviewers: have at it!!
Brion Vibber [Sat, 12 Feb 2011 01:10:48 +0000 (01:10 +0000)]
* (bug 27333) Fix repetitive last-seen time queries on page history
Title::getNotificationTimestamp() is called for every line in HistoryPager, to compare against the revision's timestamp to determine if it's a new edit since the viewer's last visit to the page.
The function kept an internal cache within the Title object to avoid having to make the query over and over in this situation, but in the case that it returns null, the cached entry would be accidentally ignored on the next round due to use of isset() to check for the array entry. (Most of the time it's great, but if the value of the key actually *is* null, isset() returns false.) Switched to array_key_exists(), which doesn't have this false negative. Now only one query gets issued for this on a history page, even if the answer is null.
Trevor Parscal [Fri, 11 Feb 2011 22:57:32 +0000 (22:57 +0000)]
Resolves bug #27328 by supporting URL rewriting for CSS that comes from the Wiki, such as user and site scripts.
Krinkle [Fri, 11 Feb 2011 22:30:14 +0000 (22:30 +0000)]
Fixing issue with multiple premade toggles in a non-custom collapsible element.
The problem is that when one of the toggles is clicked the classname is only changed on the toggle that was clicked. The others will stil have the wrong class. On of the areas in which this may lead to weird behaviour is the :hover styles for the up- and downarrow cursors.
Previously would bind to all of them :
<pre>
= .find( '> .mw-collapsible-toggle' );
// ^ may match multiple ones
</pre>
... which is good. But in the click handler:
<pre>
[..].bind( 'click.mw-collapse', function( e ){
toggleLinkPremade( this, e );
} );
</pre>
... only called the function with 'this'. This has been changed to pass all of instead.
This problem was discovered in the following scenario. Where an .mw-collapsible has three children. The first two are clickable and are the togglers for the third child.
http://translatewiki.net/w/i.php?title=Sandbox&oldid=
2692006
Sam Reed [Fri, 11 Feb 2011 22:06:46 +0000 (22:06 +0000)]
Fixup a couple of parameter documentation bits
Raimond Spekking [Fri, 11 Feb 2011 20:37:31 +0000 (20:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-11 20:17:00 UTC)
Niklas Laxström [Fri, 11 Feb 2011 19:30:35 +0000 (19:30 +0000)]
Comment cleanup, unused vars
Niklas Laxström [Fri, 11 Feb 2011 19:28:04 +0000 (19:28 +0000)]
Add a content type and encoding header to profileinfo.php, encoding was borked
Bryan Tong Minh [Fri, 11 Feb 2011 19:13:27 +0000 (19:13 +0000)]
Follow-up r81984: Fix function name.
Apologies for the double commit, but my diff is broken locally.
Bryan Tong Minh [Fri, 11 Feb 2011 19:10:31 +0000 (19:10 +0000)]
* Remove code duplication for UploadStash: Move all thumbName generation code to its own function File::generateThumbName which accepts a $name parameter which can be called by File::thumbName() and any other functions that require it. The essentially duplicate function StashFile::getParamThumbName() has been removed.
* Add a small url encoding fix
Niklas Laxström [Fri, 11 Feb 2011 19:03:05 +0000 (19:03 +0000)]
Use self:: when it's possible
Ryan Lane [Fri, 11 Feb 2011 17:38:56 +0000 (17:38 +0000)]
Partial fix for bug 27310. Add domain information when doing password resets. Also, the login form being used for non-logged in users was failing because of a missing login token, so this adds a login token before the form is executed.
Bryan Tong Minh [Fri, 11 Feb 2011 15:42:28 +0000 (15:42 +0000)]
Follow-up r81971: Fix error handling
Bryan Tong Minh [Fri, 11 Feb 2011 15:40:39 +0000 (15:40 +0000)]
* (bug 27199) Thumbnail urls can be fetched for old files as well
Bryan Tong Minh [Fri, 11 Feb 2011 15:31:52 +0000 (15:31 +0000)]
Follow-up r81558: Only raise a warning if no image handler could be found
Tim Starling [Fri, 11 Feb 2011 11:53:00 +0000 (11:53 +0000)]
Since 1.17 a whole lot of extensions have sprouted *.i18n.magic.php files. Most of these files have entries which erroneously omit the English synonym for a magic word. This breaks the extension completely when an affected language is selected.
This patch automatically includes synonyms from the fallback localisation, and prevents the case flag from being overridden, thus making extensions resistant to translator error.
Chad Horohoe [Fri, 11 Feb 2011 10:27:07 +0000 (10:27 +0000)]
Merge callback fixes from 1.17wmf1. /e is evil.
Roan Kattouw [Fri, 11 Feb 2011 09:38:38 +0000 (09:38 +0000)]
Wrap old toolbar addButton() calls in a document ready, so they're not run early and explode in debug mode
Roan Kattouw [Fri, 11 Feb 2011 09:27:02 +0000 (09:27 +0000)]
Apply $wgContLang-based flip logic to site and user modules too. I swear we did this at some point
Roan Kattouw [Fri, 11 Feb 2011 08:29:55 +0000 (08:29 +0000)]
Fixes for r81936 per Tim's review
Roan Kattouw [Fri, 11 Feb 2011 08:07:47 +0000 (08:07 +0000)]
Fix getMsgBlobMtime() to also cause a cache invalidation if a module has messages but no stored message blob
Daniel Friesen [Fri, 11 Feb 2011 06:42:40 +0000 (06:42 +0000)]
Fix a small bug in SkinLegacy.
Daniel Friesen [Fri, 11 Feb 2011 02:46:08 +0000 (02:46 +0000)]
Add a new maintenance script to reset the user_token of all users if you think someone got ahold of your user table.
Platonides [Thu, 10 Feb 2011 23:57:30 +0000 (23:57 +0000)]
$wgDBts2schema was removed in r81132
Raimond Spekking [Thu, 10 Feb 2011 21:27:12 +0000 (21:27 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-10 21:02:00 UTC)
Platonides [Thu, 10 Feb 2011 20:46:50 +0000 (20:46 +0000)]
MonoBook is now tooltip() and tooltipAndAccesskeyAttribs() free!
Platonides [Thu, 10 Feb 2011 20:36:18 +0000 (20:36 +0000)]
Follow up r81914. Don't build the <li> manually.
Platonides [Thu, 10 Feb 2011 19:46:36 +0000 (19:46 +0000)]
Kill calls to tooltip() and tooltipAndAccesskeyAttribs() from MonoBook and Modern
Platonides [Thu, 10 Feb 2011 19:12:33 +0000 (19:12 +0000)]
Remove unused initial_setup(), last $wgDBts2schema user. Follow up to r81132
Bryan Tong Minh [Thu, 10 Feb 2011 18:24:19 +0000 (18:24 +0000)]
Follow-up r70137: Unconditionalize the asyncdownload params and throw asynccopyuploadsdisabled if async is requested without $wgAllowAsyncCopyUploads.
Platonides [Thu, 10 Feb 2011 18:15:58 +0000 (18:15 +0000)]
Move LanguageGetMagic hook to its own function
Platonides [Thu, 10 Feb 2011 17:13:12 +0000 (17:13 +0000)]
Convert the if into an early exit. Whitespace ignoring diff recommended.
Alexandre Emsenhuber [Thu, 10 Feb 2011 17:08:37 +0000 (17:08 +0000)]
Added "context title" to replace $wgTitle, current behavior unchanges, but added a comment that this might change in the future to completely remove $wgTitle usage in EditPage
Also removed null check on showEditForm() since $wgTitle is set on ApiEditPage.php, so it won't catch anything
Platonides [Thu, 10 Feb 2011 16:54:51 +0000 (16:54 +0000)]
Move the overhead computation to another function.
Platonides [Thu, 10 Feb 2011 16:47:19 +0000 (16:47 +0000)]
Fix the wrong merge of r81894 after r81893
Alexandre Emsenhuber [Thu, 10 Feb 2011 16:45:27 +0000 (16:45 +0000)]
Removed call to OutputPage::disable()
Platonides [Thu, 10 Feb 2011 16:44:57 +0000 (16:44 +0000)]
Add profiling to the whole ResourceLoader::makeModuleResponse
Platonides [Thu, 10 Feb 2011 16:40:59 +0000 (16:40 +0000)]
Add profiling to DjVuImage::retrieveMetaData
Platonides [Thu, 10 Feb 2011 16:39:53 +0000 (16:39 +0000)]
Yet more additions of wfProfileOut()
Bryan Tong Minh [Thu, 10 Feb 2011 16:14:56 +0000 (16:14 +0000)]
Add a context to SpecialPage, so that subclasses don't need globals anymore. Introduces $mRequest, $mOutput and $mFullTitle, which can be used instead of $wgRequest, $wgOut and $wgTitle. Introduces msg(), which is a wrapper around wfMessage()->title().
Platonides [Thu, 10 Feb 2011 16:11:34 +0000 (16:11 +0000)]
Adding more wfProfileOut()
Niklas Laxström [Thu, 10 Feb 2011 16:08:44 +0000 (16:08 +0000)]
Fix profiling
Platonides [Thu, 10 Feb 2011 16:04:19 +0000 (16:04 +0000)]
More wfProfileOut()ing
Platonides [Thu, 10 Feb 2011 15:53:54 +0000 (15:53 +0000)]
Close wfProfileIn()s
Platonides [Thu, 10 Feb 2011 15:47:43 +0000 (15:47 +0000)]
Add missing wfProfileOut
Niklas Laxström [Thu, 10 Feb 2011 15:29:54 +0000 (15:29 +0000)]
Refactor userLinks into it's own method
Bryan Tong Minh [Thu, 10 Feb 2011 15:20:47 +0000 (15:20 +0000)]
(bug 25832) query=allimages now outputs ns/title as well
Sam Reed [Thu, 10 Feb 2011 14:00:51 +0000 (14:00 +0000)]
* (bug 15905) Nostalgia skin could become more usable by including a Talk:link at the top of the page
Shows next to Edit this page "Discuss this page"
Sam Reed [Thu, 10 Feb 2011 12:48:43 +0000 (12:48 +0000)]
RELEASE-NOTES for r81868
Platonides [Thu, 10 Feb 2011 10:48:02 +0000 (10:48 +0000)]
Fix for r80992. Remove posix extension requisite. Made to work in non-Unix systems.
Replaced fseek+fwrite with ftruncate()
Niklas Laxström [Thu, 10 Feb 2011 10:10:44 +0000 (10:10 +0000)]
Tests for r81878
Platonides [Thu, 10 Feb 2011 10:03:38 +0000 (10:03 +0000)]
Fix the completely broken r81880
Platonides [Thu, 10 Feb 2011 09:51:31 +0000 (09:51 +0000)]
Add support of assertEmpty (used since r81596) for phpunit < 3.5.0
Niklas Laxström [Thu, 10 Feb 2011 09:10:47 +0000 (09:10 +0000)]
Fixed two bugs in message parameter handling:
* missing check for is_array caused $foo["raw"] to return true when $foo is string: bug 27298
* Some parameters could be replaced twice or more: r80764
Sam Reed [Thu, 10 Feb 2011 02:32:34 +0000 (02:32 +0000)]
*(bug 27159) make email confirmation code expiration time configurable
Added "$wgUserEmailConfirmationTokenExpiry"
Sam Reed [Wed, 9 Feb 2011 22:42:26 +0000 (22:42 +0000)]
Explicitally define $fld_rights on all code paths
Raimond Spekking [Wed, 9 Feb 2011 21:04:24 +0000 (21:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-09 20:45:00 UTC)
Sam Reed [Wed, 9 Feb 2011 20:09:22 +0000 (20:09 +0000)]
Rebuild raw sql
Remove old method_exists
Add braces
Sam Reed [Wed, 9 Feb 2011 19:54:23 +0000 (19:54 +0000)]
Explicitally define $i = 0;
Sam Reed [Wed, 9 Feb 2011 18:57:25 +0000 (18:57 +0000)]
Fixup fixme on r81030, which should actually have been a fixme on r81657
Platonides [Wed, 9 Feb 2011 17:36:25 +0000 (17:36 +0000)]
Follow up to r81829. Poison var_dump, so that debug statements like r81671 can be easily detected.
The three 'right' usages are
* includes/Import.php
* includes/api/ApiFormatDump.php
* tests/parser/parserTestsParserHook.php
Platonides [Wed, 9 Feb 2011 17:21:39 +0000 (17:21 +0000)]
Don't use ob_start/ob_get_contents/ob_end_clean just to var_dump() a string. Cleaning var_dump() usage.
Raimond Spekking [Wed, 9 Feb 2011 17:06:41 +0000 (17:06 +0000)]
Follow-up r81604: Prefix new classes with 'mw-' per [[Manual:Coding conventions]]
Alexandre Emsenhuber [Wed, 9 Feb 2011 17:05:52 +0000 (17:05 +0000)]
Fix for r81675: Skin::getTitle() will return null when $wgTitle is null and $wgOut->setTitle() not called, resulting in the following when passing a non-null parameter to User::getSkin():
Catchable fatal error: Argument 1 passed to Title::equals() must be an instance of Title, null given, called in includes/User.php on line 2255 and defined in includes/Title.php on line 3689
Platonides [Wed, 9 Feb 2011 17:05:25 +0000 (17:05 +0000)]
1 to true in boolean parameter
Alexandre Emsenhuber [Wed, 9 Feb 2011 15:19:45 +0000 (15:19 +0000)]
* Add a amtitle param to meta=allmessages
Only used used when amenableparser is passed; the user can now define the page used for {{PAGENAME}} and related stuff instead of being hardcoded to "API"
Chad Horohoe [Wed, 9 Feb 2011 14:59:44 +0000 (14:59 +0000)]
Followup r81812: per CR, this could be 0
Chad Horohoe [Wed, 9 Feb 2011 13:42:02 +0000 (13:42 +0000)]
preg_match() yells about undefined offsets when $wgInvalidUsernameCharacters is empty. Noticed by wolog on IRC
Chad Horohoe [Wed, 9 Feb 2011 06:00:52 +0000 (06:00 +0000)]
rm unused class variable
Brion Vibber [Tue, 8 Feb 2011 23:45:16 +0000 (23:45 +0000)]
* bug 27263: importDump.php now finally has --help text, also shown when stdin is a tty and no file given
Sam Reed [Tue, 8 Feb 2011 23:18:13 +0000 (23:18 +0000)]
More return type documentation
Sam Reed [Tue, 8 Feb 2011 23:09:22 +0000 (23:09 +0000)]
Minor documentation tweaks/improvements
Platonides [Tue, 8 Feb 2011 22:40:07 +0000 (22:40 +0000)]
Remove unused $wgContLang globals after refactoring at r81456 and r81456
Platonides [Tue, 8 Feb 2011 22:33:57 +0000 (22:33 +0000)]
Follow up r81562
Platonides [Tue, 8 Feb 2011 22:10:34 +0000 (22:10 +0000)]
Unused globals
Platonides [Tue, 8 Feb 2011 22:08:58 +0000 (22:08 +0000)]
Use of undefined constant h in line 250. Follow up to r81558
Platonides [Tue, 8 Feb 2011 22:03:01 +0000 (22:03 +0000)]
$IP marked as global again in line 1208, function includeExtensions
Unused global $wgHooks in function includeExtensions line 1208
Sam Reed [Tue, 8 Feb 2011 22:01:34 +0000 (22:01 +0000)]
Add missing wfProfileOut( __METHOD__ );
Raimond Spekking [Tue, 8 Feb 2011 21:22:11 +0000 (21:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-08 20:05:00 UTC)
Platonides [Tue, 8 Feb 2011 17:58:53 +0000 (17:58 +0000)]
Hack to shortcut it to zero until User::getStubThreshold() produces a call to optionUsed()
Platonides [Tue, 8 Feb 2011 16:32:30 +0000 (16:32 +0000)]
Revert r81738. Extensions calling clearState() with no mOptions fixed.
OverlordQ [Tue, 8 Feb 2011 15:34:28 +0000 (15:34 +0000)]
Followup to r81657, you do need a space between the table name and the alias
Alexandre Emsenhuber [Tue, 8 Feb 2011 15:19:49 +0000 (15:19 +0000)]
We have OutputPage::showPermissionsErrorPage() for that
Brion Vibber [Tue, 8 Feb 2011 13:31:30 +0000 (13:31 +0000)]
Tweak for r79018: fatal errors due to something calling parser clearState when mOptions wasn't defined
Roan Kattouw [Tue, 8 Feb 2011 12:34:08 +0000 (12:34 +0000)]
Remove $wgServer prepending from remote JS/CSS paths. It's not needed and breaks other-domain $wgStylePath / $wgExtensionAssetsPath settings
Tim Starling [Tue, 8 Feb 2011 12:25:39 +0000 (12:25 +0000)]
Make SVGMetadataExtractor less noisy when it reads SVGs from Adobe Illustrator.
Roan Kattouw [Tue, 8 Feb 2011 12:19:59 +0000 (12:19 +0000)]
Merge r81725 from 1.17wmf1: add parent constructor call so $IP is set properly
Roan Kattouw [Tue, 8 Feb 2011 12:14:35 +0000 (12:14 +0000)]
Fix double commas from r81721. This time I actually ran it through php -l before committing *shame*
Roan Kattouw [Tue, 8 Feb 2011 12:13:31 +0000 (12:13 +0000)]
Fix r81719: trailing commas
Tim Starling [Tue, 8 Feb 2011 12:08:21 +0000 (12:08 +0000)]
Merge r81718 from 1.17wmf1
Roan Kattouw [Tue, 8 Feb 2011 12:06:32 +0000 (12:06 +0000)]
Quick fix to make debug mode work with non-standard $wgStylePath. This strips the leading skins/ from each file path and sets $wgStylePath as the remote base path. $IP/skins is needed as a local base path to make stuff work, but I guess that could be changed $wgSkinDirectory
Brion Vibber [Tue, 8 Feb 2011 11:12:26 +0000 (11:12 +0000)]
Don't throw JS error when AJAX license selection is on but there's no license selector because this is a re-upload.
Bryan Tong Minh [Tue, 8 Feb 2011 10:43:09 +0000 (10:43 +0000)]
Add : to file-deleted-duplicate to force inline link display, as the file can exist on the shared repo.
Roan Kattouw [Tue, 8 Feb 2011 10:26:30 +0000 (10:26 +0000)]
Reimplement r80900, was lost when code was moved around
Tim Starling [Tue, 8 Feb 2011 06:34:38 +0000 (06:34 +0000)]
Fixes for ResourceLoaderWikiModule r72776. No serious bugs found, do not merge before deployment.
* Specify page titles as strings instead of split NS/DBK, as suggested by Roan on CR. It seemed sensible to me.
* Pass a Title object to getContent() instead of a string, to avoid unnecessary object construction overhead
* "*" and "/" are valid title characters. Check module input for JS comment end tokens.
* Fixed inappropriate conversion to boolean, when checking result of getContent(). Presumably the idea was to omit empty sections and errors, so that's what I did. Maybe an informative error message would be better in the error case.
* Use LinkBatch for selecting multiple page rows instead of Database::makeWhereFrom2d().
* Fixed assignment expression.
Tim Starling [Tue, 8 Feb 2011 05:33:17 +0000 (05:33 +0000)]
Fix bug from r73645: setMsgBlobMtime() requires its timestamp parameter to be a UNIX timestamp, which $row->mr_timestamp isn't. This was causing incorrect versions in the client-side module list, resulting in requests for URLs with "version=NaNNaNNaNTNaNNaNNaNZ", which Michael has been occasionally complaining about.
Brion Vibber [Tue, 8 Feb 2011 02:02:16 +0000 (02:02 +0000)]
* (bug 27230) Alignment fix for Vector watch tab icon spinner in IE 7
The CSS for the loading tab had:
background-position: center 60%;
The 'center' apparently worked for other browsers, but in IE7 it was getting a bit off, and threw the image over a few pixels.
'center' keyword here is allegedly equivalent to 50% which I also tried, but with the same results.
Instead, using the same fixed position that we specify for the regular rest-state icon works:
background-position: 5px 60%;
Resulting looks ok for me in:
* IE 6 / XP
* IE 7 / XP (fixes regression)
* IE 8 / XP
* Firefox 4b10 / Linux
Shouldn't hurt anything else.
Daniel Friesen [Tue, 8 Feb 2011 01:31:21 +0000 (01:31 +0000)]
Followup r81583, break some of the long lines and centralize the regex.
Daniel Friesen [Tue, 8 Feb 2011 01:15:50 +0000 (01:15 +0000)]
Fix bug slightly caused by moving legacy code out of the Skin class. The Article class was calling the legacy Skin::historyLink in a very ugly way (ie: having it's own mTitle, but relying on whatever title just happened to be set on the skin that it grabbed).