jenkins-bot [Sat, 18 May 2019 09:01:37 +0000 (09:01 +0000)]
Merge "jqueryMsg: Allow sneaking in non-qqx JavaScript messages in qqx mode"
jenkins-bot [Sat, 18 May 2019 08:02:09 +0000 (08:02 +0000)]
Merge "IP: Remove unused deprecated ::isValidBlock() method"
jenkins-bot [Sat, 18 May 2019 07:44:59 +0000 (07:44 +0000)]
Merge "Define date formats for Northern Sami"
Lucas Werkmeister [Fri, 17 May 2019 12:09:31 +0000 (14:09 +0200)]
Define date formats for Northern Sami
Following instructions from User:Yupik (at Wikimedia Hackathon 2019),
consulting [1], pages 10, 42, 43.
[1]: http://sh.pedit.no/web/NettskoleRessurs.axd?id=
feb75bf8-6f42-402b-b622-
29ce644c88d4
Bug: T223588
Change-Id: Ia63ea6ef09e95534ea0213bf28b26dbff3f3a7c4
jenkins-bot [Fri, 17 May 2019 21:13:44 +0000 (21:13 +0000)]
Merge "SearchResultSet: MW version number should be a string in wfDeprecated call"
Derick Alangi [Wed, 15 May 2019 14:15:03 +0000 (15:15 +0100)]
IP: Remove unused deprecated ::isValidBlock() method
This method was deprecated in 1.30 and no longer used in our code
bases.
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbisValidBlock%5Cb&i=nope&files=&repos=
Change-Id: I26e11c0d88fe7c82c052c1cf8e0bbc33bd99de70
jenkins-bot [Fri, 17 May 2019 15:13:19 +0000 (15:13 +0000)]
Merge "Revert "Always validate uploads over api""
jenkins-bot [Fri, 17 May 2019 15:13:09 +0000 (15:13 +0000)]
Merge "Remove LegacyHookPreAuthenticationProvider class"
jenkins-bot [Fri, 17 May 2019 14:52:23 +0000 (14:52 +0000)]
Merge "build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0 and make pass"
Hashar [Fri, 17 May 2019 14:42:21 +0000 (14:42 +0000)]
Revert "Always validate uploads over api"
The verification is broken with chunken uploads and ultimately
cause large files to no more be uploadable.
This reverts commit
38ec6d8a344d4eda0307dd3a72653dd2171305d6.
Bug: T223448
Change-Id: If414a8f751a3e1488a2ab099abd8b598c973c1f4
Gergő Tisza [Wed, 10 Oct 2018 01:45:58 +0000 (18:45 -0700)]
Remove LegacyHookPreAuthenticationProvider class
Deprecated from birth, hard-deprecated since 1.33.
Change-Id: I03e94c02370ff0057e18274e9b409e162a0d7af0
jenkins-bot [Fri, 17 May 2019 14:01:28 +0000 (14:01 +0000)]
Merge "Fix typo: namesapce"
Niklas Laxström [Fri, 17 May 2019 13:25:21 +0000 (15:25 +0200)]
Fix typo: namesapce
Change-Id: Idb4e420c87b7043baf3289556b8ef8775126bf8e
jenkins-bot [Fri, 17 May 2019 12:17:04 +0000 (12:17 +0000)]
Merge "Use HTTPS instead of protocol relative for WMF links"
jenkins-bot [Fri, 17 May 2019 10:01:41 +0000 (10:01 +0000)]
Merge "objectcache: restore a simple version of the apc.serializer check in APCUBagOStuff"
Fomafix [Fri, 17 May 2019 05:16:16 +0000 (07:16 +0200)]
Use HTTPS instead of protocol relative for WMF links
The WMF websites redirect from HTTP to HTTPS.
Change-Id: I916c97697b4ffa9774eec9c8e6ab650a08bb6edd
jenkins-bot [Thu, 16 May 2019 22:51:15 +0000 (22:51 +0000)]
Merge "Unstub $wgLang for PageContentLanguage hook"
Aaron Schulz [Sat, 11 May 2019 12:39:22 +0000 (05:39 -0700)]
objectcache: restore a simple version of the apc.serializer check in APCUBagOStuff
Follow-up to
3192278eb21d
This seems to be about 30% faster on my local non-vm setup
when apc.serializer is set to "default".
Bug: T220470
Change-Id: If966187bd96a210915a72dc027544378c966a43c
Niklas Laxström [Thu, 7 Mar 2019 11:34:26 +0000 (12:34 +0100)]
Unstub $wgLang for PageContentLanguage hook
This is to avoid annoying fatal errors when someone annotated their
hook handler to only expect Language objects, but that expectation
is violated due to this code possibly passing StubUserLang to hooks,
some of which may also assign it to $pageLang.
Even with this in place, it is probably a good idea for hook handlers
to refrain from type hinting parameters that are passed by reference
because their types cannot be guaranteed.
Bug: T214358
Change-Id: I88405a8de4b13675eb5a9d11e9ddc87e20a85fb4
jenkins-bot [Thu, 16 May 2019 16:26:04 +0000 (16:26 +0000)]
Merge "for two-stage dumps make the location of MWScript.php alterable"
Alex Monk [Thu, 16 May 2019 12:25:19 +0000 (13:25 +0100)]
Follow-up I2fef157c: Add missing getNamespaceInfo call to ContribsPager chain
Bug: T223440
Change-Id: I26e05a4312ba7f667b1b95cfbfdc24fae793c3b0
Lucas Werkmeister [Thu, 16 May 2019 09:46:23 +0000 (11:46 +0200)]
Add notice that FOR UPDATE is incompatible with aggregates
On some database types, combining locking reads with aggregate functions
is not allowed, and MediaWiki detects such cases and logs a deprecation
warning (on all database types), so we don’t really want people to use
this even if the target database type happens to support it. Add a
warning to the documentation.
Change-Id: Ib6fd2148aeb0c94c0a13b33aec08e3308c740b01
Ariel T. Glenn [Thu, 20 Sep 2018 14:55:58 +0000 (17:55 +0300)]
for two-stage dumps make the location of MWScript.php alterable
Previously it was fixed to be in a certain location relative to
the MW instllation; this would allow the path to the script to
be passed in as an argument. If not, the script reverts to its
previous behavior.
Bug: T204962
Change-Id: Ib9fcf073332670149544d56e375541d014600371
Translation updater bot [Thu, 16 May 2019 06:23:33 +0000 (08:23 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib8bf857616112887a5c758c00375fd1f14b2a164
jenkins-bot [Wed, 15 May 2019 21:09:28 +0000 (21:09 +0000)]
Merge "ApiLogin: Remove the first example of outdated flow"
Derk-Jan Hartman [Wed, 15 May 2019 20:30:48 +0000 (22:30 +0200)]
ApiLogin: Remove the first example of outdated flow
This first example demonstrates a deprecated flow that we should not
be encouraging and definetly shouldn't be before the example that we
want to promote
Change-Id: Ia1ec99a0fd88cee216fcb80aaebd0a00ce2942a4
jenkins-bot [Wed, 15 May 2019 18:02:59 +0000 (18:02 +0000)]
Merge "Don't allow completing a partial stash upload"
jenkins-bot [Wed, 15 May 2019 18:02:50 +0000 (18:02 +0000)]
Merge "Bind retry callback with correct this argument"
Derick Alangi [Wed, 15 May 2019 14:17:23 +0000 (15:17 +0100)]
SearchResultSet: MW version number should be a string in wfDeprecated call
Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).
To avoid this, use '1.32' instead of the integer form of the version.
Change-Id: Ifaf6ab0d36bc02bd1707f8caf375f65a30eb1af5
jenkins-bot [Wed, 15 May 2019 11:20:03 +0000 (11:20 +0000)]
Merge "title: Convert binary regexp to use Unicode code points"
Marko Obrovac [Mon, 22 Apr 2019 20:28:54 +0000 (13:28 -0700)]
Allow the request ID to be passed in via the `X-Request-Id` header
For tracing and logging purposes, we want to be able to see/generate the
list of all of the requests that happen in the environment for a given
external incoming request. To that end, allow Mediawiki to accept the
request ID provided by the incoming request as its own.
Since this may be problematic for set-ups that don't have an entity in
front of MW that sanitises the headers on the way in, introduce a new
global variable, `$wgAllowExternalReqID`, that can disable this
behaviour. By default, the feature is disabled.
Bug: T201409
Change-Id: I605471fb8b5bbc290baeecc7d80d9d715cb240c9
Matthias Mullie [Wed, 15 May 2019 07:13:15 +0000 (09:13 +0200)]
Don't allow completing a partial stash upload
finishUploadToStash could be called on an incomplete upload.
E.g. upload 1 chunk (that gets you the filekey) and then call
finishUploadToStash's finishUpload.
This adds another check for the stash result. The result will
only be 'Success' if all chunks have been submitted (or when
the file was uploaded as a whole, not chunked)
If we're still missing some chunks, result will be 'Continue'.
Bug: T190988
Change-Id: Ia0a4df0306b3e0cc0f2453f986b73bedd88241d3
Translation updater bot [Tue, 14 May 2019 19:54:55 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibd264a8b5ec69c0fa68d24cea424f78a49646171
jenkins-bot [Tue, 14 May 2019 18:47:26 +0000 (18:47 +0000)]
Merge "localisation: Inject 'directory' option to LCStore classes"
Bartosz Dziewoński [Tue, 14 May 2019 05:41:17 +0000 (07:41 +0200)]
jqueryMsg: Allow sneaking in non-qqx JavaScript messages in qqx mode
In commit
bb084a35739e3f3c54c8680f756ebebb90e13f28 I assumed that
with uselang=qqx, any messages defined in JavaScript would be just
the message key wrapped in parentheses.
It turns out that extensions (e.g. VisualEditor) have been sneaking
in messages in content language using the system we assumed to only
contain messages in user language. This trick stopped working.
Detect this and return the real message, if it's defined.
Bug: T222944
Change-Id: I3f2a6ceb249402ef76e788c494fd5bdc519faf65
Matthias Mullie [Tue, 14 May 2019 17:15:09 +0000 (19:15 +0200)]
Bind retry callback with correct this argument
Change-Id: I5db9e4e967d5569d4f90590333a7af2ddab1641f
Timo Tijhof [Mon, 6 May 2019 21:52:52 +0000 (22:52 +0100)]
localisation: Inject 'directory' option to LCStore classes
Avoid globals for this, inject them from the factory function instead.
Bug: T218207
Change-Id: Ia961e8e08dcf1ca154d74ea6a3dadd2d59c1299c
Reedy [Tue, 14 May 2019 15:55:59 +0000 (16:55 +0100)]
Remove FileRepoStatus
Change-Id: I4712d7cf8177dd3a7b8157d980dacb88a902262c
jenkins-bot [Tue, 14 May 2019 14:51:56 +0000 (14:51 +0000)]
Merge "Fix AbstractBlock param types in documentation"
Thalia [Tue, 14 May 2019 12:42:50 +0000 (13:42 +0100)]
Fix AbstractBlock param types in documentation
Change-Id: I503375485956d3c05da445542419fb62684ae34a
Derick Alangi [Tue, 14 May 2019 11:28:35 +0000 (12:28 +0100)]
SearchResult: MW version number should be a string in wfDeprecated call
Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).
To avoid this, use '1.32' instead of the integer form of the version.
Change-Id: I2420396e110284f582cd79820ffc6064e247b4b9
jenkins-bot [Mon, 13 May 2019 20:46:22 +0000 (20:46 +0000)]
Merge "watchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges"
Translation updater bot [Mon, 13 May 2019 20:18:21 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2968beda4424a3eab0515fc1a8b597f2f8273e56
jenkins-bot [Mon, 13 May 2019 19:46:34 +0000 (19:46 +0000)]
Merge "Update release notes following the refactor of Block"
Thalia [Mon, 13 May 2019 17:19:51 +0000 (18:19 +0100)]
Update release notes following the refactor of Block
This is a follow-up to I83bceb5.
Bug: T222737
Change-Id: Ic01a4bb196733a719860c21b7c9b8a41a2e1257a
James D. Forrester [Sat, 27 Apr 2019 05:02:39 +0000 (00:02 -0500)]
resources: Drop jquery.async, deprecated since 1.33
Bug: T209699
Change-Id: Ia1a034de8d9996d9955744b7b2b453f4845d69d8
jenkins-bot [Mon, 13 May 2019 17:45:45 +0000 (17:45 +0000)]
Merge "feedback: Fix misplaced mw.Title.getNameText() call"
jenkins-bot [Mon, 13 May 2019 16:30:16 +0000 (16:30 +0000)]
Merge "Follow-up
ee66a534: Drop reference to old 7zip.inc file name from phan config too"
jenkins-bot [Mon, 13 May 2019 15:46:44 +0000 (15:46 +0000)]
Merge "Make ApiQueryUserInfo::getBlockInfo accept an AbstractBlock"
James D. Forrester [Mon, 13 May 2019 11:09:41 +0000 (12:09 +0100)]
build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0 and make pass
Fix five instances of PhanPluginDuplicateConditionalNullCoalescing;
escape the rest for now.
Bug: T219114
Change-Id: Ic4bb30c43c5315ce6b878b37b432c6e219414f8b
Derick Alangi [Sat, 11 May 2019 15:21:18 +0000 (16:21 +0100)]
SearchEngine: Remove deprecated unused method `transformSearchTerm()`
I've checked around with code search tool and realized that SMW has
its own implementation of `transformSearchTerm()` which overwrites the
implementation of this method from core as it extends SearchEngine.
So removing this won't break SMW, see usage below;
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbtransformSearchTerm%5Cb&i=nope&files=&repos=
Bug: T220656
Change-Id: I3dbe04ecba07700167c894673e23c1eead95460f
James D. Forrester [Mon, 13 May 2019 14:27:57 +0000 (15:27 +0100)]
Follow-up
ee66a534: Drop reference to old 7zip.inc file name from phan config too
Change-Id: I4e018ab676f114a45edb9e7ca6025490134a2ef0
jenkins-bot [Mon, 13 May 2019 14:24:03 +0000 (14:24 +0000)]
Merge "Add tests for HttpRequestFactoryTest."
Thalia [Mon, 13 May 2019 14:20:38 +0000 (15:20 +0100)]
Make ApiQueryUserInfo::getBlockInfo accept an AbstractBlock
This method was removed (I84ed216) before the Block class was
refactored (I83bceb5) and restored (If47a938) after the refactor.
After the refactor, this method should accept and AbstractBlock,
so it can handle a SystemBlock as well as a database Block.
Change-Id: Ice8a2e7c19e88406229bd836a45f377abdb72fb6
Derick Alangi [Mon, 13 May 2019 13:02:19 +0000 (14:02 +0100)]
tests: Remove deprecated rarely used method stashMwGlobals()
This method was hard deprecated in 1.32 and seems it's no longer
used? Can we remove it now?
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbstashMwGlobals%5Cb&i=nope&files=&repos=
Change-Id: I8d105a82093ea4cb3a38ed04e471e0213b29e8ec
daniel [Mon, 13 May 2019 10:38:00 +0000 (12:38 +0200)]
Add tests for HttpRequestFactoryTest.
This also moves several tests out of HttpTest, so they are not lost when
the deprecated Http class is removed.
Bug: T222935
Change-Id: Ib4aac96ba1a978e8b6738ed446663afc3cc8c792
jenkins-bot [Mon, 13 May 2019 11:55:30 +0000 (11:55 +0000)]
Merge "move 7zip.inc to a regular php file"
Ariel T. Glenn [Mon, 13 May 2019 10:38:37 +0000 (13:38 +0300)]
move 7zip.inc to a regular php file
Bug: T182814
Change-Id: I53746333fe3c1cdc357bf46d71a351231a845e2f
jenkins-bot [Mon, 13 May 2019 10:51:01 +0000 (10:51 +0000)]
Merge "jobqueue: Remove deprecated unused method pushLazyJobs()"
Derick Alangi [Sat, 11 May 2019 15:05:58 +0000 (16:05 +0100)]
jobqueue: Remove deprecated unused method pushLazyJobs()
Was deprecated in 1.33 and is no longer used anywhere. See usage
below;
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbpushLazyJobs%5Cb&i=nope&files=&repos=
Bug: T220656
Change-Id: I4d3f6bc019b8ebc7e504d841fc75acdb08061cb4
daniel [Mon, 13 May 2019 09:31:52 +0000 (11:31 +0200)]
Return result from HttpRequestFactory get and post methods
Bug: T222935
Change-Id: Idf1d00d04abbcf4e3391e3979bbab97e595916a5
Thiemo Kreuz [Mon, 13 May 2019 09:28:30 +0000 (11:28 +0200)]
title: Convert binary regexp to use Unicode code points
The hex sequences are the raw binary values for the Unicode code points.
Now that we have a more modern PHP at hand, we can use \x{FFFF} for
Unicode characters.
I believe the /S is not needed any more. It "precompiles" the regular
expression. But this is a pretty trivial regular expression.
Precompiling it is most probably even slower.
Change-Id: I49435114b3bc31dcce8aa4e48091d509844a2a07
Thiemo Kreuz [Mon, 13 May 2019 08:21:10 +0000 (10:21 +0200)]
feedback: Fix misplaced mw.Title.getNameText() call
What is called "name" here is a file name without the extension. But
the feedback code is not about files. It's a regular page that might
contain a dot. If it does, the link will be broken, because everything
after the last dot will be stripped.
Change-Id: I9a7c7b73f5d899400ffdc4f4a92cb8b42e644b1c
Ariel T. Glenn [Sun, 11 Feb 2018 10:37:41 +0000 (12:37 +0200)]
move most of dumpTextPass to an include file so it can be subclassed
Bug: T164262
Change-Id: I9b3c54503dd9ad193af7765459613a7e73ffbb45
jenkins-bot [Mon, 13 May 2019 06:51:45 +0000 (06:51 +0000)]
Merge "allow xml page content or metadata dumps to target specific namespaces"
Translation updater bot [Sun, 12 May 2019 19:56:52 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9dabebcc8d21def62949958e402e314797e71799
zoranzoki21 [Thu, 9 May 2019 14:25:36 +0000 (16:25 +0200)]
Updated special page name translations for Slovak language
Bug: T222793
Change-Id: I738aaa9767f3062be8ad9357072ec5b942e3e7da
jenkins-bot [Sat, 11 May 2019 19:19:16 +0000 (19:19 +0000)]
Merge "changetags: Remove deprecated unused method `purgeTagUsageCache()`"
jenkins-bot [Sat, 11 May 2019 19:19:09 +0000 (19:19 +0000)]
Merge "api: Remove deprecated `prepareUrlQuerySearchString()` from core"
jenkins-bot [Sat, 11 May 2019 19:06:42 +0000 (19:06 +0000)]
Merge "Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions"
Derick Alangi [Sat, 11 May 2019 15:00:56 +0000 (16:00 +0100)]
changetags: Remove deprecated unused method `purgeTagUsageCache()`
This method was hard deprecated in 1.33 in core and no longer used
anymore.
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbpurgeTagUsageCache%5Cb&i=nope&files=&repos=
Bug: T220656
Change-Id: I79b364b8a95d9bbf9265c1efa844ff59d11f48aa
Derick Alangi [Sat, 11 May 2019 14:55:34 +0000 (15:55 +0100)]
api: Remove deprecated `prepareUrlQuerySearchString()` from core
This method was deprecated in 1.33 and is no longer used.
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbprepareUrlQuerySearchString%5Cb&i=nope&files=&repos=
Bug: T220656
Change-Id: I15a476438f3a579db41a43658e13b6ddc4fc62d4
jenkins-bot [Sat, 11 May 2019 09:42:28 +0000 (09:42 +0000)]
Merge "Restore ApiQueryUserInfo::getBlockInfo() as a stub."
daniel [Thu, 9 May 2019 10:13:30 +0000 (12:13 +0200)]
Restore ApiQueryUserInfo::getBlockInfo() as a stub.
Fixes unintended breaking change made by I84ed21641c44b2f65ebe.
ApiQueryUserInfo::getBlockInfo() is restoed as a hard deprecated stub.
This renames the method in the new ApiBlockInfoTrait to
getBlockDetails.
Depends-On: I9f40666a31bd4af50762c197c2ce5bf089a5e68c
Change-Id: If47a93878f87d69800e5f305404c22528dac5e94
Reedy [Sat, 11 May 2019 01:17:43 +0000 (02:17 +0100)]
Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions
Change-Id: I78b3315f26ab91b6b443f5b028a635552f82f5a3
jenkins-bot [Sat, 11 May 2019 01:37:01 +0000 (01:37 +0000)]
Merge "watchlist: cleanup various method/variable names and comments in watchlist/store code"
Reedy [Sat, 11 May 2019 00:20:15 +0000 (01:20 +0100)]
Update cssjanus/cssjanus from 1.2.1 to 1.3.0
https://github.com/cssjanus/php-cssjanus/releases/tag/v1.3.0
https://github.com/cssjanus/php-cssjanus/compare/v1.2.1...v1.3.0
Bug: T215746
Change-Id: I352f79f6f34279e669057aee7c2f1570800c8a11
Depends-On: Id8aba2d9e99671a9c45e02b271dbf290a11228d7
Reedy [Fri, 10 May 2019 23:19:25 +0000 (00:19 +0100)]
Update some composer dependancies
Update composer/semver from 1.4.2 to 1.5.0
https://github.com/composer/semver/releases/tag/1.5.0
https://github.com/composer/semver/compare/1.4.2...1.5.0
Update composer/spdx-licenses from 1.4.0 to 1.5.1
https://github.com/composer/spdx-licenses/compare/1.4.0...1.5.1
https://github.com/composer/spdx-licenses/releases/tag/1.5.1
Update mediawiki/codesniffer from 25.0.0 to 26.0.0
https://github.com/wikimedia/mediawiki-tools-codesniffer/releases/tag/v26.0.0
https://github.com/wikimedia/mediawiki-tools-codesniffer/compare/25.0.0...v26.0.0
Disable failing Squiz.WhiteSpace.FunctionSpacing, can be fixed in a later
commit
Change-Id: I89062c8f28bef893f054650f2e81287291ba9ca0
Depends-On: I8f55e77283f83d853ce340f5c1b7704c65e45bc4
jenkins-bot [Fri, 10 May 2019 17:19:18 +0000 (17:19 +0000)]
Merge "selenium: Add jpeg-js to devDependencies"
jenkins-bot [Fri, 10 May 2019 17:03:17 +0000 (17:03 +0000)]
Merge "Add another Bengali synonym for HIDDENCAT in MessagesBn.php"
jenkins-bot [Fri, 10 May 2019 17:00:15 +0000 (17:00 +0000)]
Merge "user: Remove deprecated and unused method `getPasswordValidity()`"
jenkins-bot [Fri, 10 May 2019 17:00:06 +0000 (17:00 +0000)]
Merge "Remove deprecated unused method `getModuleScripts()`"
jenkins-bot [Fri, 10 May 2019 16:59:58 +0000 (16:59 +0000)]
Merge "Add 'avoidhours' option to Language#formatTimePeriod"
jenkins-bot [Fri, 10 May 2019 16:20:09 +0000 (16:20 +0000)]
Merge "Remove unused title parameter from EditPage::getEditToolbar()"
Željko Filipin [Fri, 10 May 2019 14:25:24 +0000 (16:25 +0200)]
selenium: Add jpeg-js to devDependencies
It is needed for I92739d84947ac146e in WikibaseMediaInfo Selenium tests.
It can not be added there because of T199116.
Bug: T219815
Bug: T199116
Change-Id: Ib7c3b1b49c280bdc38c40c6aef900a605c1e3cbe
David Causse [Fri, 10 May 2019 13:57:58 +0000 (15:57 +0200)]
Properly output the name of the file in assertFileContains
Change-Id: If02d094049bd8ec21d5f180382ccc4bc6202f981
Thiemo Kreuz [Fri, 10 May 2019 13:23:20 +0000 (15:23 +0200)]
Remove unused title parameter from EditPage::getEditToolbar()
No code uses this parameter:
https://codesearch.wmflabs.org/search/?q=getEditToolbar
I suggest to skip any deprecation because of this.
It might be worth mentioning this in the release notes anyway, or is
it?
Change-Id: I5d47c22fa741df5f9c248e4e1bff2d6e97aca6a7
jenkins-bot [Fri, 10 May 2019 08:51:37 +0000 (08:51 +0000)]
Merge "Missing space between variable name and docstring"
Adam Wight [Fri, 10 May 2019 08:25:56 +0000 (10:25 +0200)]
Missing space between variable name and docstring
Change-Id: I308a0de17da5058691ceea983e60c064b0bfc16c
Jack Phoenix [Sat, 4 May 2019 09:27:04 +0000 (12:27 +0300)]
Add 'avoidhours' option to Language#formatTimePeriod
Example use case: in some skins we want to show how many *days* ago a page was edited, but we don't really care about the precise _hours_.
Thus we'll set [ 'avoid' => 'avoidhours' ] when calling Language#formatTimePeriod to output something like "Page last edited 60 days ago" instead of "Page last edited 60 days 9 hours ago".
Change-Id: I0a737aab14ccb2b8d4eccdc41e1eb9232eedcb8a
Translation updater bot [Fri, 10 May 2019 06:15:09 +0000 (08:15 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie08ae3ddb5a880d39092ff0828d5059d3eb74724
Aaron Schulz [Fri, 10 May 2019 00:59:04 +0000 (17:59 -0700)]
watchlist: fix nonsensical timestamp/boolean comparisons in EnhancedRecentChanges
Also fix bug where the "changes since last visit" counter failed to show for pages
where their entire history is still in recent changes. Although the "new" flag is
set for the RCCacheEntry block, there can still be multiple revisions since the
last one seen by the user. This change accounts for that case.
Bug: T218511
Change-Id: I92060bd26d8642937cad7f8c1ace3c5e066790be
Aaron Schulz [Fri, 10 May 2019 00:37:58 +0000 (17:37 -0700)]
watchlist: cleanup various method/variable names and comments in watchlist/store code
Change-Id: I70a55d5b4ea38f92132a15da3feb314b6b5bb013
Derick Alangi [Thu, 9 May 2019 22:31:17 +0000 (23:31 +0100)]
user: Remove deprecated and unused method `getPasswordValidity()`
This method was deprecated in 1.33 and no longer used. See usage;
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbgetPasswordValidity%5Cb&i=nope&files=&repos=
Bug: T220656
Change-Id: I28829f33d40b5568bedb9678fc43beb146b72e56
Aaron Schulz [Thu, 9 May 2019 23:13:15 +0000 (16:13 -0700)]
Remove unused EventRelayer code from ObjectCache::newWANCacheFromParams()
Change-Id: I6c0f274e3c49312b63446732f22123af9dac8a2b
jenkins-bot [Thu, 9 May 2019 22:58:49 +0000 (22:58 +0000)]
Merge "Always validate uploads over api"
Derick Alangi [Thu, 9 May 2019 22:25:53 +0000 (23:25 +0100)]
Remove deprecated unused method `getModuleScripts()`
Deprecated in 1.33 and no longer used. Removed from OutputPage and
from ParserOutput.
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbgetModuleScripts%5Cb&i=nope&files=&repos=
Bug: T220656
Change-Id: Ifddea94504d0c749d3a77daf967d5fec95b50339
Derick Alangi [Sat, 20 Apr 2019 21:54:28 +0000 (22:54 +0100)]
MWMessagePack: Deprecate MWMessagePack class and its method
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbMWMessagePack%5Cb&i=nope&files=&repos=
Bug: T220313
Change-Id: I3648f8c14116f924d835f68077f46333d892a038
Derick Alangi [Thu, 9 May 2019 15:19:53 +0000 (16:19 +0100)]
page: Remove deprecated/unused methods in PageArchive class
This code is no longer used per usage (below) and was to be actually
removed in 1.33. Methods are;
getLastRevisionText(), listAllPages() and getTextFromRow(), see example
search of usage below.
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbgetTextFromRow%5Cb&i=nope&files=&repos=
Change-Id: I4b9675a9cf84442f08f125f4c23ec67d72b12c15
Derick Alangi [Mon, 29 Apr 2019 23:12:58 +0000 (00:12 +0100)]
Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput()
Language::initEncoding(), ::recodeForEdit(), and ::recodeInput() deprecated in
1.28 are now removed.
Usage
=====
* initEncoding() -
https://codesearch.wmflabs.org/search/?q=initEncoding&i=nope&files=&repos=
* recodeForEdit() -
https://codesearch.wmflabs.org/search/?q=recodeForEdit&i=nope&files=&repos=
* recodeInput() -
https://codesearch.wmflabs.org/search/?q=recodeInput&i=nope&files=&repos=
Bug: T220656
Change-Id: I309ec5eebbdddd3b71541c446b15b15204abf8ca