Brad Jorsch [Sat, 12 Jan 2019 19:16:52 +0000 (14:16 -0500)]
Avoid session double-start in Setup.php
In PHP before 7.3, the double start doesn't really matter: session_id()
changes the ID even if it was already started, and the warning from
session_start() can just be ignored. Which is what we did.
In PHP 7.3, now session_id() also warns and no longer changes the ID. To
preserve the previous behavior, we'll need to explicitly close the old
session and open the new one.
Bug: T213489
Change-Id: I02a5be1c3adb326927c156fdd00663bccee37477
jenkins-bot [Wed, 16 Jan 2019 08:34:42 +0000 (08:34 +0000)]
Merge "Chinese Conversion Table Update 2018-4"
Krinkle [Wed, 16 Jan 2019 07:49:54 +0000 (07:49 +0000)]
Merge "resourceloader: Avoid unnecessary xmlns attributes in ResourceLoaderImage"
jenkins-bot [Wed, 16 Jan 2019 07:04:36 +0000 (07:04 +0000)]
Merge "Setup: Avoid using count() function in any kind of loop(s)"
jenkins-bot [Wed, 16 Jan 2019 07:03:47 +0000 (07:03 +0000)]
Merge "Safe replacement of a lot of `!count()` with `=== []`"
Bartosz Dziewoński [Tue, 15 Jan 2019 19:43:35 +0000 (20:43 +0100)]
resourceloader: Avoid unnecessary xmlns attributes in ResourceLoaderImage
We were creating the `<g>` element without specifying a namespace,
which caused the library to add `xmlns` attributes with the document's
default SVG namespace to elements that we appended underneath it.
(At least, that's what I think was happening.)
Specify the SVG namespace when creating it to avoid the mess and
reduce resulting file size.
Change-Id: Ida27494aeae9dece16f878c16cf9aa582e6deac3
jenkins-bot [Wed, 16 Jan 2019 00:39:29 +0000 (00:39 +0000)]
Merge "resourceloader: Avoid toplevel `<title>` under `<g>` in ResourceLoaderImage"
Bartosz Dziewoński [Tue, 15 Jan 2019 19:28:30 +0000 (20:28 +0100)]
resourceloader: Avoid toplevel `<title>` under `<g>` in ResourceLoaderImage
While it shouldn't be causing any rendering problems,
doing so is semantically incorrect.
Bug: T213507
Change-Id: Ic86cd2bf3028eb24ad60db7ffa9498dd86edd4a5
Thiemo Kreuz [Tue, 15 Jan 2019 11:36:04 +0000 (12:36 +0100)]
Add missing "@return StatusValue" to all abstract do… methods
All implementations do this, and all callers expect this. I wonder how
the documentation for this detail got lost?
Change-Id: If4977c9f4032ca5d93ea91f49cdc70f7ef1175ba
Thiemo Kreuz [Tue, 15 Jan 2019 15:04:58 +0000 (16:04 +0100)]
Add missing empty lines between methods
This might hint at an edge-case in the PHP CodeSniffer sniff that should
detect if methods are separated by a single empty line. Feel free to
investigate. I, personally, can't invest more time in this than
suggesting this quick fix.
Change-Id: Ib3c60eac76f255b4fe929f7933de256222716576
Thiemo Kreuz [Wed, 9 Jan 2019 16:24:36 +0000 (17:24 +0100)]
Safe replacement of a lot of `!count()` with `=== []`
This was originally a global search and replace. I manually checked all
replacements and reverted them if (due to the lack of type hints) either
null (that would be 0 when counted) or a Countable object can end in the
variable or property in question.
Now this patch only touches places where I'm sure nothing can break.
For the sanity of the honorable reviewers this patch is exclusively touching
negated counts. You should not find a single `!== []` in this patch, that
would be a mistake.
Change-Id: I5eafd4d8fccdb53a668be8e6f25a566f9c3a0a95
jenkins-bot [Tue, 15 Jan 2019 15:40:49 +0000 (15:40 +0000)]
Merge "Fix non-editing partial block creation on Special:Block"
Derick Alangi [Sat, 12 Jan 2019 19:39:51 +0000 (20:39 +0100)]
Setup: Avoid using count() function in any kind of loop(s)
Using count() function in loops makes things very slow because
of function overheads and this function gets called everytime the
loop runs meaning the bigger the value of the variable in count(),
the slower the loop as its value always gets computed as the loop
runs.
In this case, the use of foreach(...){} is possible in order to
perform the computation making it pretty fast hence improving the
performance.
Change-Id: Ie21fbf8f6acf72373d1da75023725b4592c80386
Thalia [Mon, 14 Jan 2019 14:58:42 +0000 (14:58 +0000)]
Fix non-editing partial block creation on Special:Block
Bug: T213707
Change-Id: Iaf8b3a6a0b2715808c9e6f8de94d315404368b12
jenkins-bot [Mon, 14 Jan 2019 22:12:23 +0000 (22:12 +0000)]
Merge "registration: Allow overriding attributes in tests"
jenkins-bot [Mon, 14 Jan 2019 20:54:47 +0000 (20:54 +0000)]
Merge "OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76"
Kunal Mehta [Sat, 12 Jan 2019 19:35:02 +0000 (11:35 -0800)]
registration: Allow overriding attributes in tests
ExtensionRegistry is a rather special singleton that can't use the normal
MediaWikiServices reset due to its early initialization, so introduce
a ->setAttributeForTest method to override attributes that are typically
loaded from extension.json.
Bug: T200013
Change-Id: I9e62a02ed2044c847e9ab2dcdfab094001f88986
Bartosz Dziewoński [Mon, 14 Jan 2019 20:08:11 +0000 (21:08 +0100)]
OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76
Bug: T213544
Change-Id: I0bec76fd6d394329331c23ef43c28cb502cb5605
Bartosz Dziewoński [Mon, 14 Jan 2019 19:52:48 +0000 (20:52 +0100)]
Remove leading space from 'selfmove' message
It would cause the error message to render as preformatted text.
https://phabricator.wikimedia.org/
F27889207
Change-Id: I83136e4ac29eb091b4a86ab3bc22c907bb8ca7bc
Fomafix [Mon, 14 Jan 2019 06:01:19 +0000 (07:01 +0100)]
Fix @param values on private functions
Change-Id: Id7442d5fc557227b3973f5008a3bc1390c528737
jenkins-bot [Mon, 14 Jan 2019 16:46:37 +0000 (16:46 +0000)]
Merge "Rescue some more HISTORY"
Reedy [Mon, 14 Jan 2019 16:07:17 +0000 (16:07 +0000)]
Rescue some more HISTORY
Change-Id: Ieb7a95b91aa3d83574e8553acfb89e2b9eee027a
Translation updater bot [Sun, 13 Jan 2019 20:53:25 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1fe81ace8ae5a401ac3f7e3dbf29b82fa3f274f3
jenkins-bot [Sun, 13 Jan 2019 01:48:47 +0000 (01:48 +0000)]
Merge "Clarify warnings about missing software diff3 and git."
Thiemo Kreuz [Wed, 9 Jan 2019 15:52:38 +0000 (16:52 +0100)]
Use the ?: shortcut from PHP 5.3 where it makes sense
Change-Id: Ieff70f23b19f0be3670c4ed3e2a5c30ef3792d7f
Translation updater bot [Sat, 12 Jan 2019 21:04:59 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I0d13f0ef78e9ee1936af9f642c441853457e5409
jenkins-bot [Sat, 12 Jan 2019 19:01:45 +0000 (19:01 +0000)]
Merge "Add special page class for disabling special pages"
Gergő Tisza [Fri, 16 Nov 2018 02:22:26 +0000 (18:22 -0800)]
Add special page class for disabling special pages
Similar to the ApiDisabled class, but for special pages.
Change-Id: Ib56860bc3f8a14fd332b775b1e7f50953641ee82
jenkins-bot [Sat, 12 Jan 2019 18:15:40 +0000 (18:15 +0000)]
Merge "ImageListPager: Kill that annoying GROUP BY"
jenkins-bot [Sat, 12 Jan 2019 16:25:01 +0000 (16:25 +0000)]
Merge "Move RELEASE-NOTES-1.32 (from REL1_32) into HISTORY"
Reedy [Thu, 10 Jan 2019 22:04:22 +0000 (22:04 +0000)]
Move RELEASE-NOTES-1.32 (from REL1_32) into HISTORY
REL1_32 has gone out of the door!
Change-Id: Id93f97d73b5213935379c8ab62724897504adaad
Thiemo Kreuz [Fri, 11 Jan 2019 18:25:26 +0000 (19:25 +0100)]
export: Mark DumpFilter::mark() as being protected
I used
https://codesearch.wmflabs.org/search/?q=-%3Epass%5C(
to make sure there really is no other call to this. This function really
is meant to be protected.
I also used
https://codesearch.wmflabs.org/search/?q=function%20pass%5C(&files=php
to make sure I got all subclasses.
Required for I7da632c43681438aa886bdb709379f10cd9cc658.
Change-Id: I9aaf95c66a6efa22131de627ce015587a109858b
jenkins-bot [Fri, 11 Jan 2019 17:28:51 +0000 (17:28 +0000)]
Merge "Update OOUI to v0.30.1"
jenkins-bot [Fri, 11 Jan 2019 17:03:42 +0000 (17:03 +0000)]
Merge "clientpool: Fix non-canonical order of elements (PHPDocs)"
jenkins-bot [Fri, 11 Jan 2019 16:50:46 +0000 (16:50 +0000)]
Merge "block: Avoid use of is_null() PHP function where necessary"
jenkins-bot [Fri, 11 Jan 2019 16:37:13 +0000 (16:37 +0000)]
Merge "collation: Fix non-canonical order of elements"
jenkins-bot [Fri, 11 Jan 2019 16:23:10 +0000 (16:23 +0000)]
Merge "actions: Avoid use of is_null() PHP function where necessary"
Derick Alangi [Fri, 11 Jan 2019 09:43:39 +0000 (10:43 +0100)]
clientpool: Fix non-canonical order of elements (PHPDocs)
Change-Id: Ia45326a11ae6da2b3196804d70f823c841570e7c
James D. Forrester [Fri, 11 Jan 2019 16:19:16 +0000 (08:19 -0800)]
Update OOUI to v0.30.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.1
Bug: T76638
Bug: T210847
Bug: T212977
Depends-On: Ib466527110d5068e297c42ebb3dd381c0c83754a
Change-Id: Ib466527110d5068e297c42ebb3dd381c0c83754b
Derick Alangi [Fri, 11 Jan 2019 15:49:44 +0000 (16:49 +0100)]
block: Avoid use of is_null() PHP function where necessary
WRT performance, is_null() is a few nanoseconds slower than === null
due to function call overhead. Also, I personally think using the
identical check on null is slightly more readable than using is_null().
Change-Id: I83cd7a6ca49acc548a7f46b2c37dfa189889bd19
Derick Alangi [Fri, 11 Jan 2019 15:40:27 +0000 (16:40 +0100)]
actions: Avoid use of is_null() PHP function where necessary
WRT performance, is_null() is a few nanoseconds slower than === null
due to function call overhead. Also, I personally think using the
identical check on null is slightly more readable than using is_null().
Change-Id: Ie5b1ac17a18907e92eb3042decb7fc75e903123d
jenkins-bot [Fri, 11 Jan 2019 11:47:05 +0000 (11:47 +0000)]
Merge "Fix SVG metadata handler by changing offset from -1 to 0"
Derick Alangi [Fri, 11 Jan 2019 09:48:14 +0000 (10:48 +0100)]
collation: Fix non-canonical order of elements
Change-Id: Ie3f19e9e1f91faf6cee32c3c63d86215ba52c8e2
zoranzoki21 [Thu, 10 Jan 2019 19:26:39 +0000 (20:26 +0100)]
Fix Revison typo
Bug: T201491
Change-Id: I4a91d64dafdafd022462730c221cdf2a113d2ef2
Brian Wolff [Fri, 11 Jan 2019 00:08:07 +0000 (00:08 +0000)]
Fix SVG metadata handler by changing offset from -1 to 0
Starting in php 7.1, negative offsets are supported in
file_get_contents. Previously they were not (and in fact, the
php docs said -1 was the default value for the offset if unspecified).
The result of this, is starting in php 7.1, MediaWiki could not determine
the aspect ratio of SVG files that were larger than 256kb.
Follows up
e6de99be
Bug: T213501
Change-Id: I565e51cd8131542b9a70da49e9cc36c5594ecda3
jenkins-bot [Thu, 10 Jan 2019 22:10:43 +0000 (22:10 +0000)]
Merge "rollbackEdits.php: Cosmetic changes of outputs"
jenkins-bot [Thu, 10 Jan 2019 21:59:46 +0000 (21:59 +0000)]
Merge "build: Remove 'stylelint' package as it gets pulled-in by 'stylelint-config-wikimedia'"
Translation updater bot [Thu, 10 Jan 2019 21:26:23 +0000 (22:26 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I707519be5cbb133b724b02d0659fe35ce545df82
Volker E [Thu, 10 Jan 2019 21:17:31 +0000 (13:17 -0800)]
build: Remove 'stylelint' package as it gets pulled-in by 'stylelint-config-wikimedia'
Change-Id: I734ebf6c18a3266bec2d9c9e38e827c3ec412586
jenkins-bot [Thu, 10 Jan 2019 21:13:37 +0000 (21:13 +0000)]
Merge "maintenance: Fix detection of bad hooks (wfRunHooks -> Hooks::run)"
jenkins-bot [Thu, 10 Jan 2019 19:50:52 +0000 (19:50 +0000)]
Merge "filerepo: Remove begin/done comments from LocalFile"
Timo Tijhof [Thu, 10 Jan 2019 19:33:10 +0000 (11:33 -0800)]
maintenance: Fix detection of bad hooks (wfRunHooks -> Hooks::run)
It was still looking for wfRunHooks, which no longer exists
as of MediaWiki 1.32.
After this, it is now able to find one bad hook:
> Unclear hook calls:
> - Hooks::run( $action . 'ArticleComplete', [ .. ] ); # SpecialEditWatchlist
Also, remove the matching of wfRunHooks generally, given it no
longer exists. And also remove the historic notes from hooks.txt.
Change-Id: I4ac52ed75fb99d7775d4b4755e3f0871003d70a8
Bartosz Dziewoński [Thu, 10 Jan 2019 15:53:20 +0000 (16:53 +0100)]
Add missing message for OOUI v0.30.0
Follow-up to
221b03c2436dd99f395e22e09fd356e4d380e04d.
Change-Id: I18193b191c516c14e32f0959dee2ac4c78564ce8
jenkins-bot [Thu, 10 Jan 2019 15:51:14 +0000 (15:51 +0000)]
Merge "createAndPromote: use AuthManager::autoCreateUser"
jenkins-bot [Thu, 10 Jan 2019 15:51:08 +0000 (15:51 +0000)]
Merge "Fix slow queries in migrateActors.php"
zoranzoki21 [Thu, 10 Jan 2019 13:47:45 +0000 (14:47 +0100)]
rollbackEdits.php: Cosmetic changes of outputs
Change-Id: I18313edf4fe9577fb488159b019689a450454b2f
jenkins-bot [Wed, 9 Jan 2019 23:36:27 +0000 (23:36 +0000)]
Merge "Improve readability of LogFormatter::makePageLink"
jenkins-bot [Wed, 9 Jan 2019 21:20:38 +0000 (21:20 +0000)]
Merge "Don't check for LIBXML_PARSEHUGE presence"
jenkins-bot [Wed, 9 Jan 2019 21:20:32 +0000 (21:20 +0000)]
Merge "Remove a CURLOPT_CONNECTTIMEOUT_MS check"
Translation updater bot [Wed, 9 Jan 2019 20:53:06 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9ee05968b2a310c032969eaf5f52f703b796ba16
Thalia [Wed, 9 Jan 2019 16:09:37 +0000 (16:09 +0000)]
Fix malformed output of block logs
Avoid adding <span> to expiry parameter whenever block log is
stored as plaintext.
Bug: T208523
Change-Id: Id3fcdfda7311484911ae1f57ec262a2c6e6ab00b
Thiemo Kreuz [Wed, 9 Jan 2019 16:01:09 +0000 (17:01 +0100)]
filerepo: Remove begin/done comments from LocalFile
I argue that these comments don't provide any additional information.
I think the code explains itself already.
Change-Id: I7b495dfde5e8b27a4cdd4bfcf84d388ffc2db5e3
Thalia [Wed, 9 Jan 2019 15:58:16 +0000 (15:58 +0000)]
Improve readability of LogFormatter::makePageLink
Change-Id: I912d9626b99697d5a0394b72a56ffc8a5e7aa1bb
Amir Sarabadani [Wed, 9 Jan 2019 08:05:49 +0000 (09:05 +0100)]
Fix order of arguments in ChangeTags::getPrevTags
Bug: T212703
Change-Id: I9e38c999718762daeb5c155ea8eaaa5d16dd85c1
jenkins-bot [Tue, 8 Jan 2019 21:34:12 +0000 (21:34 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 8 Jan 2019 21:24:48 +0000 (21:24 +0000)]
Merge "Fix missing ATOMIC_CANCELABLE in MovePage::move()"
Translation updater bot [Tue, 8 Jan 2019 21:13:08 +0000 (22:13 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibe90f37243cab5598d9a1d319e0a88ae9fcf4fdb
Bryan Davis [Sun, 30 Dec 2018 02:41:27 +0000 (19:41 -0700)]
createAndPromote: use AuthManager::autoCreateUser
Use AuthManager::autoCreateUser when creating a new user via
createAndPromote.php so that configured AuthManager providers have
a chance to perform validations and extra actions beyond local account
creation.
Bug: T212689
Change-Id: I4972507bbaf65bb542934c281c37bd8a5c7a26b7
Gergő Tisza [Tue, 8 Jan 2019 19:35:05 +0000 (11:35 -0800)]
Fix missing ATOMIC_CANCELABLE in MovePage::move()
Follow-up to I4aaa8af50d684de.
Bug: T213168
Change-Id: I0566b37117b6c69d4043e77e6368bf79fa84e325
jenkins-bot [Tue, 8 Jan 2019 19:06:47 +0000 (19:06 +0000)]
Merge "Update the design of Special:Block"
jenkins-bot [Tue, 8 Jan 2019 19:00:37 +0000 (19:00 +0000)]
Merge "build: Update qunitjs to 2.9.1"
jenkins-bot [Tue, 8 Jan 2019 18:57:25 +0000 (18:57 +0000)]
Merge "Remove comments documenting constructors as "constructors""
jenkins-bot [Tue, 8 Jan 2019 18:48:56 +0000 (18:48 +0000)]
Merge "Fix tag for partial blocks config"
jenkins-bot [Tue, 8 Jan 2019 18:37:25 +0000 (18:37 +0000)]
Merge "Add @since tags to new public methods related to partial blocks"
Thalia [Tue, 8 Jan 2019 17:44:00 +0000 (17:44 +0000)]
Fix tag for partial blocks config
Change-Id: I421298f216bc018d1606c297b2f89ee53c8da7ec
Ed Sanders [Tue, 8 Jan 2019 17:40:11 +0000 (17:40 +0000)]
build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I2930bcabeeb7b7b2eb36063e77b26e664a691b43
Brian Wolff [Mon, 28 Jul 2014 21:20:30 +0000 (18:20 -0300)]
Relax filter attribute filtering to allow self-referential urls
The filter attribute will often have things like filter="url( #foo )"
These local to the file filters in svgs should be fine (We already
disallow non-local xlink:href attributes on <filter> elements). In
fact, users can already do the exact same thing by doing:
style="filter: url( #foo )"
Bug: 67044
Change-Id: Ib25328c160c0d5ea7e01dc84616b76e1b9dcd0eb
Brian Wolff [Sat, 7 Jul 2018 16:03:32 +0000 (16:03 +0000)]
Clarify warnings about missing software diff3 and git.
Sometimes we get people on irc freaking out about the warnings.
If diff3 is missing, you just get a lot of edit conflicts.
If git is missing (A somewhat more common case) it just means that
Special:Version won't show the commit hash for things. Which
first of all doesn't matter and secondly is irrelavent to 90% of
users who are not installing from git.
Change-Id: I9c9ea797a80bd4efb6826f94373deee0311dc83a
Thalia [Tue, 8 Jan 2019 12:44:33 +0000 (12:44 +0000)]
Add @since tags to new public methods related to partial blocks
Bug: T210369
Change-Id: I20197ceee8e5e43fac20addc494b841519b915c8
Thiemo Kreuz [Wed, 2 Jan 2019 09:20:13 +0000 (10:20 +0100)]
Remove comments documenting constructors as "constructors"
Such comments are cruft and do not add anything that's not already
obvious from the code.
Change-Id: I42068b0c6c904bc4ee38f1700e0ea14c3d659a25
jenkins-bot [Tue, 8 Jan 2019 09:21:53 +0000 (09:21 +0000)]
Merge "HTMLSelectLanguageField: Add explicit sort"
jenkins-bot [Tue, 8 Jan 2019 07:00:20 +0000 (07:00 +0000)]
Merge "Revert "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action"""
RazeSoldier [Thu, 3 Jan 2019 05:13:19 +0000 (13:13 +0800)]
Add me to .mailmap and remove duplicate name
Change-Id: I39de232fc6d3986ce36e205d89523fe3c8b52500
Timo Tijhof [Tue, 8 Jan 2019 04:59:44 +0000 (20:59 -0800)]
build: Update qunitjs to 2.9.1
Code and integrity from <https://code.jquery.com/qunit/>.
Release notes at <https://github.com/qunitjs/qunit/releases>.
Highlights for the browser version:
- [2.7.0] Reporter: Remove cost of DOM size when
using "hidepassed=true".
- [2.7.0] Reporter: Use perf.now() for improved accurracy
of unit test durations.
- [2.7.0] Reporter: Make debugging tests in a browser
easier by adding timeline markers for DevTools.
Highlights for the npm package / CLI version:
- [2.9.0] CLI: Reduce dependency tree size
from 143 packages to 9 packages.
Change-Id: I38408d90765cd18d5dd6952b8b6b30cbfa0c7ed5
Max Semenik [Tue, 8 Jan 2019 03:32:39 +0000 (19:32 -0800)]
Don't check for LIBXML_PARSEHUGE presence
It's been present since PHP 5.3.2.
Change-Id: I23a3c50c10e984abe6ff214fbf504ab6f6be763c
Max Semenik [Tue, 8 Jan 2019 02:25:59 +0000 (18:25 -0800)]
Remove a CURLOPT_CONNECTTIMEOUT_MS check
It was introduced in PHP 5.2.3.
Change-Id: I0c7e1684038c98677ceefbcfbb78641e90713002
jenkins-bot [Tue, 8 Jan 2019 00:44:32 +0000 (00:44 +0000)]
Merge "objectcache: add more "touchedCallback" comments to WANObjectCache"
Volker E [Mon, 7 Jan 2019 22:25:00 +0000 (14:25 -0800)]
HTMLSelectLanguageField: Add explicit sort
Follow-up to I46dc6cc8f7d.
Change-Id: Ie5f8999cb6a24d394ceb1cf9b92facbd86431960
Translation updater bot [Mon, 7 Jan 2019 21:11:34 +0000 (22:11 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I4e4b7c8958b5c5626a9f5dc32f115c13f21eb8be
Elliott Eggleston [Thu, 20 Dec 2018 16:39:49 +0000 (11:39 -0500)]
WikiPage::doUpdateRestrictions checks DB_MASTER
This would prevent double entries in logs when the same protection
is applied twice within a few minutes. Trying out usage of the
parent patch's new functionality.
Bug: T210983
Change-Id: Ibd6e481db2faa5955f52f36d5d7368adc8747c9c
Thalia [Mon, 7 Jan 2019 14:04:54 +0000 (14:04 +0000)]
Update the design of Special:Block
Update the design now we have the extra options for
partial blocks.
Bug: T202773
Bug: T212964
Change-Id: I569eb2a8b15b9ad7f9f0e99bce2cd9b818a82fb4
jenkins-bot [Mon, 7 Jan 2019 18:51:29 +0000 (18:51 +0000)]
Merge "Do not pass $archiveName two times to OldLocalFile"
Aaron Schulz [Sun, 6 Jan 2019 21:55:14 +0000 (13:55 -0800)]
objectcache: add more "touchedCallback" comments to WANObjectCache
Change-Id: I55775216154aba0042f7c4cf1cb07336aa4a222e
jenkins-bot [Mon, 7 Jan 2019 17:29:11 +0000 (17:29 +0000)]
Merge "Pass READ_LATEST in $flags to Title::loadRestrictions"
Elliott Eggleston [Tue, 18 Dec 2018 19:35:00 +0000 (14:35 -0500)]
Pass READ_LATEST in $flags to Title::loadRestrictions
To be more consistent with other calls that do the same thing
Also bypass cache when READ_LATEST is set.
Removes duplicated $this->getArticleID call.
Removes $readLatest parameter from loadRestrictionsFromRows.
Bug: T210983
Change-Id: I2340e81fda8244b31f6a3c511ca29162f21d91c9
jenkins-bot [Mon, 7 Jan 2019 17:00:01 +0000 (17:00 +0000)]
Merge "Make user rights conflict error a bit more obvious"
jenkins-bot [Mon, 7 Jan 2019 16:59:55 +0000 (16:59 +0000)]
Merge "Add force option to password policy"
Gergő Tisza [Mon, 7 Jan 2019 01:36:43 +0000 (17:36 -0800)]
Make user rights conflict error a bit more obvious
Bug: T113048
Change-Id: Ia3992dcb473ec428188505e22b2def75fd23f98e
Tchanders [Thu, 6 Dec 2018 20:35:40 +0000 (20:35 +0000)]
Revert "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action""
This reverts commit
91fc7480301c8b2404cc280511c2fc83a6c3aa5d.
Hence it reapplies I6312a36911e5b73d773452fefef7ff25b9af08a4.
The changes made by this commit are (excluding the cases
checked for earlier):
* An action can only be blocked if prevents() is true/null and
isBlockedFrom() is truthy. Previously, any action other than
'edit' or 'create' would be blocked if prevents() was true/null,
regardless of isBlockedFrom().
* If an Action can be constructed, and requiresUnblock() is
false, the action won't be blocked. Previously, requiresUnblock()
wasn't checked.
This commit was previously reverted because it exposed that
EditEntityAction::requiresUnblock in Wikibase wrongly returned
false (fixed in I99061230023da2bbd0f98190a2907ca2e9717a4c).
Other potentially similar cases were audited in T211048.
Bug: T208862
Change-Id: If74a1d422290b8c62b7a7a8922621c73c9598269
jenkins-bot [Mon, 7 Jan 2019 12:07:46 +0000 (12:07 +0000)]
Merge "Special:UserRights: Fix handling of empty conflict check value"