Sam Reed [Mon, 8 Aug 2011 16:20:17 +0000 (16:20 +0000)]
Followup r88488, moved some of the prep work in it that was for r88493
Only apply code if needs to be added (more like SpecialWatchlist)
Chad Horohoe [Mon, 8 Aug 2011 16:08:48 +0000 (16:08 +0000)]
Mostly revert r89400: not needed since Brion fixed the tests in other ways
Rotem Liss [Mon, 8 Aug 2011 12:48:19 +0000 (12:48 +0000)]
Reverting part of r94011 (in MessagesHe.php): The new alias for Special:ChangePassword is the same as Special:PasswordReset, and means "reset" and not "change".
Krinkle [Mon, 8 Aug 2011 11:11:02 +0000 (11:11 +0000)]
Clean up mediawiki.Title test suite:
* Remove unused variable i and blti
* Change expected to a string instead of a number
** This removes the need for all the comments after 'expected' explaining the choice for that number
* Add assertion to verify exact output of the string, rather than just it's length
* Rename useLimit to hasLimit
Alexandre Emsenhuber [Sun, 7 Aug 2011 14:41:19 +0000 (14:41 +0000)]
Use local context instead of global variables
Alexandre Emsenhuber [Sun, 7 Aug 2011 14:29:28 +0000 (14:29 +0000)]
Temporaray revert of r94031; forgot that this was depending of some other work on my working copy
Alexandre Emsenhuber [Sun, 7 Aug 2011 12:28:58 +0000 (12:28 +0000)]
Readd basic headers and <html>...</html> arround error contents that was removed in r90993. This caused display errors of UTF-8 characters due to the lack of these things in a DBConnectionError exception.
Max Semenik [Sun, 7 Aug 2011 08:08:36 +0000 (08:08 +0000)]
Fixed sidebar tests on Windows. Can't use PHP_EOL here because \r\n is used only in SVN checkouts and not in tarballs
Alexandre Emsenhuber [Sat, 6 Aug 2011 20:39:15 +0000 (20:39 +0000)]
Made code more readable by moving the check about user being last editor when an edit conflicts occurs near related checks; also removed some variables that were used only once
Alexandre Emsenhuber [Sat, 6 Aug 2011 19:41:49 +0000 (19:41 +0000)]
* Moved action=history to use an Action subclass
* Removed obsolete aliases PageHistory and PageHistoryPager; unused
* Maintained backward compatibility with HistoryPage; extensions using it will still work
* Use local context instead of global variables
* Removed calls to OutputPage::setPageTitleActionText() and OutputPage::setSyndicated(), the first one does nothing and the second one is overriden by the setFeedAppendQuery() call just below
* Call Linker methods statically
* Fixed bug where feedEmpty() was not called on empty history since casting a ResultWrapper object to boolean always returns true even when there's no row
Max Semenik [Sat, 6 Aug 2011 16:39:59 +0000 (16:39 +0000)]
Warn user if mod_security is present
Sam Reed [Sat, 6 Aug 2011 12:18:15 +0000 (12:18 +0000)]
Partial revert to r94024
Only 2 lines in Vector needed reverting, not the whole revision
Brion Vibber [Sat, 6 Aug 2011 12:06:11 +0000 (12:06 +0000)]
Revert r89123 -- caused bug 30259 (switched correct calls with incorrect calls because of some interpretation of 'deprecation', causing invalid HTML output and breakage of watch tab on edit page)
Siebrand Mazeland [Sat, 6 Aug 2011 09:35:25 +0000 (09:35 +0000)]
Localisation updates for magic words from translatewiki.net.
Siebrand Mazeland [Sat, 6 Aug 2011 09:21:05 +0000 (09:21 +0000)]
Localisation updates for namespace names from translatewiki.net.
Siebrand Mazeland [Sat, 6 Aug 2011 08:35:42 +0000 (08:35 +0000)]
Localisation updates for special page aliases from translatewiki.net.
Sam Reed [Sat, 6 Aug 2011 00:24:18 +0000 (00:24 +0000)]
Documentation!
Chad Horohoe [Fri, 5 Aug 2011 21:47:37 +0000 (21:47 +0000)]
Standardize comments, wrap lines at 80 chars
Chad Horohoe [Fri, 5 Aug 2011 17:03:35 +0000 (17:03 +0000)]
Reverting r84309 (New pages log doesn't remove/update item after suppression redirect). Per the patch author and committer's own admission, this doesn't seem like the correct fix. I haven't dug into it deeply, but I tend to agree. Reverting to the status quo rather than have this make it into a release half-baked. Reopening bug 17463 so this can get some more discussion (also this definitely needed RELEASE-NOTES)
Sam Reed [Fri, 5 Aug 2011 16:05:41 +0000 (16:05 +0000)]
Whitespace and comment updates
Alexandre Emsenhuber [Fri, 5 Aug 2011 15:17:19 +0000 (15:17 +0000)]
* Call Linker methods statically
* Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation
Alexandre Emsenhuber [Fri, 5 Aug 2011 15:10:08 +0000 (15:10 +0000)]
$wgLanguageCode applies to $wgContLang, not $wgLang. This was breaking the test suite by dying with a "nooo!" in when reaching LanguageConverterTest.
Alexandre Emsenhuber [Fri, 5 Aug 2011 14:58:37 +0000 (14:58 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Sam Reed [Fri, 5 Aug 2011 14:55:53 +0000 (14:55 +0000)]
Followup r93905 per comment on bug 30230
Make text parameter of ApiExpandTemplates required
Raimond Spekking [Fri, 5 Aug 2011 14:40:09 +0000 (14:40 +0000)]
Localisation update for core and extension messages from translatewiki.net (2011-08-05 14:15:00)
Sam Reed [Fri, 5 Aug 2011 13:34:22 +0000 (13:34 +0000)]
* (bug 18634) Create API to fetch MediaWiki's language fallback tree structure
Patch by "merl"
Tested with pt-br, seems to work fine, listing pt and en for the fallback languages
Sam Reed [Fri, 5 Aug 2011 13:07:09 +0000 (13:07 +0000)]
Some annotation for (bug 29907) action=parse only fetches from the parser cache, it does not store to it
Mark A. Hershberger [Fri, 5 Aug 2011 12:40:49 +0000 (12:40 +0000)]
re: r93889: clarify that only registered users get movefile right by default.
Sam Reed [Fri, 5 Aug 2011 12:29:39 +0000 (12:29 +0000)]
Add @since to Revision::newFromRow per Nikerabbit
Follows up r93935
Jan Gerber [Fri, 5 Aug 2011 08:49:43 +0000 (08:49 +0000)]
dont use deprecated function WebRequest::getFileSize
Aaron Schulz [Fri, 5 Aug 2011 02:36:59 +0000 (02:36 +0000)]
$wgVersionNumber renamed to $wmfVersionNumber
Sam Reed [Fri, 5 Aug 2011 00:33:03 +0000 (00:33 +0000)]
Add documentation
Minor whitespace/brace additions
Aaron Schulz [Thu, 4 Aug 2011 23:33:50 +0000 (23:33 +0000)]
Removed interwiki list per r89431 CR
Sam Reed [Thu, 4 Aug 2011 23:26:53 +0000 (23:26 +0000)]
Followup r89564
Switch from newFromTitle to the new newFromRow in r93935
Sam Reed [Thu, 4 Aug 2011 23:25:34 +0000 (23:25 +0000)]
Adding Revision::newFromRow() function as alias for new Revision()
More consistent with how we do stuff everywhere else
Chad Horohoe [Thu, 4 Aug 2011 23:14:17 +0000 (23:14 +0000)]
Partial fix for r88772: no need for IGNORE on site_stats, just interwiki
Chad Horohoe [Thu, 4 Aug 2011 23:00:02 +0000 (23:00 +0000)]
Fix profiling in Article::getParserOutput()
Chad Horohoe [Thu, 4 Aug 2011 22:34:26 +0000 (22:34 +0000)]
Followup r93928: forgot to remove this
Chad Horohoe [Thu, 4 Aug 2011 22:33:04 +0000 (22:33 +0000)]
Fixes for r92251:
* Move Imagick check into getImageWriteMethod(), adjust exception catching. Previously this was bailing on the test if you have convert but not the PHP Imagick extension. Now all these tests are passing for me again.
* Rm unused member variable, whitespace, etc
Sam Reed [Thu, 4 Aug 2011 22:21:40 +0000 (22:21 +0000)]
st47 == Dan Collins
So might aswell just leave the real name credits
Sam Reed [Thu, 4 Aug 2011 22:20:52 +0000 (22:20 +0000)]
* (bug 17119) class Parser: senseless use of non-existing regexp back reference
Patch made by Dan Collins,, based on text placed by "seth"
Chad Horohoe [Thu, 4 Aug 2011 22:06:05 +0000 (22:06 +0000)]
Followup r93921: missed something from testing
Chad Horohoe [Thu, 4 Aug 2011 21:54:45 +0000 (21:54 +0000)]
Move UNORM_ related defines inside of UtfNormal. $globalScope--;
Ian Baker [Thu, 4 Aug 2011 21:19:08 +0000 (21:19 +0000)]
Fixed bug where global wgUploadStashMaxAge wasn't used, removed redundant defaults. Followup to r93476
Chad Horohoe [Thu, 4 Aug 2011 21:04:59 +0000 (21:04 +0000)]
Self-revert r91453: not a well thought out addition to the EditPage::showEditForm:initial hook
Chad Horohoe [Thu, 4 Aug 2011 21:00:40 +0000 (21:00 +0000)]
Followup r88270: comment out globals so I can resolve the fixme. Throw an exception here so nobody tries using it anyway
Aaron Schulz [Thu, 4 Aug 2011 20:57:20 +0000 (20:57 +0000)]
Reverted r91548 per CR
Chad Horohoe [Thu, 4 Aug 2011 20:55:20 +0000 (20:55 +0000)]
Remove no-op initialise from configuration. Nothing outside of Ext:Configure needs/uses it
Ian Baker [Thu, 4 Aug 2011 20:52:40 +0000 (20:52 +0000)]
Adding new jquery plugins to Resources.php so they'll be available through ResourceLoader, followup to r93908
Ian Baker [Thu, 4 Aug 2011 20:43:58 +0000 (20:43 +0000)]
Adding jquery plugins that UploadWizard and jQueryMsg need for Jasmine tests
Sam Reed [Thu, 4 Aug 2011 20:04:09 +0000 (20:04 +0000)]
* (bug 30230) action=expandtemplates should not silently override invalid title inputs
Aaron Schulz [Thu, 4 Aug 2011 17:43:06 +0000 (17:43 +0000)]
Added filearchive check to isInactiveAccount()
Alexandre Emsenhuber [Thu, 4 Aug 2011 15:48:36 +0000 (15:48 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Roan Kattouw [Thu, 4 Aug 2011 15:13:17 +0000 (15:13 +0000)]
Expand all URLs in e-mail notifications to be full HTTP URLs. This prevents protocol-relative URLs from appearing in e-mail notifications if $wgServer is protocol-relative
Mark A. Hershberger [Thu, 4 Aug 2011 14:25:53 +0000 (14:25 +0000)]
re r93871 — add release notes
Raimond Spekking [Thu, 4 Aug 2011 13:28:09 +0000 (13:28 +0000)]
Localisation update for core and extension messages from translatewiki.net (2011-08-04 12:30:00)
Roan Kattouw [Thu, 4 Aug 2011 12:13:01 +0000 (12:13 +0000)]
Fix embarassing debugging code left in in r93744
Krinkle [Thu, 4 Aug 2011 05:44:52 +0000 (05:44 +0000)]
Removing left-over comment from r67733.
Mark A. Hershberger [Thu, 4 Aug 2011 00:57:43 +0000 (00:57 +0000)]
Fix bug #27132: Uncomment movefile right in default settings
Aaron Schulz [Wed, 3 Aug 2011 22:37:20 +0000 (22:37 +0000)]
* Refactored SpecialUndelete::revDeleteLink into a Linker::getRevDeleteLink function
* (bug 21279) Updated DeletedContributions to use type=revision when possible (ar_rev_id exists)
Aaron Schulz [Wed, 3 Aug 2011 22:08:24 +0000 (22:08 +0000)]
Reverted r91942,r91943,r91949,r92156 per CR
Platonides [Wed, 3 Aug 2011 20:23:10 +0000 (20:23 +0000)]
r93683 missed return in line 1890
Alexandre Emsenhuber [Wed, 3 Aug 2011 19:59:33 +0000 (19:59 +0000)]
Just call $wgOut->parse() instead of doing a lot of things to call $wgParser->parse()
Alexandre Emsenhuber [Wed, 3 Aug 2011 19:42:34 +0000 (19:42 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Platonides [Wed, 3 Aug 2011 18:25:04 +0000 (18:25 +0000)]
Follow-up r93258, r93266, r93266: Move the defines to Defines.php
Alexandre Emsenhuber [Wed, 3 Aug 2011 17:19:32 +0000 (17:19 +0000)]
Call Linker methods statically
Mark A. Hershberger [Wed, 3 Aug 2011 15:46:06 +0000 (15:46 +0000)]
* Make envCheckPath() specific to each installer, web vs cli
* Add warning during the CLI install that the uploads directory isn't
being checked for arbitrary script execution
Mark A. Hershberger [Wed, 3 Aug 2011 14:25:20 +0000 (14:25 +0000)]
re: r93635
* Restore false from envCheckPath() if wgScriptPath isn't found.
* Add message showing complete URL for wiki.
Krinkle [Wed, 3 Aug 2011 13:46:41 +0000 (13:46 +0000)]
Correct typo in function documentation.
* Follows-up r93702 CR
Roan Kattouw [Wed, 3 Aug 2011 13:12:55 +0000 (13:12 +0000)]
Fix syntax error in r93820
Roan Kattouw [Wed, 3 Aug 2011 13:11:42 +0000 (13:11 +0000)]
Fix r93820: PROT_ -> PROTO_
Roan Kattouw [Wed, 3 Aug 2011 12:58:21 +0000 (12:58 +0000)]
Some random URL protocol forcing for protocol-relative URLs
Roan Kattouw [Wed, 3 Aug 2011 12:52:17 +0000 (12:52 +0000)]
Followup r93266: also rename PROT_* to PROTO_* in the comments
Roan Kattouw [Wed, 3 Aug 2011 12:00:47 +0000 (12:00 +0000)]
Introduce $wgVaryOnXFPToAPI which sends Vary: X-Forwarded-Proto (and the appropriate XVO, if needed) on cached API requests. This effectively splits the API cache between HTTP and HTTPS for people with an HTTPS termination setup in front of a caching proxy (like, say, WMF)
Krinkle [Wed, 3 Aug 2011 11:59:11 +0000 (11:59 +0000)]
Fix noglobals exceptions from QUnit
* Test results prior to this commit: http://i.imgur.com/m8rbk.png
* http://localhost/trunkw/tests/qunit/?noglobals=1
- Missing var-statement, causes global scope implication
- Missing semi colon, causing next to be global
Domas Mituzas [Wed, 3 Aug 2011 08:00:23 +0000 (08:00 +0000)]
removing a comment that doesn't make any sense after r91441 refactoring :-)
Roan Kattouw [Wed, 3 Aug 2011 07:54:23 +0000 (07:54 +0000)]
Revert r93802 per CR. Will avoid cache pollution by splitting the cache instead
Krinkle [Wed, 3 Aug 2011 07:45:54 +0000 (07:45 +0000)]
Follows-up r89848 CR: Cleaner solution
Rotem Liss [Wed, 3 Aug 2011 07:33:00 +0000 (07:33 +0000)]
In the protection form, show the current protection expiry time in the local time and not in UTC.
Roan Kattouw [Wed, 3 Aug 2011 07:05:21 +0000 (07:05 +0000)]
Followup r92044: force HTTP on URLs output by the API, now that wfExpandUrl() has a flag for this
Sam Reed [Wed, 3 Aug 2011 00:19:27 +0000 (00:19 +0000)]
Tweak/add to documentation
Remove old compat constants for "1.6 compatibility"
Chad Horohoe [Tue, 2 Aug 2011 23:16:44 +0000 (23:16 +0000)]
w/s fix for r92882
Chad Horohoe [Tue, 2 Aug 2011 22:01:58 +0000 (22:01 +0000)]
(bug 30172) posix_isatty() fallback does not work when the function has been disabled (but exists). While we're at it, make things work for HipHop too.
Neil Kandalgaonkar [Tue, 2 Aug 2011 21:00:00 +0000 (21:00 +0000)]
eliminates warning if no startUp defined, which can happen in testing. (with proper case, capital U, this time)
Neil Kandalgaonkar [Tue, 2 Aug 2011 20:57:51 +0000 (20:57 +0000)]
reverting r93783 - got the case of the variable name wrong
Neil Kandalgaonkar [Tue, 2 Aug 2011 20:54:30 +0000 (20:54 +0000)]
eliminates warning if no startUp defined, which can happen in testing.
Neil Kandalgaonkar [Tue, 2 Aug 2011 20:51:20 +0000 (20:51 +0000)]
break dependency on utility functions isEmpty & isDefined
Neil Kandalgaonkar [Tue, 2 Aug 2011 20:33:27 +0000 (20:33 +0000)]
moving URI library to main resources
Neil Kandalgaonkar [Tue, 2 Aug 2011 20:17:13 +0000 (20:17 +0000)]
added a few comments about noAuth
Mark A. Hershberger [Tue, 2 Aug 2011 19:35:01 +0000 (19:35 +0000)]
re: r93415
* Document what happens as the result of each value returned
* Require boolean true to continue, not just a true value or strings
would succeed
* Trim the arguments since the header array already contains them.
Alexandre Emsenhuber [Tue, 2 Aug 2011 16:31:22 +0000 (16:31 +0000)]
Per Platonides, follow-up r93758: rename ParserOutput::addOutputPage() to ParserOutput::addOutputPageMetadata() to match its behaviour
Sam Reed [Tue, 2 Aug 2011 16:26:15 +0000 (16:26 +0000)]
Fix minor naming issue from r93314, add a bit to parameter documentation also
Platonides [Tue, 2 Aug 2011 16:23:46 +0000 (16:23 +0000)]
Follow up r93633. Allow only classic spaces.
Sam Reed [Tue, 2 Aug 2011 16:18:10 +0000 (16:18 +0000)]
Revert r93688 per Platonides
Roan Kattouw [Tue, 2 Aug 2011 16:00:42 +0000 (16:00 +0000)]
In ResourceLoaderWikiModule, use isCssOrJsPage() as well as isCssJsSubpage() to check whether a wiki page is a CSS or JS page. This is required to make ResourceLoaderWikiModule work for pages that are CSS/JS pages, but don't live in the MediaWiki namespace and aren't user subpages. This wasn't possible before r93759, which introduced a hook that allows extensions to override which pages are considered to be CSS/JS pages.
Roan Kattouw [Tue, 2 Aug 2011 15:47:30 +0000 (15:47 +0000)]
Factor out obtaining the database object in ResourceLoaderWikiModule into a getDB() method that can be overridden by subclasses. This is needed for the Gadgets extension in the RL2 branch, which subclasses ResourceLoaderWikiModule to create modules for foreign wiki pages.
Roan Kattouw [Tue, 2 Aug 2011 15:40:27 +0000 (15:40 +0000)]
Introduce a hook so extensions can customize what's considered to be a CSS/JS page. This is needed for the Gadgets extension in the RL2 branch
Alexandre Emsenhuber [Tue, 2 Aug 2011 15:40:03 +0000 (15:40 +0000)]
* (bug 15558) Allow includable special pages to be parameterized using wiki syntax
* Changed SpecialPageFactory::capturePath() to take the same parameters as SpecialPageFactory::executePath() (except the last one) and made it always return a bool instead of bool-or-string. The result HTML can be fetched from the OutputPage object of the context.
* Added module styles, scritps and messages members to ParserOutput in addition to modules. The first one is needed to display Special:RecentChanges correctly when transcluded since EnhancedChangesList::beginRecentChangesList() calls addModuleStyles( 'mediawiki.special.changeslist' )
Yes, this means that you can use {{Special:Recentchanges|enhanced=0}} to use the old changes list. For the ones that wonder, {{Special:Recentchanges|uselang=something}} will not work since the Language object is forced to the one used by the parser.
Mark A. Hershberger [Tue, 2 Aug 2011 14:27:48 +0000 (14:27 +0000)]
Fixes Bug #29311 - [OutputPage] Create a method to remove items from mModules
Patch from John Du Hart, reviewed by Roan, Applying at Roan's request.
Brion Vibber [Tue, 2 Aug 2011 14:13:51 +0000 (14:13 +0000)]
* $wgSVGMaxSize is now applied to the smaller of width or height, making very wide pano/timeline/diagram SVGs renderable at saner sizes