From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Mon, 1 Apr 2013 17:18:15 +0000 (+0200)
Subject: Remove unneeded else{} and return
X-Git-Tag: 1.31.0-rc.0~20148^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22suivi_revisions%22%29%20.%20%22?a=commitdiff_plain;h=aab4d394effc79c2de98ebea4bb1db101b390d8a;p=lhc%2Fweb%2Fwiklou.git

Remove unneeded else{} and return

Else action was default. Returned the result of a void function.

Change-Id: I9ddf051ded0228dd3dfdfe9312f467d9c57f1716
---

diff --git a/includes/api/ApiUpload.php b/includes/api/ApiUpload.php
index 2dcf39204d..719032f2ce 100644
--- a/includes/api/ApiUpload.php
+++ b/includes/api/ApiUpload.php
@@ -444,9 +444,9 @@ class ApiUpload extends ApiBase {
 		$verification = $this->mUpload->verifyUpload();
 		if ( $verification['status'] === UploadBase::OK ) {
 			return;
-		} else {
-			return $this->checkVerification( $verification );
 		}
+
+		$this->checkVerification( $verification );
 	}
 
 	/**
@@ -455,7 +455,7 @@ class ApiUpload extends ApiBase {
 	protected function checkVerification( array $verification ) {
 		global $wgFileExtensions;
 
-		// TODO: Move them to ApiBase's message map
+		// @todo Move them to ApiBase's message map
 		switch( $verification['status'] ) {
 			// Recoverable errors
 			case UploadBase::MIN_LENGTH_PARTNAME: