From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 25 Jun 2014 01:58:49 +0000 (-0700)
Subject: Removed redundant begin/commit calls
X-Git-Tag: 1.31.0-rc.0~15215^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22suivi_revisions%22%29%20.%20%22?a=commitdiff_plain;h=3cb34a96adf7864677eb8aa8d2172554b48a537d;p=lhc%2Fweb%2Fwiklou.git

Removed redundant begin/commit calls

* onTransactionIdle() callbacks already run in auto-commit mode.

Change-Id: I1eab5953080fe28fe58d7a75f88612c591db6e9a
---

diff --git a/includes/UserMailer.php b/includes/UserMailer.php
index d3e8cb8f72..d73f6b403a 100644
--- a/includes/UserMailer.php
+++ b/includes/UserMailer.php
@@ -544,7 +544,6 @@ class EmailNotification {
 				$fname = __METHOD__;
 				$dbw->onTransactionIdle(
 					function() use ( $dbw, $timestamp, $watchers, $title, $fname ) {
-						$dbw->begin( $fname );
 						$dbw->update( 'watchlist',
 							array( /* SET */
 								'wl_notificationtimestamp' => $dbw->timestamp( $timestamp )
@@ -554,7 +553,6 @@ class EmailNotification {
 								'wl_title' => $title->getDBkey(),
 							), $fname
 						);
-						$dbw->commit( $fname );
 					}
 				);
 			}