From: Derick Alangi <alangiderick@gmail.com>
Date: Mon, 15 Apr 2019 20:33:18 +0000 (+0100)
Subject: changetags: $param type should be string and not array
X-Git-Tag: 1.34.0-rc.0~1946^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22suivi_revisions%22%29%20.%20%22?a=commitdiff_plain;h=11200fc58e6e4ccf322948ae4e2471dc20c4ae59;p=lhc%2Fweb%2Fwiklou.git

changetags: $param type should be string and not array

Per the call to updateTagsWithChecks(), $params should be a string
and not an array as soft type hinted. The previous calls updateTags()
which uses $param as a string or null.

Change-Id: I87fa39682d91b7cb3b0844d0aabbfaea0cb6f206
---

diff --git a/includes/changetags/ChangeTags.php b/includes/changetags/ChangeTags.php
index 3a93e57611..2169a4d72e 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -604,7 +604,7 @@ class ChangeTags {
 	 * @param int|null $rc_id The rc_id of the change to add the tags to
 	 * @param int|null $rev_id The rev_id of the change to add the tags to
 	 * @param int|null $log_id The log_id of the change to add the tags to
-	 * @param string $params Params to put in the ct_params field of table
+	 * @param string|null $params Params to put in the ct_params field of table
 	 * 'change_tag' when adding tags
 	 * @param string $reason Comment for the log
 	 * @param User $user Who to give credit for the action
diff --git a/includes/changetags/ChangeTagsLogList.php b/includes/changetags/ChangeTagsLogList.php
index 7e1f1d1e30..bf455af817 100644
--- a/includes/changetags/ChangeTagsLogList.php
+++ b/includes/changetags/ChangeTagsLogList.php
@@ -66,7 +66,7 @@ class ChangeTagsLogList extends ChangeTagsList {
 	 *
 	 * @param array $tagsToAdd
 	 * @param array $tagsToRemove
-	 * @param array $params
+	 * @param string|null $params
 	 * @param string $reason
 	 * @param User $user
 	 * @return Status