Fix a usability issue on protect and [file ]delete forms. "Edit ... reasons" link...

diff --git a/includes/Article.php b/includes/Article.php
index 033ecfc..ac038dd 100644 (file)
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -2469,7 +2469,13 @@ class Article {
 
                        if( $wgUser->isAllowed( 'editinterface' ) ) {
                                $skin = $wgUser->getSkin();
-                               $link = $skin->makeLink ( 'MediaWiki:Deletereason-dropdown', wfMsgHtml( 'delete-edit-reasonlist' ) );
+                               $title = Title::newFromText( 'Deletereason-dropdown', NS_MEDIAWIKI );
+                               $link = $skin->link(
+                                       $title,
+                                       wfMsgHtml( 'delete-edit-reasonlist' ),
+                                       array(),
+                                       array( 'action' => 'edit' )
+                               );
                                $form .= '<p class="mw-delete-editreasons">' . $link . '</p>';
                        }
 

diff --git a/includes/FileDeleteForm.php b/includes/FileDeleteForm.php
index 5177d35..9491fd2 100644 (file)
--- a/includes/FileDeleteForm.php
+++ b/includes/FileDeleteForm.php
@@ -194,7 +194,13 @@ class FileDeleteForm {
 
                        if ( $wgUser->isAllowed( 'editinterface' ) ) {
                                $skin = $wgUser->getSkin();
-                               $link = $skin->makeLink ( 'MediaWiki:Filedelete-reason-dropdown', wfMsgHtml( 'filedelete-edit-reasonlist' ) );
+                               $title = Title::newFromText( 'filedelete-reason-dropdown', NS_MEDIAWIKI );
+                               $link = $skin->link(
+                                       $title,
+                                       wfMsgHtml( 'filedelete-edit-reasonlist' ),
+                                       array(),
+                                       array( 'action' => 'edit' )
+                               );
                                $form .= '<p class="mw-filedelete-editreasons">' . $link . '</p>';
                        }
 

diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index ce7bf54..ec23046 100644 (file)
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -447,8 +447,13 @@ class ProtectionForm {
                $out .= Xml::closeElement( 'fieldset' );
 
                if ( $wgUser->isAllowed( 'editinterface' ) ) {
-                       $linkTitle = Title::makeTitleSafe( NS_MEDIAWIKI, 'protect-dropdown' );
-                       $link = $wgUser->getSkin()->Link ( $linkTitle, wfMsgHtml( 'protect-edit-reasonlist' ) );
+                       $title = Title::newFromText( 'protect-dropdown', NS_MEDIAWIKI );
+                       $link = $wgUser->getSkin()->link(
+                               $title,
+                               wfMsgHtml( 'protect-edit-reasonlist' ),
+                               array(),
+                               array( 'action' => 'edit' )
+                       );
                        $out .= '<p class="mw-protect-editreasons">' . $link . '</p>';
                }