Merge "mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 15 Dec 2017 00:26:44 +0000 (00:26 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 15 Dec 2017 00:26:45 +0000 (00:26 +0000)
1  2 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js

        mw.rcfilters.ui.MenuSelectWidget.prototype.toggle = function ( show ) {
                this.lazyMenuCreation();
                mw.rcfilters.ui.MenuSelectWidget.parent.prototype.toggle.call( this, show );
+               // Always open this menu downwards. FilterTagMultiselectWidget scrolls it into view.
+               this.setVerticalPosition( 'below' );
        };
  
        /**
         */
        mw.rcfilters.ui.MenuSelectWidget.prototype.onKeyDown = function ( e ) {
                var nextItem,
 -                      currentItem = this.getHighlightedItem() || this.getSelectedItem();
 +                      currentItem = this.findHighlightedItem() || this.getSelectedItem();
  
                // Call parent
                mw.rcfilters.ui.MenuSelectWidget.parent.prototype.onKeyDown.call( this, e );