* MySQL 5.0 strict mode fix for moving unwatched pages

It was doing an empty REPLACE, which apparently is unpopular.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 9ce790b..e132b2f 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -180,6 +180,7 @@ fully support the editing toolbar, but was found to be too confusing.
 * Fail gracefully on invalid namespace in Special:Newpages
 * (bug 3806) Gracefully fall back to client-side scaling on |thumb| image
   that passes $wgMaxImageArea
+* MySQL 5.0 strict mode fix for moving unwatched pages
 
 
 === Caveats ===

diff --git a/includes/WatchedItem.php b/includes/WatchedItem.php
index fbbc366..2b01a31 100644 (file)
--- a/includes/WatchedItem.php
+++ b/includes/WatchedItem.php
@@ -160,6 +160,11 @@ class WatchedItem {
                        );
                }
                $dbw->freeResult( $res );
+               
+               if( empty( $values ) ) {
+                       // Nothing to do
+                       return true;
+               }
 
                # Perform replace
                # Note that multi-row replace is very efficient for MySQL but may be inefficient for