Merge "Watchlist preferences: Disallow zero value for days/limit"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 6 Sep 2018 19:04:45 +0000 (19:04 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 6 Sep 2018 19:04:45 +0000 (19:04 +0000)
includes/preferences/DefaultPreferencesFactory.php

index 07d8b0b..ec85556 100644 (file)
@@ -1123,7 +1123,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
 
                $defaultPreferences['watchlistdays'] = [
                        'type' => 'float',
-                       'min' => 0,
+                       'min' => 1 / 24,
                        'max' => $watchlistdaysMax,
                        'section' => 'watchlist/displaywatchlist',
                        'help' => $context->msg( 'prefs-watchlist-days-max' )->numParams(
@@ -1132,7 +1132,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
                ];
                $defaultPreferences['wllimit'] = [
                        'type' => 'int',
-                       'min' => 0,
+                       'min' => 1,
                        'max' => 1000,
                        'label-message' => 'prefs-watchlist-edits',
                        'help' => $context->msg( 'prefs-watchlist-edits-max' )->escaped(),