Minor tweak to performUpload in UploadBase.php

Only do one call to $status->isGood() and nest if $watch check in that

diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php
index 8e0f7a3..94fda9b 100644 (file)
--- a/includes/upload/UploadBase.php
+++ b/includes/upload/UploadBase.php
@@ -390,11 +390,11 @@ abstract class UploadBase {
                $status = $this->getLocalFile()->upload( $this->mTempPath, $comment, $pageText,
                        File::DELETE_SOURCE, $this->mFileProps, false, $user );
 
-               if( $status->isGood() && $watch ) {
-                       $user->addWatch( $this->getLocalFile()->getTitle() );
-               }
-
                if( $status->isGood() ) {
+                       if ( $watch ) {
+                               $user->addWatch( $this->getLocalFile()->getTitle() );
+                       }
+
                        wfRunHooks( 'UploadComplete', array( &$this ) );
                }