Improve code suffering from PHP 5.3's lack of support for foo()[]
authorBartosz Dziewoński <matma.rex@gmail.com>
Wed, 17 Feb 2016 19:54:59 +0000 (20:54 +0100)
committerBartosz Dziewoński <matma.rex@gmail.com>
Sun, 28 Feb 2016 21:49:20 +0000 (22:49 +0100)
commitc161c46d26c24643d7fced554ab6e45fb8ec7529
treef60e182ab397f8065638e2e638f9359d363ea528
parent1b7b3c452f6a4f6cd1012e3f85e8c3b8cea05a29
Improve code suffering from PHP 5.3's lack of support for foo()[]

I searched for /\$(\S+) = (.+?\(.*?\);)\n.*?\$\1\[/, ignored
everything involving isset(), unset() or array assigments, then
skimmed through the remaining results and changed things where they
made sense. These changes were not automated, so please review them.

Change-Id: Ib37b4c66fc57648470f151ad412210b3629c2538
28 files changed:
includes/Block.php
includes/EditPage.php
includes/GlobalFunctions.php
includes/api/ApiBase.php
includes/api/ApiOpenSearch.php
includes/db/Database.php
includes/db/DatabaseMssql.php
includes/filebackend/FSFileBackend.php
includes/installer/Installer.php
includes/jobqueue/JobQueueFederated.php
includes/jobqueue/JobRunner.php
includes/libs/MultiHttpClient.php
includes/libs/RiffExtractor.php
includes/libs/objectcache/MemcachedClient.php
includes/libs/virtualrest/RestbaseVirtualRESTService.php
includes/libs/virtualrest/VirtualRESTServiceClient.php
includes/media/ExifBitmap.php
includes/media/GIFMetadataExtractor.php
includes/media/PNGMetadataExtractor.php
includes/page/Article.php
includes/parser/Parser.php
includes/search/SearchPostgres.php
includes/skins/SkinTemplate.php
languages/ConverterRule.php
languages/Language.php
languages/LanguageConverter.php
maintenance/tidyUpBug37714.php
tests/testHelpers.inc