From ed22b3640725a56e99f22e21ae0e4c588fa74a49 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Fri, 18 Sep 2009 04:26:30 +0000 Subject: [PATCH] Use STDERR instead of fopen('php://stderr') when possible --- maintenance/Maintenance.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php index 452acf4772..27da73e02e 100644 --- a/maintenance/Maintenance.php +++ b/maintenance/Maintenance.php @@ -225,9 +225,13 @@ abstract class Maintenance { * @param $die boolean If true, go ahead and die out. */ protected function error( $err, $die = false ) { - $f = fopen( 'php://stderr', 'w' ); - fwrite( $f, $err . "\n" ); - fclose( $f ); + if ( php_sapi_name() == 'cli' ) { + fwrite( STDERR, $err . "\n" ); + } else { + $f = fopen( 'php://stderr', 'w' ); + fwrite( $f, $err . "\n" ); + fclose( $f ); + } if( $die ) die(); } -- 2.20.1