From dfc8f4766f2fedf72b9b11ccd1e67548a7b6d053 Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Tue, 9 Jan 2018 10:15:06 -0500 Subject: [PATCH] RCFilters: uriprocessor test: use hardcoded uri new mw.Uri() without arguments uses the current browser uri. It caused some tests to fail when run from a uri with a subpage (Special:JavaScriptTest/qunit) and it's generally bad to have unit tests use uncontrolled environment data. Change-Id: Id434a491aadc2d84165edf4fd1c59775c9b815ad --- .../suites/resources/mediawiki.rcfilters/UriProcessor.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js b/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js index fbd159cbb1..654e66ba49 100644 --- a/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js +++ b/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js @@ -62,7 +62,7 @@ var uriProcessor, filtersModel = new mw.rcfilters.dm.FiltersViewModel(), makeUri = function ( queryParams ) { - var uri = new mw.Uri(); + var uri = new mw.Uri( 'http://server/wiki/Special:RC' ); uri.query = queryParams; return uri; }; -- 2.20.1