jenkins-bot [Mon, 3 Dec 2018 13:39:18 +0000 (13:39 +0000)]
Merge "block: Fix PHPDoc comments to match function signature (or method)"
jenkins-bot [Mon, 3 Dec 2018 12:45:28 +0000 (12:45 +0000)]
Merge "debug: Correct $level PHPDoc param datatype in SyslogHandler.php"
Alangi Derick [Mon, 3 Dec 2018 11:25:33 +0000 (12:25 +0100)]
export: Fix return value of write() function in DumpOutput.php
Per http://php.net/manual/en/function.print.php, print always returns
1 (integer value of one) but write() doesn't actually return this value
to it's caller. So "@return bool" in this case doesn't make sense as
one will think it's returning a bool type. `write()` only takes a string
and prints it, and if we really want to return it's value (in this case),
it will be "@return int" not data of type bool.
Change-Id: I45b4a157cde2f768d77dda76d6ae0caa47e28f20
Alangi Derick [Mon, 3 Dec 2018 11:00:49 +0000 (12:00 +0100)]
debug: Correct $level PHPDoc param datatype in SyslogHandler.php
In Monolog\Logger (Logger.php), the logger levels are constants (interger values).
Logger::DEBUG is a constant (int) with value 100 which depicts that error logging
level. Datatype of these values; DEBUG, INFO, WARNING, etc are all integers not
strings.
Change-Id: I1cc67381bc64800241f5f9b7232ffe5419388d8a
Alangi Derick [Mon, 3 Dec 2018 09:48:29 +0000 (10:48 +0100)]
block: Fix PHPDoc comments to match function signature (or method)
- Add @param annotation for $row to newFromRow() method in Restriction
interface declaration.
- Remove @param annotation for $option not used in loadByBlockId() method
signature.
Change-Id: Iec49b9541ea06da9f497e45bd35df26f8124aecf
jenkins-bot [Mon, 3 Dec 2018 05:10:26 +0000 (05:10 +0000)]
Merge "Delete always true condition"
James D. Forrester [Fri, 4 May 2018 18:39:47 +0000 (11:39 -0700)]
mediawiki.util: Drop jsMessage(), deprecated since 1.20 and mostly unused
This also means that mediawiki.notify is no longer loaded.
Bug: T193901
Change-Id: Ifa222ca05ec913c140284ee0113c0d7827215130
jenkins-bot [Mon, 3 Dec 2018 01:57:50 +0000 (01:57 +0000)]
Merge "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action""
Legoktm [Mon, 3 Dec 2018 00:12:19 +0000 (00:12 +0000)]
Revert "Title::checkUserBlock should call User::isBlockedFrom for every action"
This reverts commit
b1e4ca70b8e375d52c35b46fb3157fb852948263.
Introduced a breaking change, and didn't follow the deprecation policy.
Bug: T210953
Change-Id: I11806165912d9188261d3c4c37dbae5cfd2865ec
Translation updater bot [Sun, 2 Dec 2018 20:53:50 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6e2615bdd5a2aa9be73317d83770e61bc2b6b450
Jakub Vrana [Sun, 2 Dec 2018 18:28:11 +0000 (19:28 +0100)]
Delete always true condition
The typehint doesn't allow null here.
Found by PHPStan.
Change-Id: I3e30bf49e778c42e8313a5b6de3d943ed7002c81
Jakub Vrana [Sun, 2 Dec 2018 08:59:17 +0000 (09:59 +0100)]
Delete always-true condition
Found by PHPStan.
Change-Id: Ibefd9d5d1b374448650a36702db18144f5feddae
jenkins-bot [Sun, 2 Dec 2018 01:50:14 +0000 (01:50 +0000)]
Merge "Use our fork of less.php"
jenkins-bot [Sun, 2 Dec 2018 01:28:26 +0000 (01:28 +0000)]
Merge "Add $wgReauthenticateTime to extension.json"
jenkins-bot [Sun, 2 Dec 2018 00:30:03 +0000 (00:30 +0000)]
Merge "SpecialRevisiondelete: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:25:43 +0000 (00:25 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:25:37 +0000 (00:25 +0000)]
Merge "Do not pass unused parameter"
Max Semenik [Tue, 16 Oct 2018 07:00:30 +0000 (00:00 -0700)]
Use our fork of less.php
Supports PHP 7.3, among other things
Bug: T206975
Depends-On: I06f1e43b0f12f9b56f9dff55a92b5ae4546acfcc
Change-Id: I84c5ed8ac0ae1c382ba035b37dc88ccd69494ac3
jenkins-bot [Sun, 2 Dec 2018 00:22:39 +0000 (00:22 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:22:34 +0000 (00:22 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:20:08 +0000 (00:20 +0000)]
Merge "RedisBagOStuff: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:18:23 +0000 (00:18 +0000)]
Merge "Remove duplicate keys from arrays"
jenkins-bot [Sun, 2 Dec 2018 00:18:18 +0000 (00:18 +0000)]
Merge "media: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:11:45 +0000 (00:11 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:11:40 +0000 (00:11 +0000)]
Merge "export: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:11:35 +0000 (00:11 +0000)]
Merge "rdbms: Pass required parameter"
Jakub Vrana [Sat, 1 Dec 2018 16:53:12 +0000 (17:53 +0100)]
SpecialRevisiondelete: Do not pass unused parameter
Found by PHPStan.
Change-Id: Iba7020f6bf793e525b4d82c286064d05609eef2f
jenkins-bot [Sun, 2 Dec 2018 00:00:53 +0000 (00:00 +0000)]
Merge "Remove unused use in anonymous function"
jenkins-bot [Sun, 2 Dec 2018 00:00:48 +0000 (00:00 +0000)]
Merge "Remove unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:00:43 +0000 (00:00 +0000)]
Merge "Use correct letter case"
jenkins-bot [Sun, 2 Dec 2018 00:00:38 +0000 (00:00 +0000)]
Merge "Remove unused use in anonymous function"
jenkins-bot [Sun, 2 Dec 2018 00:00:32 +0000 (00:00 +0000)]
Merge "Change typehint callback to callable"
jenkins-bot [Sun, 2 Dec 2018 00:00:27 +0000 (00:00 +0000)]
Merge "Change typehint callback to callable"
Jakub Vrana [Sat, 1 Dec 2018 16:51:45 +0000 (17:51 +0100)]
RedisBagOStuff: Do not pass unused parameter
Found by PHPStan.
Change-Id: I20fe8ca713362d115d620a22e04c5dc984ae279e
Jakub Vrana [Sat, 1 Dec 2018 16:48:35 +0000 (17:48 +0100)]
media: Do not pass unused parameter
FileRepo::getHashPath() takes a $name parameter, but File::getHashPath()
doesn't.
Found by PHPStan.
Change-Id: I9cbcfd206249f4be7b50f2b104c797606bc4406a
Jakub Vrana [Sat, 1 Dec 2018 16:43:51 +0000 (17:43 +0100)]
export: Do not pass unused parameter
Found by PHPStan.
Change-Id: I0e4971a3d5a4170ada776cd88ea664806f23c6ed
Jakub Vrana [Sat, 1 Dec 2018 16:40:47 +0000 (17:40 +0100)]
rdbms: Pass required parameter
Found by PHPStan.
Change-Id: I8fbb64f7b5058b36381bccd5bc6a9d095b9ace15
jenkins-bot [Sat, 1 Dec 2018 23:45:23 +0000 (23:45 +0000)]
Merge "Remove unused use in anonymous function"
Fomafix [Mon, 26 Nov 2018 05:34:04 +0000 (06:34 +0100)]
InfoAction: Add missing @param type
null is explicit supported and in use.
Change-Id: I495ca2eacb5359c8bf88c094db39fa44ca5866e1
Fomafix [Sun, 18 Nov 2018 17:33:45 +0000 (18:33 +0100)]
WebInstallerUpgrade: Simplify return paths
* Avoid else after return.
* Combine redundant return values.
Change-Id: If87f5b2163abc7867ce83081aa6ab9e358869060
Translation updater bot [Sat, 1 Dec 2018 20:53:32 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I849a483d1800b2b580f64d05f3f12453afbf7549
MarcoAurelio [Sat, 1 Dec 2018 15:18:07 +0000 (16:18 +0100)]
Fix typo 'defintion'
Bug: T201491
Change-Id: I2b6b87761e6e01b982feaccd98f08f66a1888a16
jenkins-bot [Sat, 1 Dec 2018 19:28:11 +0000 (19:28 +0000)]
Merge "Fix return typehint"
jenkins-bot [Sat, 1 Dec 2018 19:28:05 +0000 (19:28 +0000)]
Merge "Remove unused use in anonymous function"
jenkins-bot [Sat, 1 Dec 2018 18:49:27 +0000 (18:49 +0000)]
Merge "Use correct letter case"
Jakub Vrana [Sat, 1 Dec 2018 17:09:58 +0000 (18:09 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I4a73279b6956b9819e609536ae6774872f1736f4
Jakub Vrana [Sat, 1 Dec 2018 17:08:56 +0000 (18:08 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I6c33aa29af02b7a5ca01e2e20103e4a873cb722a
Jakub Vrana [Sat, 1 Dec 2018 17:08:04 +0000 (18:08 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I48a613d94624ef4f8c533b98b8c128b4cc9c47f5
Jakub Vrana [Sat, 1 Dec 2018 17:04:44 +0000 (18:04 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: Icf9f1c87ff2690b7a16c99418cdb1dae9d97ce25
Jakub Vrana [Sat, 1 Dec 2018 16:46:07 +0000 (17:46 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I760e7382931ac00317319bee5223b0230b24bb7d
Jakub Vrana [Sat, 1 Dec 2018 16:33:21 +0000 (17:33 +0100)]
Remove unused parameter
Found by PHPStan.
Change-Id: I0480146fd7fce1d39db904f1c4b6dfa8314a74fe
jenkins-bot [Sat, 1 Dec 2018 15:47:22 +0000 (15:47 +0000)]
Merge "Changing "===" on secrets to hash_equals to protect from timing attacks."
Mogmog123 [Sat, 1 Dec 2018 01:25:06 +0000 (01:25 +0000)]
Changing "===" on secrets to hash_equals to protect from timing attacks.
Bug: T207777
Change-Id: I1e12ef94f455f96b4d70af27a315414500c709ab
jenkins-bot [Sat, 1 Dec 2018 10:50:18 +0000 (10:50 +0000)]
Merge "Message: Throw if given invalid serialized data"
jenkins-bot [Sat, 1 Dec 2018 10:49:38 +0000 (10:49 +0000)]
Merge "Message: Don't include Title objects in the serialization (part 1)"
Jakub Vrana [Sat, 1 Dec 2018 09:30:20 +0000 (10:30 +0100)]
Use correct letter case
Found by PHPStan.
Change-Id: I31619e0fb1819939b5b64ed01c6959668b86870c
Jakub Vrana [Sat, 1 Dec 2018 09:28:18 +0000 (10:28 +0100)]
Use correct letter case
Found by PHPStan.
Change-Id: Iaff53951e1e49b9bb99f7bf9da5a228765ead7f3
Jakub Vrana [Sat, 1 Dec 2018 09:17:34 +0000 (10:17 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: I88247514703820a6afb7c9861dcf64326aa32d19
Jakub Vrana [Sat, 1 Dec 2018 09:16:46 +0000 (10:16 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: I50d27a50806048697dcac8e24712a10a6c7e7c16
Jakub Vrana [Sat, 1 Dec 2018 09:13:38 +0000 (10:13 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: Id2dd9996fd4d78da930ee0cc802bb07b66a5f084
Jakub Vrana [Sat, 1 Dec 2018 09:12:32 +0000 (10:12 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: Ic00d2b7b42c7c75b673601eabe947b0f380a3399
Jakub Vrana [Sat, 1 Dec 2018 09:10:41 +0000 (10:10 +0100)]
Change typehint callback to callable
Found by PHPStan.
Change-Id: I09f21da69ad9b9357cee85a47717dbe1bca04070
Jakub Vrana [Sat, 1 Dec 2018 09:02:48 +0000 (10:02 +0100)]
Change typehint callback to callable
Found by PHPStan.
Change-Id: I77877a18131bd69996bad07f2ee1c5f3ba3ba2e7
Jakub Vrana [Sat, 1 Dec 2018 08:57:31 +0000 (09:57 +0100)]
Fix return typehint
Found by PHPStan.
Change-Id: Ia5280815f9dda25788de0438af1468adb8c915a6
Translation updater bot [Fri, 30 Nov 2018 20:54:20 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia2a54ab49aa88e2450c66e91385ecfaac29312ef
jenkins-bot [Fri, 30 Nov 2018 19:39:05 +0000 (19:39 +0000)]
Merge "Special:Preferences: Add example value as placeholder to timezone offset"
jenkins-bot [Fri, 30 Nov 2018 19:13:46 +0000 (19:13 +0000)]
Merge "Migrate Api modules from tag_summary table to change_tag"
Translation updater bot [Thu, 29 Nov 2018 21:04:07 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie38cd1c54843a40b6b366ae1945403df102516fe
Brad Jorsch [Wed, 28 Nov 2018 18:09:28 +0000 (13:09 -0500)]
Fix RevisionDeleteUser rev_actor query for MySQL
MySQL uses an extremely bad plan for the update with subquery here.
For the time being let's split out the subquery.
This'll break if the user has too many revision rows, but on the other
hand all the existing queries here will probably break in the same way
so let's leave that for later.
Bug: T210628
Change-Id: Ia3eb41b43b96c506349279e19743c41530969636
jenkins-bot [Thu, 29 Nov 2018 03:35:50 +0000 (03:35 +0000)]
Merge "build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass"
jenkins-bot [Thu, 29 Nov 2018 01:15:01 +0000 (01:15 +0000)]
Merge "Use ParserCache in CategoryMembershipChangeJob"
jenkins-bot [Thu, 29 Nov 2018 01:04:38 +0000 (01:04 +0000)]
Merge "Add stats for block errors on create/edit actions"
Volker E [Wed, 28 Nov 2018 23:31:18 +0000 (15:31 -0800)]
build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
Change-Id: I648375927bace5fc21bd842268c645570759ce85
jenkins-bot [Wed, 28 Nov 2018 23:52:05 +0000 (23:52 +0000)]
Merge "Drop ct_tag column from change_tag table"
jenkins-bot [Wed, 28 Nov 2018 23:52:00 +0000 (23:52 +0000)]
Merge "Drop $wgChangeTagsSchemaMigrationStage"
jenkins-bot [Wed, 28 Nov 2018 22:32:50 +0000 (22:32 +0000)]
Merge "Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW"
jenkins-bot [Wed, 28 Nov 2018 22:32:44 +0000 (22:32 +0000)]
Merge "SQLite: Split actor and comment filearchive updates to a separate file"
Amir Sarabadani [Wed, 14 Nov 2018 20:20:11 +0000 (21:20 +0100)]
Drop ct_tag column from change_tag table
Bug: T194163
Change-Id: I05d43510b51a67733b0107f0a768e261fe8ddabd
Amir Sarabadani [Wed, 14 Nov 2018 22:04:29 +0000 (23:04 +0100)]
Drop $wgChangeTagsSchemaMigrationStage
Bug: T194163
Change-Id: Ieb6cc60cacf9dd0d86641b1be817249cdce42112
jenkins-bot [Wed, 28 Nov 2018 19:55:12 +0000 (19:55 +0000)]
Merge "Add block notice stats on EditPage."
jenkins-bot [Wed, 28 Nov 2018 19:31:08 +0000 (19:31 +0000)]
Merge "Don't indicate partial blocks on Special:ActiveUsers"
Brad Jorsch [Wed, 7 Nov 2018 19:50:27 +0000 (14:50 -0500)]
Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW
WRITE_NEW mode seems to be working well on Wikimedia sites. Let's change
the default to MIGRATION_NEW so existing installs and Wikimedia CI will
start using the new code rather than the old.
This also fixes some unit tests that were broken with MIGRATION_NEW, and
updates some that were forcing MIGRATION_OLD to force MIGRATION_NEW
instead.
Bug: T166733
Change-Id: I7bf4ad0105dd1f6cc49eba3ddcb7a51badcd5ed3
Depends-On: I30f7cdcc3875f3f7af116c1e41e88f62ab9e91d0
Brad Jorsch [Wed, 28 Nov 2018 18:53:17 +0000 (13:53 -0500)]
SQLite: Split actor and comment filearchive updates to a separate file
On a fresh install, update.php will apply patch-editsummary-length.sql
even though it doesn't need to. But this partially wipes out the new schema from
tables.sql, and the omnibus comment and actor table patches don't detect
this, leading to filearchive missing the new fields.
Unlike the case with patch-add-3d.sql in I335cb8d9, here the patch does
make a change (if only a tiny one): fa_deleted_reason changes from TEXT
to BLOB.
Change-Id: I08047ff1207d471660365c0eb3faabc0b47746bb
Brad Jorsch [Wed, 28 Nov 2018 15:23:12 +0000 (10:23 -0500)]
Message: Don't include Title objects in the serialization (part 1)
Stringify the title instead. This will help avoid running into the
PHP/HHVM serialization incompatibility described in T210528.
This is part 1: start stringifying and using the string, but continue
storing the Title object for the benefit of mixed environments where
some servers still only handle a Title object.
Bug: T210528
Change-Id: I07aac3aab2d4e27a7203f4e4fb3ce1b5d86c517c
Brad Jorsch [Wed, 28 Nov 2018 15:25:01 +0000 (10:25 -0500)]
Message: Throw if given invalid serialized data
Instead of silently winding up with a bogus Message object having most
fields invalidly set to null, just throw an exception.
Bug: T210528
Change-Id: I79313f8acf3ebb1ef12dac30c362aa10c715f40b
Thalia [Mon, 26 Nov 2018 14:00:35 +0000 (14:00 +0000)]
Don't indicate partial blocks on Special:ActiveUsers
Only indicate sitewide blocks here.
Bug: T210391
Change-Id: I01d2fa6e326722d85652d96842e968c80d034274
Ed Sanders [Wed, 28 Nov 2018 11:29:58 +0000 (11:29 +0000)]
Fix typo in mw.Title test
Change-Id: I344515458a5760f93be2294c431b27c8afae46c5
Dayllan Maza [Fri, 16 Nov 2018 03:33:47 +0000 (22:33 -0500)]
Add stats for block errors on create/edit actions
Monitoring block errors is behind $wgEnableBlockNoticeStats
and it is disabled by default.
The reason behind this metric is to get an idea on how
frequently blocked users attempt to edit a page. Similar tracking
is being added to MobileFrontend and VisualEditor.
Depends-On: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
Bug: T201717
Change-Id: I18bdb5ce61509ba3c2cea9aa6247656b9bd388e0
Dayllan Maza [Thu, 8 Nov 2018 04:03:53 +0000 (23:03 -0500)]
Add block notice stats on EditPage.
Monitoring block notices is behind $wgEnableBlockNoticeStats config
flag which is set to false by default.
The reason behind this metric is to get an idea on how
frequently blocked users attempt to edit a page. Similar tracking
is being added to MobileFrontend and VisualEditor.
Bug: T201718
Change-Id: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
jenkins-bot [Wed, 28 Nov 2018 01:42:12 +0000 (01:42 +0000)]
Merge "SQLite: Make patch-add-3d.sql a no-op"
daniel [Wed, 14 Nov 2018 17:07:20 +0000 (18:07 +0100)]
Use ParserCache in CategoryMembershipChangeJob
Note that we will still be re-parsing either the old or the new
revision. Keeping the rendered version of the old revision cached
for a bit would be nice, but ParserCache currently does not
support this.
Bug: T205369
Change-Id: I86d26e494924eec24e7b1fb32c424ac1284be478
Volker E [Tue, 27 Nov 2018 23:03:02 +0000 (15:03 -0800)]
Special:Preferences: Add example value as placeholder to timezone offset
Adding example value as placeholder message in timezone offset input.
Bug: T194524
Change-Id: I1fd6183233109355e49b7baecf44a8603c1efdb2
Ed Sanders [Tue, 27 Nov 2018 22:36:25 +0000 (22:36 +0000)]
eslint: Drop 'dot-notation' rule
Bug: T210552
Change-Id: I07620ed2e3a1acfd3193e411c8369722ae751ffa
jenkins-bot [Tue, 27 Nov 2018 21:39:50 +0000 (21:39 +0000)]
Merge "SpecialPreferences: Make save button bar sticky"
jenkins-bot [Tue, 27 Nov 2018 21:20:40 +0000 (21:20 +0000)]
Merge "ApiSandbox: Fix sticky value for Webkit"
jenkins-bot [Tue, 27 Nov 2018 21:14:52 +0000 (21:14 +0000)]
Merge "Fix global variable name typo in LocalIdLookupTest.php"
jenkins-bot [Tue, 27 Nov 2018 20:59:37 +0000 (20:59 +0000)]
Merge "Don't indicate partial blocks on Special:ListUsers"
Translation updater bot [Tue, 27 Nov 2018 20:57:42 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1a1e1cf1ee78dc6cb1bafe95a6fae84a4aef558b
Volker E [Tue, 27 Nov 2018 20:26:27 +0000 (12:26 -0800)]
ApiSandbox: Fix sticky value for Webkit
Change-Id: I86dbfc259630f3e1f3de7d4f4f7bb4fc70588fb5
Ed Sanders [Tue, 6 Nov 2018 13:31:47 +0000 (13:31 +0000)]
SpecialPreferences: Make save button bar sticky
Enable `position: sticky` on preferences buttons and degrade
gracefully in unsupported browsers, where this results in no
change.
Bug: T205866
Change-Id: Ic98a9d94d3136a4003370cf0e2a8efb7ae1a3f38