From: Roan Kattouw Date: Fri, 16 Jun 2017 23:12:31 +0000 (-0700) Subject: RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set X-Git-Tag: 1.31.0-rc.0~2876^2 X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22lang_raccourcis%22%2C%22module=%24nom_module%22%29%20.%20%22?a=commitdiff_plain;h=b4ef22f17f3fb726510759fee72668a7bcb254f8;p=lhc%2Fweb%2Fwiklou.git RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set It has the effect of breaking pagination entirely when a date range is set. Special:Contributions doesn't break this way because it has its own code clearing start/end when offset is set, but Special:Newfiles does break. Change-Id: Ie9b26a4b54ebc608035c942b5bdc6ee26b82bc1e --- diff --git a/includes/pager/RangeChronologicalPager.php b/includes/pager/RangeChronologicalPager.php index 901d576df9..d3cb566823 100644 --- a/includes/pager/RangeChronologicalPager.php +++ b/includes/pager/RangeChronologicalPager.php @@ -99,13 +99,6 @@ abstract class RangeChronologicalPager extends ReverseChronologicalPager { * @return array */ protected function buildQueryInfo( $offset, $limit, $descending ) { - if ( count( $this->rangeConds ) > 0 ) { - // If range conditions are set, $offset is not used. - // However, if range conditions aren't set, (such as when using paging links) - // use the provided offset to get the proper query. - $offset = ''; - } - list( $tables, $fields, $conds, $fname, $options, $join_conds ) = parent::buildQueryInfo( $offset, $limit,