From: Dayllan Maza <dmaza@wikimedia.org>
Date: Wed, 16 Jan 2019 18:20:51 +0000 (-0500)
Subject: Fix BlockList params for non-editing partial blocks
X-Git-Tag: 1.34.0-rc.0~3069^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22lang_raccourcis%22%2C%22module=%24nom_module%22%29%20.%20%22?a=commitdiff_plain;h=3f69f0eb8845fda3fd0c51ecae3c4bf8d2e8457b;p=lhc%2Fweb%2Fwiklou.git

Fix BlockList params for non-editing partial blocks

When multiple blocks are listed, if there is a partial block
with restrictions, any other partial block in the list will be
shown as an editing block even if it isn't.

Bug: T213952
Change-Id: Ieafb5f71c484d9f0551fa293f7c43e1a3a2e1f2a
---

diff --git a/includes/specials/pagers/BlockListPager.php b/includes/specials/pagers/BlockListPager.php
index a0b14d2cdb..205ffbf8b0 100644
--- a/includes/specials/pagers/BlockListPager.php
+++ b/includes/specials/pagers/BlockListPager.php
@@ -199,7 +199,9 @@ class BlockListPager extends TablePager {
 
 				if ( !$row->ipb_sitewide && $this->restrictions ) {
 					$list = $this->getRestrictionListHTML( $this->restrictions, $row );
-					$properties[] = htmlspecialchars( $msg['blocklist-editing'] ) . $list;
+					if ( $list ) {
+						$properties[] = htmlspecialchars( $msg['blocklist-editing'] ) . $list;
+					}
 				}
 
 				if ( $row->ipb_anon_only ) {