From: Aryeh Gregor <ayg@aryeh.name>
Date: Fri, 10 Aug 2018 08:26:57 +0000 (+0300)
Subject: Improve MediaWikiVersionFetcherTest
X-Git-Tag: 1.34.0-rc.0~4494^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22lang_raccourcis%22%2C%22module=%24nom_module%22%29%20.%20%22?a=commitdiff_plain;h=0278585c72ae738a6be162206ecaf4e06ecbf917;p=lhc%2Fweb%2Fwiklou.git

Improve MediaWikiVersionFetcherTest

Let's test that the value is actually correct, not just that it's a
string.

Change-Id: I4d76a48696a838ee6882ffce10d024f7518dcd4a
---

diff --git a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php
index 87a7dffde1..cb234b2c31 100644
--- a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php
+++ b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php
@@ -10,13 +10,14 @@
  *
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
  */
-class MediaWikiVersionFetcherTest extends PHPUnit\Framework\TestCase {
+class MediaWikiVersionFetcherTest extends MediaWikiTestCase {
 
 	use MediaWikiCoversValidator;
 
 	public function testReturnsResult() {
+		global $wgVersion;
 		$versionFetcher = new MediaWikiVersionFetcher();
-		$this->assertInternalType( 'string', $versionFetcher->fetchVersion() );
+		$this->assertSame( $wgVersion, $versionFetcher->fetchVersion() );
 	}
 
 }