Do not call the 'UploadStashFile' hook for partially uploaded files
authorBartosz Dziewoński <matma.rex@gmail.com>
Tue, 16 Aug 2016 23:34:52 +0000 (01:34 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Tue, 16 Aug 2016 23:34:52 +0000 (01:34 +0200)
commit09f2cba0068378854a69320f10e6d71c4546f516
tree6b348a2a191cca7f92f32804f1b5276239f99511
parentb5e308c4e1232d43c2369006ddcd552341bcaece
Do not call the 'UploadStashFile' hook for partially uploaded files

Consumers of this hook don't expect partial files, and even if they did,
they have no way to tell if they've been given a partial file.

Also document a pre-existing restriction that verifyUpload() must be
called first (for non-partial files). ApiUpload previously called this
function for partial files too, causing T143161.

Follow-up to 2ee27d9a4de163dc3a2b752823a04f5338005627.

Bug: T143161
Change-Id: I107cb957e046545ea72834d72233cc1ed2867e42
includes/api/ApiUpload.php
includes/upload/UploadBase.php