From b4ef22f17f3fb726510759fee72668a7bcb254f8 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Fri, 16 Jun 2017 16:12:31 -0700 Subject: [PATCH] RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set It has the effect of breaking pagination entirely when a date range is set. Special:Contributions doesn't break this way because it has its own code clearing start/end when offset is set, but Special:Newfiles does break. Change-Id: Ie9b26a4b54ebc608035c942b5bdc6ee26b82bc1e --- includes/pager/RangeChronologicalPager.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/includes/pager/RangeChronologicalPager.php b/includes/pager/RangeChronologicalPager.php index 901d576df9..d3cb566823 100644 --- a/includes/pager/RangeChronologicalPager.php +++ b/includes/pager/RangeChronologicalPager.php @@ -99,13 +99,6 @@ abstract class RangeChronologicalPager extends ReverseChronologicalPager { * @return array */ protected function buildQueryInfo( $offset, $limit, $descending ) { - if ( count( $this->rangeConds ) > 0 ) { - // If range conditions are set, $offset is not used. - // However, if range conditions aren't set, (such as when using paging links) - // use the provided offset to get the proper query. - $offset = ''; - } - list( $tables, $fields, $conds, $fname, $options, $join_conds ) = parent::buildQueryInfo( $offset, $limit, -- 2.20.1