From 46ab7a82908933454c43259cf7e1fae1f316e51f Mon Sep 17 00:00:00 2001 From: Florianschmidtwelzow Date: Wed, 28 Oct 2015 15:39:39 +0100 Subject: [PATCH] HTMLRadioField: Use another variable for the radio value to avoid conflicts $value is used in a foreach loop to build the radioselect fields array for OOUI, but $value is also the variable, which holds the default value for the element (or a value, which ws submitted by the user), to pre-select the correct radio input field. That results in the problem, that $value will always contain the last data, which passed the foreach loop, and always the last radio input field will be pre- selected, no matter, what the developer defined as the default or what the user submitted in a prior form instance. Change the variable used in the foreach loop to avoid this conflict. Change-Id: I36c760be8ccd86e75249c966f697b499576c83d4 --- includes/htmlform/HTMLRadioField.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/htmlform/HTMLRadioField.php b/includes/htmlform/HTMLRadioField.php index 19b45bea17..2d057042ef 100644 --- a/includes/htmlform/HTMLRadioField.php +++ b/includes/htmlform/HTMLRadioField.php @@ -40,9 +40,9 @@ class HTMLRadioField extends HTMLFormField { function getInputOOUI( $value ) { $options = array(); - foreach ( $this->getOptions() as $label => $value ) { + foreach ( $this->getOptions() as $label => $data ) { $options[] = array( - 'data' => $value, + 'data' => $data, 'label' => $this->mOptionsLabelsNotFromMessage ? new OOUI\HtmlSnippet( $label ) : $label, ); } -- 2.20.1