From: Aaron Schulz <aschulz@wikimedia.org>
Date: Fri, 25 May 2018 22:00:55 +0000 (-0700)
Subject: resourceloader: Remove use of $.params in mediawiki.js
X-Git-Tag: 1.34.0-rc.0~5253^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%22id_auteur=%24connect_id_auteur%22%29%20.%20%22?a=commitdiff_plain;h=f0d74cc23a22e3c083b303eed71bd94e1c5f24b5;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Remove use of $.params in mediawiki.js

Bug: T192623
Change-Id: I05ce4a05fda5ae13ad85c3d8da8362488b5d46af
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index 2d3f6ad33f..b00cbffcb0 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1577,6 +1577,17 @@
 				}
 			}
 
+			/**
+			 * @private
+			 * @param {Object} params Map of parameter names to values
+			 * @return {string}
+			 */
+			function makeQueryString( params ) {
+				return Object.keys( params ).map( function ( key ) {
+					return encodeURIComponent( key ) + '=' + encodeURIComponent( params[ key ] );
+				} ).join( '&' );
+			}
+
 			/**
 			 * Create network requests for a batch of modules.
 			 *
@@ -1610,7 +1621,7 @@
 					// combining versions from the module query string in-order. (T188076)
 					query.version = getCombinedVersion( packed.list );
 					query = sortQuery( query );
-					addScript( sourceLoadScript + '?' + $.param( query ) );
+					addScript( sourceLoadScript + '?' + makeQueryString( query ) );
 				}
 
 				if ( !batch.length ) {
@@ -1666,7 +1677,7 @@
 						// > '&modules='.length === 9
 						// > '&version=1234567'.length === 16
 						// > 9 + 16 = 25
-						currReqBaseLength = $.param( currReqBase ).length + 25;
+						currReqBaseLength = makeQueryString( currReqBase ).length + 25;
 
 						// We may need to split up the request to honor the query string length limit,
 						// so build it piece by piece.