From: Antoine Musso <hashar@free.fr>
Date: Thu, 19 Jul 2018 15:35:59 +0000 (+0200)
Subject: test: disable hook when testing default preferences
X-Git-Tag: 1.34.0-rc.0~4123^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%22id_auteur=%24connect_id_auteur%22%29%20.%20%22?a=commitdiff_plain;h=eb8e2ba2340018fc325bbff5de0d020ecfcb96aa;p=lhc%2Fweb%2Fwiklou.git

test: disable hook when testing default preferences

The GetPreferences hook lets extensions register additional user
preferences.  They show up on the form and that breaks the hardcoded
assertion that exactly 5 preferences are available.

Disable the hook in case the test is run with extensions loaded in (ex:
BetaFeatures).

Change-Id: I78b11e989110407cd721e8a3fbbe81d28ca4be5b
---

diff --git a/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php b/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
index 43c678e928..2eec5ce238 100644
--- a/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
+++ b/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
@@ -63,6 +63,8 @@ class DefaultPreferencesFactoryTest extends MediaWikiTestCase {
 	 * @covers MediaWiki\Preferences\DefaultPreferencesFactory::getForm()
 	 */
 	public function testGetForm() {
+		$this->setTemporaryHook( 'GetPreferences', null );
+
 		$testUser = $this->getTestUser();
 		$form = $this->getPreferencesFactory()->getForm( $testUser->getUser(), $this->context );
 		$this->assertInstanceOf( PreferencesFormLegacy::class, $form );