resourceloader: Use document.head instead of getElementsByTagName

Supported in all Grade A browsers. Also already being used
by jquery.js (without fallback), which we depend on.

Browser support (per MDN):
- Desktop: Chrome 4+, FF 4+, Edge, IE 9+, Opera 11+, Safari 5+
- Mobile: Android, Edge, FF Mobile 4+, IE Mobile 9+, Opera Mobile,
  Mobile Safari

(Those without numbers, have support since their initial release)

Change-Id: I2e9820de8463518a14a0d679d1f339c3a2f9dc66

diff --git a/resources/src/mediawiki.legacy/wikibits.js b/resources/src/mediawiki.legacy/wikibits.js
index f5bdfd8..27d049e 100644 (file)
--- a/resources/src/mediawiki.legacy/wikibits.js
+++ b/resources/src/mediawiki.legacy/wikibits.js
@@ -49,7 +49,7 @@
                loadedScripts[ url ] = true;
                s = document.createElement( 'script' );
                s.setAttribute( 'src', url );
-               document.getElementsByTagName( 'head' )[ 0 ].appendChild( s );
+               document.head.appendChild( s );
                return s;
        }
 
@@ -72,7 +72,7 @@
                if ( media ) {
                        l.media = media;
                }
-               document.getElementsByTagName( 'head' )[ 0 ].appendChild( l );
+               document.head.appendChild( l );
                return l;
        }
 

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index a661ae5..592fc9e 100644 (file)
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -902,7 +902,7 @@
                                if ( nextNode && nextNode.parentNode ) {
                                        nextNode.parentNode.insertBefore( s, nextNode );
                                } else {
-                                       document.getElementsByTagName( 'head' )[ 0 ].appendChild( s );
+                                       document.head.appendChild( s );
                                }
 
                                return s;

diff --git a/resources/src/startup.js b/resources/src/startup.js
index b0c1578..8e8463d 100644 (file)
--- a/resources/src/startup.js
+++ b/resources/src/startup.js
@@ -162,5 +162,5 @@ window.isCompatible = function ( str ) {
                // Callback
                startUp();
        };
-       document.getElementsByTagName( 'head' )[ 0 ].appendChild( script );
+       document.head.appendChild( script );
 }() );