From faae4b23a5383a7474583be8850298eb6e54e0b4 Mon Sep 17 00:00:00 2001 From: Greg Sabino Mullane Date: Fri, 30 Oct 2009 16:19:39 +0000 Subject: [PATCH] Fix groupby issue in SpecialActiveusers --- RELEASE-NOTES | 1 + includes/specials/SpecialActiveusers.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index c5126dbd88..45e1e4170c 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -610,6 +610,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * The error message shown in Special:ChangePassword now parses wiki markup * (bug 19859) Removed experimental HTMLDiff feature * Removed section edit links in edit conflict form +* Allow SpecialActiveusers to work on non-MySQL databases == API changes in 1.16 == diff --git a/includes/specials/SpecialActiveusers.php b/includes/specials/SpecialActiveusers.php index 34e8cec0a1..105be7369a 100644 --- a/includes/specials/SpecialActiveusers.php +++ b/includes/specials/SpecialActiveusers.php @@ -65,7 +65,7 @@ class ActiveUsersPager extends UsersPager { 'MAX(ipb_user) AS blocked' ), 'options' => array( - 'GROUP BY' => 'rc_user_text', + 'GROUP BY' => $dbr->implicitGroupby() ? 'rc_user_text' : 'rc_user_text, user_id', 'USE INDEX' => array( 'recentchanges' => 'rc_user_text' ) ), 'join_conds' => array( -- 2.20.1